1. docker
  2. Commit 8f8a2db52c309b87872a3930c017b8d1db1df9ab
Browse code

client: rename validateAPIVersion to validateServiceSpecForAPIVersion

This function is used to validate a service-spec for a specific API
version; renaming it to be less ambiguous.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Sebastiaan van Stijn authored on 2025/09/17 23:04:30
Showing 2 changed files
client/service_create.go
History View file @ 8f8a2db
... ... 
@@ -37,7 +37,7 @@ func (cli *Client) ServiceCreate(ctx context.Context, service swarm.ServiceSpec,
37 37 
 		return response, err
38 38 
 	}
39 39 
 	if versions.LessThan(cli.version, "1.30") {
40 
-		if err := validateAPIVersion(service, cli.version); err != nil {
40 
+		if err := validateServiceSpecForAPIVersion(service, cli.version); err != nil {
41 41 
 			return response, err
42 42 
 		}
43 43 
 	}
... ... 
@@ -196,7 +196,7 @@ func validateServiceSpec(s swarm.ServiceSpec) error {
196 196 
 	return nil
197 197 
 }
198 198
199 
-func validateAPIVersion(c swarm.ServiceSpec, apiVersion string) error {
199 
+func validateServiceSpecForAPIVersion(c swarm.ServiceSpec, apiVersion string) error {
200 200 
 	for _, m := range c.TaskTemplate.ContainerSpec.Mounts {
201 201 
 		if m.BindOptions != nil {
202 202 
 			if m.BindOptions.NonRecursive && versions.LessThan(apiVersion, "1.40") {
vendor/github.com/moby/moby/client/service_create.go
History View file @ 8f8a2db
... ... 
@@ -37,7 +37,7 @@ func (cli *Client) ServiceCreate(ctx context.Context, service swarm.ServiceSpec,
37 37 
 		return response, err
38 38 
 	}
39 39 
 	if versions.LessThan(cli.version, "1.30") {
40 
-		if err := validateAPIVersion(service, cli.version); err != nil {
40 
+		if err := validateServiceSpecForAPIVersion(service, cli.version); err != nil {
41 41 
 			return response, err
42 42 
 		}
43 43 
 	}
... ... 
@@ -196,7 +196,7 @@ func validateServiceSpec(s swarm.ServiceSpec) error {
196 196 
 	return nil
197 197 
 }
198 198
199 
-func validateAPIVersion(c swarm.ServiceSpec, apiVersion string) error {
199 
+func validateServiceSpecForAPIVersion(c swarm.ServiceSpec, apiVersion string) error {
200 200 
 	for _, m := range c.TaskTemplate.ContainerSpec.Mounts {
201 201 
 		if m.BindOptions != nil {
202 202 
 			if m.BindOptions.NonRecursive && versions.LessThan(apiVersion, "1.40") {