GitList

Browse code

Close tarsplit gzip writer when creating tar-split.json.gz files during layer migration

There is a missing call to Close on the gzip.Writer that is used to
compress newly created tar-split files during layer migration. This can
result in corrupt tar-split files that later cause docker push and
docker save to fail. The Close call is necessary to flush buffered data
to the stream.

Fixes: #20104

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
(cherry picked from commit 1c05c65f6fbb5ea35608da259dfe4a6d211dbf82)

Aaron Lehmann authored on 2016/02/19 03:55:38
Showing 1 changed files

layer/migration.go index ac0f006..b45c310 100644

layer/migration.go

History View file @ 9032ad5

@@ -127,6 +127,7 @@ func (ls *layerStore) checksumForGraphIDNoTarsplit(id, parent, newTarDataPath st
+                     	}
                      	defer f.Close()
                      	mfz := gzip.NewWriter(f)
                     +	defer mfz.Close()
                      	metaPacker := storage.NewJSONPacker(mfz)
                      	packerCounter := &packSizeCounter{metaPacker, &size}