Browse code

integration-cli: fixups

Signed-off-by: Antonio Murdaca <runcom@redhat.com>

Antonio Murdaca authored on 2016/03/03 19:51:59
Showing 1 changed files
... ...
@@ -116,7 +116,14 @@ func (s *DockerExternalVolumeSuite) SetUpSuite(c *check.C) {
116 116
 
117 117
 	mux.HandleFunc("/VolumeDriver.List", func(w http.ResponseWriter, r *http.Request) {
118 118
 		s.ec.lists++
119
-		send(w, map[string][]vol{"Volumes": volList})
119
+		vols := []vol{}
120
+		for _, v := range volList {
121
+			if v.Ninja {
122
+				continue
123
+			}
124
+			vols = append(vols, v)
125
+		}
126
+		send(w, map[string][]vol{"Volumes": vols})
120 127
 	})
121 128
 
122 129
 	mux.HandleFunc("/VolumeDriver.Get", func(w http.ResponseWriter, r *http.Request) {
... ...
@@ -149,15 +156,10 @@ func (s *DockerExternalVolumeSuite) SetUpSuite(c *check.C) {
149 149
 			return
150 150
 		}
151 151
 
152
-		if err := os.RemoveAll(hostVolumePath(pr.Name)); err != nil {
153
-			send(w, &pluginResp{Err: err.Error()})
154
-			return
155
-		}
156
-
157 152
 		for i, v := range volList {
158 153
 			if v.Name == pr.Name {
159 154
 				if err := os.RemoveAll(hostVolumePath(v.Name)); err != nil {
160
-					send(w, fmt.Sprintf(`{"Err": "%v"}`, err))
155
+					send(w, &pluginResp{Err: err.Error()})
161 156
 					return
162 157
 				}
163 158
 				volList = append(volList[:i], volList[i+1:]...)
... ...
@@ -266,7 +268,7 @@ func (s *DockerExternalVolumeSuite) TestExternalVolumeDriverUnnamed(c *check.C)
266 266
 	c.Assert(s.ec.unmounts, checker.Equals, 1)
267 267
 }
268 268
 
269
-func (s DockerExternalVolumeSuite) TestExternalVolumeDriverVolumesFrom(c *check.C) {
269
+func (s *DockerExternalVolumeSuite) TestExternalVolumeDriverVolumesFrom(c *check.C) {
270 270
 	err := s.d.StartWithBusybox()
271 271
 	c.Assert(err, checker.IsNil)
272 272
 
... ...
@@ -286,7 +288,7 @@ func (s DockerExternalVolumeSuite) TestExternalVolumeDriverVolumesFrom(c *check.
286 286
 	c.Assert(s.ec.unmounts, checker.Equals, 2)
287 287
 }
288 288
 
289
-func (s DockerExternalVolumeSuite) TestExternalVolumeDriverDeleteContainer(c *check.C) {
289
+func (s *DockerExternalVolumeSuite) TestExternalVolumeDriverDeleteContainer(c *check.C) {
290 290
 	err := s.d.StartWithBusybox()
291 291
 	c.Assert(err, checker.IsNil)
292 292
 
... ...
@@ -398,8 +400,8 @@ func (s *DockerExternalVolumeSuite) TestExternalVolumeDriverBindExternalVolume(c
398 398
 	c.Assert(mounts[0].Driver, checker.Equals, "test-external-volume-driver")
399 399
 }
400 400
 
401
-func (s *DockerExternalVolumeSuite) TesttExternalVolumeDriverList(c *check.C) {
402
-	dockerCmd(c, "volume", "create", "-d", "test-external-volume-driver", "--name", "abc")
401
+func (s *DockerExternalVolumeSuite) TestExternalVolumeDriverList(c *check.C) {
402
+	dockerCmd(c, "volume", "create", "-d", "test-external-volume-driver", "--name", "abc3")
403 403
 	out, _ := dockerCmd(c, "volume", "ls")
404 404
 	ls := strings.Split(strings.TrimSpace(out), "\n")
405 405
 	c.Assert(len(ls), check.Equals, 2, check.Commentf("\n%s", out))
... ...
@@ -407,7 +409,7 @@ func (s *DockerExternalVolumeSuite) TesttExternalVolumeDriverList(c *check.C) {
407 407
 	vol := strings.Fields(ls[len(ls)-1])
408 408
 	c.Assert(len(vol), check.Equals, 2, check.Commentf("%v", vol))
409 409
 	c.Assert(vol[0], check.Equals, "test-external-volume-driver")
410
-	c.Assert(vol[1], check.Equals, "abc")
410
+	c.Assert(vol[1], check.Equals, "abc3")
411 411
 
412 412
 	c.Assert(s.ec.lists, check.Equals, 1)
413 413
 }
... ...
@@ -420,11 +422,11 @@ func (s *DockerExternalVolumeSuite) TestExternalVolumeDriverGet(c *check.C) {
420 420
 }
421 421
 
422 422
 func (s *DockerExternalVolumeSuite) TestExternalVolumeDriverWithDaemnRestart(c *check.C) {
423
-	dockerCmd(c, "volume", "create", "-d", "test-external-volume-driver", "--name", "abc")
423
+	dockerCmd(c, "volume", "create", "-d", "test-external-volume-driver", "--name", "abc1")
424 424
 	err := s.d.Restart()
425 425
 	c.Assert(err, checker.IsNil)
426 426
 
427
-	dockerCmd(c, "run", "--name=test", "-v", "abc:/foo", "busybox", "true")
427
+	dockerCmd(c, "run", "--name=test", "-v", "abc1:/foo", "busybox", "true")
428 428
 	var mounts []types.MountPoint
429 429
 	inspectFieldAndMarshall(c, "test", "Mounts", &mounts)
430 430
 	c.Assert(mounts, checker.HasLen, 1)
... ...
@@ -434,8 +436,8 @@ func (s *DockerExternalVolumeSuite) TestExternalVolumeDriverWithDaemnRestart(c *
434 434
 // Ensures that the daemon handles when the plugin responds to a `Get` request with a null volume and a null error.
435 435
 // Prior the daemon would panic in this scenario.
436 436
 func (s *DockerExternalVolumeSuite) TestExternalVolumeDriverGetEmptyResponse(c *check.C) {
437
-	dockerCmd(c, "volume", "create", "-d", "test-external-volume-driver", "--name", "abc", "--opt", "ninja=1")
438
-	out, _, err := dockerCmdWithError("volume", "inspect", "abc")
437
+	dockerCmd(c, "volume", "create", "-d", "test-external-volume-driver", "--name", "abc2", "--opt", "ninja=1")
438
+	out, _, err := dockerCmdWithError("volume", "inspect", "abc2")
439 439
 	c.Assert(err, checker.NotNil, check.Commentf(out))
440 440
 	c.Assert(out, checker.Contains, "No such volume")
441 441
 }