Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
| ... | ... |
@@ -300,48 +300,45 @@ func (s *DockerCLIRunSuite) TestRunWithNetAliasOnDefaultNetworks(c *testing.T) {
|
| 300 | 300 |
} |
| 301 | 301 |
|
| 302 | 302 |
func (s *DockerCLIRunSuite) TestUserDefinedNetworkAlias(c *testing.T) {
|
| 303 |
- testRequires(c, DaemonIsLinux, NotUserNamespace) |
|
| 304 |
- cli.DockerCmd(c, "network", "create", "-d", "bridge", "net1") |
|
| 303 |
+ t := c |
|
| 304 |
+ testRequires(t, DaemonIsLinux, NotUserNamespace) |
|
| 305 |
+ cli.DockerCmd(t, "network", "create", "-d", "bridge", "net1") |
|
| 305 | 306 |
|
| 306 |
- cid1 := cli.DockerCmd(c, "run", "-d", "--net=net1", "--name=first", "--net-alias=foo1", "--net-alias=foo2", "busybox:glibc", "top").Stdout() |
|
| 307 |
- cli.WaitRun(c, "first") |
|
| 307 |
+ cid1 := cli.DockerCmd(t, "run", "-d", "--net=net1", "--name=first", "--net-alias=foo1", "--net-alias=foo2", "busybox:glibc", "top").Stdout() |
|
| 308 |
+ cid1 = strings.TrimSpace(cid1) |
|
| 309 |
+ cli.WaitRun(t, "first") |
|
| 308 | 310 |
|
| 309 | 311 |
// Check if default short-id alias is added automatically |
| 310 |
- id := strings.TrimSpace(cid1) |
|
| 311 |
- aliases := inspectField(c, id, "NetworkSettings.Networks.net1.Aliases") |
|
| 312 |
- assert.Assert(c, is.Contains(aliases, stringid.TruncateID(id))) |
|
| 313 |
- cid2 := cli.DockerCmd(c, "run", "-d", "--net=net1", "--name=second", "busybox:glibc", "top").Stdout() |
|
| 314 |
- cli.WaitRun(c, "second") |
|
| 312 |
+ aliases := cli.DockerCmd(t, "container", "inspect", "--format", "{{.NetworkSettings.Networks.net1.Aliases}}", cid1).Stdout()
|
|
| 313 |
+ assert.Assert(t, is.Contains(aliases, stringid.TruncateID(cid1))) |
|
| 314 |
+ assert.Assert(t, is.Contains(aliases, "foo1")) |
|
| 315 |
+ assert.Assert(t, is.Contains(aliases, "foo2")) |
|
| 316 |
+ |
|
| 317 |
+ cid2 := cli.DockerCmd(t, "run", "-d", "--net=net1", "--name=second", "busybox:glibc", "top").Stdout() |
|
| 318 |
+ cid2 = strings.TrimSpace(cid2) |
|
| 319 |
+ cli.WaitRun(t, "second") |
|
| 315 | 320 |
|
| 316 | 321 |
// Check if default short-id alias is added automatically |
| 317 |
- id = strings.TrimSpace(cid2) |
|
| 318 |
- aliases = inspectField(c, id, "NetworkSettings.Networks.net1.Aliases") |
|
| 319 |
- assert.Assert(c, is.Contains(aliases, stringid.TruncateID(id))) |
|
| 322 |
+ aliases = cli.DockerCmd(t, "container", "inspect", "--format", "{{.NetworkSettings.Networks.net1.Aliases}}", cid2).Stdout()
|
|
| 323 |
+ assert.Assert(t, is.Contains(aliases, stringid.TruncateID(cid2))) |
|
| 324 |
+ |
|
| 320 | 325 |
// ping to first and its network-scoped aliases |
| 321 |
- _, _, err := dockerCmdWithError("exec", "second", "ping", "-c", "1", "first")
|
|
| 322 |
- assert.NilError(c, err) |
|
| 323 |
- _, _, err = dockerCmdWithError("exec", "second", "ping", "-c", "1", "foo1")
|
|
| 324 |
- assert.NilError(c, err) |
|
| 325 |
- _, _, err = dockerCmdWithError("exec", "second", "ping", "-c", "1", "foo2")
|
|
| 326 |
- assert.NilError(c, err) |
|
| 326 |
+ cli.DockerCmd(t, "exec", "second", "ping", "-c", "1", "first") |
|
| 327 |
+ cli.DockerCmd(t, "exec", "second", "ping", "-c", "1", "foo1") |
|
| 328 |
+ cli.DockerCmd(t, "exec", "second", "ping", "-c", "1", "foo2") |
|
| 327 | 329 |
// ping first container's short-id alias |
| 328 |
- _, _, err = dockerCmdWithError("exec", "second", "ping", "-c", "1", stringid.TruncateID(cid1))
|
|
| 329 |
- assert.NilError(c, err) |
|
| 330 |
+ cli.DockerCmd(t, "exec", "second", "ping", "-c", "1", stringid.TruncateID(cid1)) |
|
| 330 | 331 |
|
| 331 | 332 |
// Restart first container |
| 332 |
- cli.DockerCmd(c, "restart", "first") |
|
| 333 |
- cli.WaitRun(c, "first") |
|
| 333 |
+ cli.DockerCmd(t, "restart", "first") |
|
| 334 |
+ cli.WaitRun(t, "first") |
|
| 334 | 335 |
|
| 335 | 336 |
// ping to first and its network-scoped aliases must succeed |
| 336 |
- _, _, err = dockerCmdWithError("exec", "second", "ping", "-c", "1", "first")
|
|
| 337 |
- assert.NilError(c, err) |
|
| 338 |
- _, _, err = dockerCmdWithError("exec", "second", "ping", "-c", "1", "foo1")
|
|
| 339 |
- assert.NilError(c, err) |
|
| 340 |
- _, _, err = dockerCmdWithError("exec", "second", "ping", "-c", "1", "foo2")
|
|
| 341 |
- assert.NilError(c, err) |
|
| 337 |
+ cli.DockerCmd(t, "exec", "second", "ping", "-c", "1", "first") |
|
| 338 |
+ cli.DockerCmd(t, "exec", "second", "ping", "-c", "1", "foo1") |
|
| 339 |
+ cli.DockerCmd(t, "exec", "second", "ping", "-c", "1", "foo2") |
|
| 342 | 340 |
// ping first container's short-id alias |
| 343 |
- _, _, err = dockerCmdWithError("exec", "second", "ping", "-c", "1", stringid.TruncateID(cid1))
|
|
| 344 |
- assert.NilError(c, err) |
|
| 341 |
+ cli.DockerCmd(t, "exec", "second", "ping", "-c", "1", stringid.TruncateID(cid1)) |
|
| 345 | 342 |
} |
| 346 | 343 |
|
| 347 | 344 |
// Issue 9677. |