Browse code

Rename newer build_shell target to build

These two targets seem interchangeable, just that the old `build` target
always built the `final` Dockerfile target even if the source was going
to be bind mounted anyway.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>

Brian Goff authored on 2020/04/03 07:27:31
Showing 1 changed files
... ...
@@ -187,15 +187,6 @@ autogen:
187 187
 binary dynbinary cross: buildx autogen
188 188
 	$(BUILD_CMD) $(BUILD_OPTS) --output=bundles/ --target=$@ $(VERSION_AUTOGEN_ARGS) .
189 189
 
190
-build: target = --target=final
191
-ifdef USE_BUILDX
192
-build: bundles buildx
193
-	$(BUILD_CMD) $(BUILD_OPTS) $(BUILD_CROSS) $(target) -t "$(DOCKER_IMAGE)" .
194
-else
195
-build: bundles ## This is a legacy target and you should probably use something else.
196
-	$(BUILD_CMD) $(BUILD_OPTS) -t "$(DOCKER_IMAGE)" $(BUILD_CROSS) $(target) .
197
-endif
198
-
199 190
 bundles:
200 191
 	mkdir bundles
201 192
 
... ...
@@ -215,19 +206,19 @@ install: ## install the linux binaries
215 215
 run: build ## run the docker daemon in a container
216 216
 	$(DOCKER_RUN_DOCKER) sh -c "KEEPBUNDLE=1 hack/make.sh install-binary run"
217 217
  
218
-.PHONY: build_shell
218
+.PHONY: build
219 219
 ifeq ($(BIND_DIR), .)
220
-build_shell: shell_target := --target=dev
220
+build: shell_target := --target=dev
221 221
 else
222
-build_shell: shell_target := --target=final
222
+build: shell_target := --target=final
223 223
 endif
224 224
 ifdef USE_BUILDX
225
-build_shell: buildx_load := --load
225
+build: buildx_load := --load
226 226
 endif
227
-build_shell: buildx
227
+build: buildx
228 228
 	$(BUILD_CMD) $(BUILD_OPTS) $(shell_target) $(buildx_load) $(BUILD_CROSS) -t "$(DOCKER_IMAGE)" .
229 229
 
230
-shell: build_shell  ## start a shell inside the build env
230
+shell: build  ## start a shell inside the build env
231 231
 	$(DOCKER_RUN_DOCKER) bash
232 232
 
233 233
 test: build test-unit ## run the unit, integration and docker-py tests