Browse code

Fix nonewmountns for containerd options

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>

Michael Crosby authored on 2017/12/05 04:17:30
Showing 1 changed files
... ...
@@ -14,7 +14,6 @@ import (
14 14
 	"github.com/docker/docker/cmd/dockerd/hack"
15 15
 	"github.com/docker/docker/daemon"
16 16
 	"github.com/docker/docker/libcontainerd"
17
-	"github.com/docker/docker/pkg/parsers/kernel"
18 17
 	"github.com/docker/libnetwork/portallocator"
19 18
 	"golang.org/x/sys/unix"
20 19
 )
... ...
@@ -38,24 +37,13 @@ func getDaemonConfDir(_ string) string {
38 38
 }
39 39
 
40 40
 func (cli *DaemonCli) getPlatformRemoteOptions() ([]libcontainerd.RemoteOption, error) {
41
-	// On older kernel, letting putting the containerd-shim in its own
42
-	// namespace will effectively prevent operations such as unlink, rename
43
-	// and remove on mountpoints that were present at the time the shim
44
-	// namespace was created. This would led to a famous EBUSY will trying to
45
-	// remove shm mounts.
46
-	var noNewNS bool
47
-	if !kernel.CheckKernelVersion(3, 18, 0) {
48
-		noNewNS = true
49
-	}
50
-
51 41
 	opts := []libcontainerd.RemoteOption{
52 42
 		libcontainerd.WithOOMScore(cli.Config.OOMScoreAdjust),
53 43
 		libcontainerd.WithPlugin("linux", &linux.Config{
54
-			Shim:          daemon.DefaultShimBinary,
55
-			Runtime:       daemon.DefaultRuntimeBinary,
56
-			RuntimeRoot:   filepath.Join(cli.Config.Root, "runc"),
57
-			ShimDebug:     cli.Config.Debug,
58
-			ShimNoMountNS: noNewNS,
44
+			Shim:        daemon.DefaultShimBinary,
45
+			Runtime:     daemon.DefaultRuntimeBinary,
46
+			RuntimeRoot: filepath.Join(cli.Config.Root, "runc"),
47
+			ShimDebug:   cli.Config.Debug,
59 48
 		}),
60 49
 	}
61 50
 	if cli.Config.Debug {