Browse code

Rename BINDDIR to BIND_DIR

It turns out the back-to-back `D`s here were tripping people up because visually, it looks like a typo. This renames the variable to `BIND_DIR`, but allows `BINDDIR` to continue working for backwards-compatibility.

Signed-off-by: Andrew "Tianon" Page <admwiggin@gmail.com>

Tianon Gravi authored on 2015/02/14 07:50:42
Showing 3 changed files
... ...
@@ -13,10 +13,11 @@ DOCKER_ENVS := \
13 13
 	-e TIMEOUT
14 14
 # note: we _cannot_ add "-e DOCKER_BUILDTAGS" here because even if it's unset in the shell, that would shadow the "ENV DOCKER_BUILDTAGS" set in our Dockerfile, which is very important for our official builds
15 15
 
16
-# to allow `make BINDDIR=. shell` or `make BINDDIR= test`
16
+# to allow `make BIND_DIR=. shell` or `make BIND_DIR= test`
17 17
 # (default to no bind mount if DOCKER_HOST is set)
18
-BINDDIR := $(if $(DOCKER_HOST),,bundles)
19
-DOCKER_MOUNT := $(if $(BINDDIR),-v "$(CURDIR)/$(BINDDIR):/go/src/github.com/docker/docker/$(BINDDIR)")
18
+# note: BINDDIR is supported for backwards-compatibility here
19
+BIND_DIR := $(if $(BINDDIR),$(BINDDIR),$(if $(DOCKER_HOST),,bundles))
20
+DOCKER_MOUNT := $(if $(BIND_DIR),-v "$(CURDIR)/$(BIND_DIR):/go/src/github.com/docker/docker/$(BIND_DIR)")
20 21
 
21 22
 # to allow `make DOCSDIR=docs docs-shell` (to create a bind mount in docs)
22 23
 DOCS_MOUNT := $(if $(DOCSDIR),-v $(CURDIR)/$(DOCSDIR):/$(DOCSDIR))
... ...
@@ -73,13 +73,13 @@ To create the Docker binary, run this command:
73 73
     $ make binary
74 74
 
75 75
 This will create the Docker binary in `./bundles/<version>-dev/binary/`. If you
76
-do not see files in the `./bundles` directory in your host, your `BINDDIR`
77
-setting is not set quite right. You want to run the following command: 
78
-    
79
-    $ make BINDDIR=. binary 
76
+do not see files in the `./bundles` directory in your host, your `BIND_DIR`
77
+setting is not set quite right. You want to run the following command:
78
+
79
+    $ make BIND_DIR=. binary
80 80
 
81 81
 If you are on a non-Linux platform, e.g., OSX, you'll want to run `make cross`
82
-or `make BINDDIR=. cross`.
82
+or `make BIND_DIR=. cross`.
83 83
 
84 84
 ### Using your built Docker binary
85 85
 
... ...
@@ -1,7 +1,7 @@
1 1
 // This code was initially generated by ffjson <https://github.com/pquerna/ffjson>
2 2
 // This code was generated via the following steps:
3 3
 // $ go get -u github.com/pquerna/ffjson
4
-// $ make shell BINDDIR=.
4
+// $ make BIND_DIR=. shell
5 5
 // $ ffjson pkg/jsonlog/jsonlog.go
6 6
 // $ mv pkg/jsonglog/jsonlog_ffjson.go pkg/jsonlog/jsonlog_marshalling.go
7 7
 //