Browse code

Remove container name not empty check

Signed-off-by: Megan Kostick <mkostick@us.ibm.com>

Megan Kostick authored on 2015/04/11 01:53:40
Showing 3 changed files
... ...
@@ -21,6 +21,10 @@ func (cli *DockerCli) CmdDiff(args ...string) error {
21 21
 	cmd.Require(flag.Exact, 1)
22 22
 	cmd.ParseFlags(args, true)
23 23
 
24
+	if cmd.Arg(0) == "" {
25
+		return fmt.Errorf("Container name cannot be empty")
26
+	}
27
+
24 28
 	rdr, _, err := cli.call("GET", "/containers/"+cmd.Arg(0)+"/changes", nil, nil)
25 29
 	if err != nil {
26 30
 		return err
... ...
@@ -30,6 +30,10 @@ func (cli *DockerCli) CmdRm(args ...string) error {
30 30
 
31 31
 	var encounteredError error
32 32
 	for _, name := range cmd.Args() {
33
+		if name == "" {
34
+			return fmt.Errorf("Container name cannot be empty")
35
+		}
36
+
33 37
 		_, _, err := readBody(cli.call("DELETE", "/containers/"+name+"?"+val.Encode(), nil, nil))
34 38
 		if err != nil {
35 39
 			fmt.Fprintf(cli.err, "%s\n", err)
... ...
@@ -466,10 +466,6 @@ func getContainersChanges(eng *engine.Engine, version version.Version, w http.Re
466 466
 	}
467 467
 
468 468
 	name := vars["name"]
469
-	if name == "" {
470
-		return fmt.Errorf("Container name cannot be empty")
471
-	}
472
-
473 469
 	d := getDaemon(eng)
474 470
 	cont, err := d.Get(name)
475 471
 	if err != nil {
... ...
@@ -883,10 +879,6 @@ func deleteContainers(eng *engine.Engine, version version.Version, w http.Respon
883 883
 	}
884 884
 
885 885
 	name := vars["name"]
886
-	if name == "" {
887
-		return fmt.Errorf("Container name cannot be empty")
888
-	}
889
-
890 886
 	d := getDaemon(eng)
891 887
 	config := &daemon.ContainerRmConfig{
892 888
 		ForceRemove:  toBool(r.Form.Get("force")),
... ...
@@ -895,6 +887,10 @@ func deleteContainers(eng *engine.Engine, version version.Version, w http.Respon
895 895
 	}
896 896
 
897 897
 	if err := d.ContainerRm(name, config); err != nil {
898
+		// Force a 404 for the empty string
899
+		if strings.Contains(strings.ToLower(err.Error()), "prefix can't be empty") {
900
+			return fmt.Errorf("no such id: \"\"")
901
+		}
898 902
 		return err
899 903
 	}
900 904