Browse code

Cleanup docs Dockerfile, so it matches best practices.

Docker-DCO-1.1-Signed-off-by: Joseph Ferguson <joe@infosiftr.com> (github: yosifkit)

Joe Ferguson authored on 2014/10/23 07:14:02
Showing 1 changed files
... ...
@@ -1,49 +1,59 @@
1 1
 #
2 2
 # See the top level Makefile in https://github.com/docker/docker for usage.
3 3
 #
4
-FROM 		debian:jessie
5
-MAINTAINER	Sven Dowideit <SvenDowideit@docker.com> (@SvenDowideit)
6
-
7
-RUN 	apt-get update && apt-get install -y make python-pip python-setuptools vim-tiny git gettext python-dev libssl-dev
8
-
9
-RUN	pip install mkdocs
4
+FROM debian:jessie
5
+MAINTAINER Sven Dowideit <SvenDowideit@docker.com> (@SvenDowideit)
6
+
7
+RUN apt-get update \
8
+	&& apt-get install -y \
9
+		gettext \
10
+		git \
11
+		libssl-dev \
12
+		make \
13
+		python-dev \
14
+		python-pip \
15
+		python-setuptools \
16
+		vim-tiny
17
+
18
+RUN pip install mkdocs
10 19
 
11 20
 # add MarkdownTools to get transclusion
12 21
 # (future development)
13
-#RUN	easy_install -U setuptools
14
-#RUN	pip install MarkdownTools2
22
+#RUN easy_install -U setuptools
23
+#RUN pip install MarkdownTools2
15 24
 
16 25
 # this version works, the current versions fail in different ways
17
-RUN	pip install awscli==1.4.4 pyopenssl==0.12
18
-
19
-# make sure the git clone is not an old cache - we've published old versions a few times now
20
-ENV	CACHE_BUST Jul2014
26
+RUN pip install awscli==1.4.4 pyopenssl==0.12
21 27
 
22 28
 # get my sitemap.xml branch of mkdocs and use that for now
23
-RUN	git clone https://github.com/SvenDowideit/mkdocs	&&\
24
-	cd mkdocs/						&&\
25
-	git checkout docker-markdown-merge			&&\
26
-	./setup.py install
27
-
28
-ADD 	. /docs
29
-ADD	MAINTAINERS /docs/sources/humans.txt
30
-WORKDIR	/docs
31
-
32
-RUN	VERSION=$(cat /docs/VERSION)								&&\
33
-        MAJOR_MINOR="${VERSION%.*}"								&&\
34
-	for i in $(seq $MAJOR_MINOR -0.1 1.0) ; do echo "<li><a class='version' href='/v$i'>Version v$i</a></li>" ; done > /docs/sources/versions.html_fragment &&\
35
-	GIT_BRANCH=$(cat /docs/GIT_BRANCH)							&&\
36
-	GITCOMMIT=$(cat /docs/GITCOMMIT)							&&\
37
-	AWS_S3_BUCKET=$(cat /docs/AWS_S3_BUCKET)						&&\
38
-	BUILD_DATE=$(date)									&&\
39
-	sed -i "s/\$VERSION/$VERSION/g" /docs/theme/mkdocs/base.html				&&\
40
-	sed -i "s/\$MAJOR_MINOR/v$MAJOR_MINOR/g" /docs/theme/mkdocs/base.html			&&\
41
-	sed -i "s/\$GITCOMMIT/$GITCOMMIT/g" /docs/theme/mkdocs/base.html			&&\
42
-	sed -i "s/\$GIT_BRANCH/$GIT_BRANCH/g" /docs/theme/mkdocs/base.html			&&\
43
-	sed -i "s/\$BUILD_DATE/$BUILD_DATE/g" /docs/theme/mkdocs/base.html				&&\
44
-	sed -i "s/\$AWS_S3_BUCKET/$AWS_S3_BUCKET/g" /docs/theme/mkdocs/base.html
45
-
46
-# note, EXPOSE is only last because of https://github.com/docker/docker/issues/3525
47
-EXPOSE	8000
48
-
49
-CMD 	["mkdocs", "serve"]
29
+# commit hash of the newest commit of SvenDowideit/mkdocs on
30
+# docker-markdown-merge branch, it is used to break docker cache
31
+# see: https://github.com/SvenDowideit/mkdocs/tree/docker-markdown-merge
32
+RUN git clone -b docker-markdown-merge https://github.com/SvenDowideit/mkdocs \
33
+	&& cd mkdocs/ \
34
+	&& git checkout ad32549c452963b8854951d6783f4736c0f7c5d5 \
35
+	&& ./setup.py install
36
+
37
+COPY . /docs
38
+COPY MAINTAINERS /docs/sources/humans.txt
39
+WORKDIR /docs
40
+
41
+RUN VERSION=$(cat VERSION) \
42
+	&& MAJOR_MINOR="${VERSION%.*}" \
43
+	&& for i in $(seq $MAJOR_MINOR -0.1 1.0); do \
44
+		echo "<li><a class='version' href='/v$i'>Version v$i</a></li>"; \
45
+	done > sources/versions.html_fragment \
46
+	&& GIT_BRANCH=$(cat GIT_BRANCH) \
47
+	&& GITCOMMIT=$(cat GITCOMMIT) \
48
+	&& AWS_S3_BUCKET=$(cat AWS_S3_BUCKET) \
49
+	&& BUILD_DATE=$(date) \
50
+	&& sed -i "s/\$VERSION/$VERSION/g" theme/mkdocs/base.html \
51
+	&& sed -i "s/\$MAJOR_MINOR/v$MAJOR_MINOR/g" theme/mkdocs/base.html \
52
+	&& sed -i "s/\$GITCOMMIT/$GITCOMMIT/g" .heme/mkdocs/base.html \
53
+	&& sed -i "s/\$GIT_BRANCH/$GIT_BRANCH/g" theme/mkdocs/base.html \
54
+	&& sed -i "s/\$BUILD_DATE/$BUILD_DATE/g" theme/mkdocs/base.html \
55
+	&& sed -i "s/\$AWS_S3_BUCKET/$AWS_S3_BUCKET/g" theme/mkdocs/base.html
56
+
57
+EXPOSE 8000
58
+
59
+CMD ["mkdocs", "serve"]