Browse code

api/client: unify format of args check

Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>

Ma Shimiao authored on 2015/07/03 18:26:09
Showing 18 changed files
... ...
@@ -16,17 +16,14 @@ import (
16 16
 //
17 17
 // Usage: docker attach [OPTIONS] CONTAINER
18 18
 func (cli *DockerCli) CmdAttach(args ...string) error {
19
-	var (
20
-		cmd     = cli.Subcmd("attach", []string{"CONTAINER"}, "Attach to a running container", true)
21
-		noStdin = cmd.Bool([]string{"#nostdin", "-no-stdin"}, false, "Do not attach STDIN")
22
-		proxy   = cmd.Bool([]string{"#sig-proxy", "-sig-proxy"}, true, "Proxy all received signals to the process")
23
-	)
19
+	cmd := cli.Subcmd("attach", []string{"CONTAINER"}, "Attach to a running container", true)
20
+	noStdin := cmd.Bool([]string{"#nostdin", "-no-stdin"}, false, "Do not attach STDIN")
21
+	proxy := cmd.Bool([]string{"#sig-proxy", "-sig-proxy"}, true, "Proxy all received signals to the process")
24 22
 	cmd.Require(flag.Exact, 1)
25 23
 
26 24
 	cmd.ParseFlags(args, true)
27
-	name := cmd.Arg(0)
28 25
 
29
-	stream, _, _, err := cli.call("GET", "/containers/"+name+"/json", nil, nil)
26
+	stream, _, _, err := cli.call("GET", "/containers/"+cmd.Arg(0)+"/json", nil, nil)
30 27
 	if err != nil {
31 28
 		return err
32 29
 	}
... ...
@@ -60,8 +60,8 @@ func (cli *DockerCli) CmdBuild(args ...string) error {
60 60
 	flCPUSetCpus := cmd.String([]string{"-cpuset-cpus"}, "", "CPUs in which to allow execution (0-3, 0,1)")
61 61
 	flCPUSetMems := cmd.String([]string{"-cpuset-mems"}, "", "MEMs in which to allow execution (0-3, 0,1)")
62 62
 	flCgroupParent := cmd.String([]string{"-cgroup-parent"}, "", "Optional parent cgroup for the container")
63
-
64 63
 	cmd.Require(flag.Exact, 1)
64
+
65 65
 	cmd.ParseFlags(args, true)
66 66
 
67 67
 	var (
... ...
@@ -27,6 +27,7 @@ func (cli *DockerCli) CmdCommit(args ...string) error {
27 27
 	flConfig := cmd.String([]string{"#run", "#-run"}, "", "This option is deprecated and will be removed in a future version in favor of inline Dockerfile-compatible commands")
28 28
 	cmd.Require(flag.Max, 2)
29 29
 	cmd.Require(flag.Min, 1)
30
+
30 31
 	cmd.ParseFlags(args, true)
31 32
 
32 33
 	var (
... ...
@@ -19,6 +19,7 @@ import (
19 19
 func (cli *DockerCli) CmdDiff(args ...string) error {
20 20
 	cmd := cli.Subcmd("diff", []string{"CONTAINER"}, "Inspect changes on a container's filesystem", true)
21 21
 	cmd.Require(flag.Exact, 1)
22
+
22 23
 	cmd.ParseFlags(args, true)
23 24
 
24 25
 	if cmd.Arg(0) == "" {
... ...
@@ -22,6 +22,7 @@ func (cli *DockerCli) CmdHistory(args ...string) error {
22 22
 	quiet := cmd.Bool([]string{"q", "-quiet"}, false, "Only show numeric IDs")
23 23
 	noTrunc := cmd.Bool([]string{"#notrunc", "-no-trunc"}, false, "Don't truncate output")
24 24
 	cmd.Require(flag.Exact, 1)
25
+
25 26
 	cmd.ParseFlags(args, true)
26 27
 
27 28
 	rdr, _, _, err := cli.call("GET", "/images/"+cmd.Arg(0)+"/history", nil, nil)
... ...
@@ -30,6 +30,7 @@ func (cli *DockerCli) CmdImages(args ...string) error {
30 30
 	flFilter := opts.NewListOpts(nil)
31 31
 	cmd.Var(&flFilter, []string{"f", "-filter"}, "Filter output based on conditions provided")
32 32
 	cmd.Require(flag.Max, 1)
33
+
33 34
 	cmd.ParseFlags(args, true)
34 35
 
35 36
 	// Consolidate all filter flags, and sanity check them early.
... ...
@@ -16,6 +16,7 @@ import (
16 16
 func (cli *DockerCli) CmdInfo(args ...string) error {
17 17
 	cmd := cli.Subcmd("info", nil, "Display system-wide information", true)
18 18
 	cmd.Require(flag.Exact, 0)
19
+
19 20
 	cmd.ParseFlags(args, true)
20 21
 
21 22
 	rdr, _, _, err := cli.call("GET", "/info", nil, nil)
... ...
@@ -19,7 +19,6 @@ func (cli *DockerCli) CmdInspect(args ...string) error {
19 19
 	cmd := cli.Subcmd("inspect", []string{"CONTAINER|IMAGE [CONTAINER|IMAGE...]"}, "Return low-level information on a container or image", true)
20 20
 	tmplStr := cmd.String([]string{"f", "#format", "-format"}, "", "Format the output using the given go template")
21 21
 	inspectType := cmd.String([]string{"-type"}, "", "Return JSON for specified type, (e.g image or container)")
22
-
23 22
 	cmd.Require(flag.Min, 1)
24 23
 
25 24
 	cmd.ParseFlags(args, true)
... ...
@@ -17,6 +17,7 @@ func (cli *DockerCli) CmdLogout(args ...string) error {
17 17
 	cmd.Require(flag.Max, 1)
18 18
 
19 19
 	cmd.ParseFlags(args, true)
20
+
20 21
 	serverAddress := registry.IndexServerAddress()
21 22
 	if len(cmd.Args()) > 0 {
22 23
 		serverAddress = cmd.Arg(0)
... ...
@@ -15,13 +15,11 @@ import (
15 15
 //
16 16
 // docker logs [OPTIONS] CONTAINER
17 17
 func (cli *DockerCli) CmdLogs(args ...string) error {
18
-	var (
19
-		cmd    = cli.Subcmd("logs", []string{"CONTAINER"}, "Fetch the logs of a container", true)
20
-		follow = cmd.Bool([]string{"f", "-follow"}, false, "Follow log output")
21
-		since  = cmd.String([]string{"-since"}, "", "Show logs since timestamp")
22
-		times  = cmd.Bool([]string{"t", "-timestamps"}, false, "Show timestamps")
23
-		tail   = cmd.String([]string{"-tail"}, "all", "Number of lines to show from the end of the logs")
24
-	)
18
+	cmd := cli.Subcmd("logs", []string{"CONTAINER"}, "Fetch the logs of a container", true)
19
+	follow := cmd.Bool([]string{"f", "-follow"}, false, "Follow log output")
20
+	since := cmd.String([]string{"-since"}, "", "Show logs since timestamp")
21
+	times := cmd.Bool([]string{"t", "-timestamps"}, false, "Show timestamps")
22
+	tail := cmd.String([]string{"-tail"}, "all", "Number of lines to show from the end of the logs")
25 23
 	cmd.Require(flag.Exact, 1)
26 24
 
27 25
 	cmd.ParseFlags(args, true)
... ...
@@ -12,6 +12,7 @@ import (
12 12
 func (cli *DockerCli) CmdPause(args ...string) error {
13 13
 	cmd := cli.Subcmd("pause", []string{"CONTAINER [CONTAINER...]"}, "Pause all processes within a container", true)
14 14
 	cmd.Require(flag.Min, 1)
15
+
15 16
 	cmd.ParseFlags(args, true)
16 17
 
17 18
 	var errNames []string
... ...
@@ -16,6 +16,7 @@ import (
16 16
 func (cli *DockerCli) CmdPort(args ...string) error {
17 17
 	cmd := cli.Subcmd("port", []string{"CONTAINER [PRIVATE_PORT[/PROTO]]"}, "List port mappings for the CONTAINER, or lookup the public-facing port that\nis NAT-ed to the PRIVATE_PORT", true)
18 18
 	cmd.Require(flag.Min, 1)
19
+
19 20
 	cmd.ParseFlags(args, true)
20 21
 
21 22
 	stream, _, _, err := cli.call("GET", "/containers/"+cmd.Arg(0)+"/json", nil, nil)
... ...
@@ -18,9 +18,7 @@ func (cli *DockerCli) CmdPush(args ...string) error {
18 18
 
19 19
 	cmd.ParseFlags(args, true)
20 20
 
21
-	name := cmd.Arg(0)
22
-
23
-	remote, tag := parsers.ParseRepositoryTag(name)
21
+	remote, tag := parsers.ParseRepositoryTag(cmd.Arg(0))
24 22
 
25 23
 	// Resolve the Repository name from fqn to RepositoryInfo
26 24
 	repoInfo, err := registry.ParseRepositoryInfo(remote)
... ...
@@ -12,6 +12,7 @@ import (
12 12
 func (cli *DockerCli) CmdRename(args ...string) error {
13 13
 	cmd := cli.Subcmd("rename", []string{"OLD_NAME NEW_NAME"}, "Rename a container", true)
14 14
 	cmd.Require(flag.Exact, 2)
15
+
15 16
 	cmd.ParseFlags(args, true)
16 17
 
17 18
 	oldName := cmd.Arg(0)
... ...
@@ -13,12 +13,11 @@ import (
13 13
 //
14 14
 // Usage: docker rmi [OPTIONS] IMAGE [IMAGE...]
15 15
 func (cli *DockerCli) CmdRmi(args ...string) error {
16
-	var (
17
-		cmd     = cli.Subcmd("rmi", []string{"IMAGE [IMAGE...]"}, "Remove one or more images", true)
18
-		force   = cmd.Bool([]string{"f", "-force"}, false, "Force removal of the image")
19
-		noprune = cmd.Bool([]string{"-no-prune"}, false, "Do not delete untagged parents")
20
-	)
16
+	cmd := cli.Subcmd("rmi", []string{"IMAGE [IMAGE...]"}, "Remove one or more images", true)
17
+	force := cmd.Bool([]string{"f", "-force"}, false, "Force removal of the image")
18
+	noprune := cmd.Bool([]string{"-no-prune"}, false, "Do not delete untagged parents")
21 19
 	cmd.Require(flag.Min, 1)
20
+
22 21
 	cmd.ParseFlags(args, true)
23 22
 
24 23
 	v := url.Values{}
... ...
@@ -44,18 +44,18 @@ func (cli *DockerCli) forwardAllSignals(cid string) chan os.Signal {
44 44
 //
45 45
 // Usage: docker start [OPTIONS] CONTAINER [CONTAINER...]
46 46
 func (cli *DockerCli) CmdStart(args ...string) error {
47
+	cmd := cli.Subcmd("start", []string{"CONTAINER [CONTAINER...]"}, "Start one or more stopped containers", true)
48
+	attach := cmd.Bool([]string{"a", "-attach"}, false, "Attach STDOUT/STDERR and forward signals")
49
+	openStdin := cmd.Bool([]string{"i", "-interactive"}, false, "Attach container's STDIN")
50
+	cmd.Require(flag.Min, 1)
51
+
52
+	cmd.ParseFlags(args, true)
53
+
47 54
 	var (
48 55
 		cErr chan error
49 56
 		tty  bool
50
-
51
-		cmd       = cli.Subcmd("start", []string{"CONTAINER [CONTAINER...]"}, "Start one or more stopped containers", true)
52
-		attach    = cmd.Bool([]string{"a", "-attach"}, false, "Attach STDOUT/STDERR and forward signals")
53
-		openStdin = cmd.Bool([]string{"i", "-interactive"}, false, "Attach container's STDIN")
54 57
 	)
55 58
 
56
-	cmd.Require(flag.Min, 1)
57
-	cmd.ParseFlags(args, true)
58
-
59 59
 	if *attach || *openStdin {
60 60
 		if cmd.NArg() > 1 {
61 61
 			return fmt.Errorf("You cannot start and attach multiple containers at once.")
... ...
@@ -127,6 +127,7 @@ func (cli *DockerCli) CmdStats(args ...string) error {
127 127
 	cmd := cli.Subcmd("stats", []string{"CONTAINER [CONTAINER...]"}, "Display a live stream of one or more containers' resource usage statistics", true)
128 128
 	noStream := cmd.Bool([]string{"-no-stream"}, false, "Disable streaming stats and only pull the first result")
129 129
 	cmd.Require(flag.Min, 1)
130
+
130 131
 	cmd.ParseFlags(args, true)
131 132
 
132 133
 	names := cmd.Args()
... ...
@@ -12,6 +12,7 @@ import (
12 12
 func (cli *DockerCli) CmdUnpause(args ...string) error {
13 13
 	cmd := cli.Subcmd("unpause", []string{"CONTAINER [CONTAINER...]"}, "Unpause all processes within a container", true)
14 14
 	cmd.Require(flag.Min, 1)
15
+
15 16
 	cmd.ParseFlags(args, true)
16 17
 
17 18
 	var errNames []string