Closes #16667
Uses the prefix "devicemapper:" for all the fmt and logrus error, debug, and info messages.
Signed-off-by: Chris Dituri <csdituri@gmail.com>
... | ... |
@@ -135,10 +135,10 @@ func (t *Task) destroy() { |
135 | 135 |
func TaskCreateNamed(t TaskType, name string) (*Task, error) { |
136 | 136 |
task := TaskCreate(t) |
137 | 137 |
if task == nil { |
138 |
- return nil, fmt.Errorf("Can't create task of type %d", int(t)) |
|
138 |
+ return nil, fmt.Errorf("devicemapper: Can't create task of type %d", int(t)) |
|
139 | 139 |
} |
140 | 140 |
if err := task.setName(name); err != nil { |
141 |
- return nil, fmt.Errorf("Can't set task name %s", name) |
|
141 |
+ return nil, fmt.Errorf("devicemapper: Can't set task name %s", name) |
|
142 | 142 |
} |
143 | 143 |
return task, nil |
144 | 144 |
} |
... | ... |
@@ -260,7 +260,7 @@ func (t *Task) getNextTarget(next unsafe.Pointer) (nextPtr unsafe.Pointer, start |
260 | 260 |
func getLoopbackBackingFile(file *os.File) (uint64, uint64, error) { |
261 | 261 |
loopInfo, err := ioctlLoopGetStatus64(file.Fd()) |
262 | 262 |
if err != nil { |
263 |
- logrus.Errorf("Error get loopback backing file: %s", err) |
|
263 |
+ logrus.Errorf("devicemapper: Error get loopback backing file: %s", err) |
|
264 | 264 |
return 0, 0, ErrGetLoopbackBackingFile |
265 | 265 |
} |
266 | 266 |
return loopInfo.loDevice, loopInfo.loInode, nil |
... | ... |
@@ -269,7 +269,7 @@ func getLoopbackBackingFile(file *os.File) (uint64, uint64, error) { |
269 | 269 |
// LoopbackSetCapacity reloads the size for the loopback device. |
270 | 270 |
func LoopbackSetCapacity(file *os.File) error { |
271 | 271 |
if err := ioctlLoopSetCapacity(file.Fd(), 0); err != nil { |
272 |
- logrus.Errorf("Error loopbackSetCapacity: %s", err) |
|
272 |
+ logrus.Errorf("devicemapper: Error loopbackSetCapacity: %s", err) |
|
273 | 273 |
return ErrLoopbackSetCapacity |
274 | 274 |
} |
275 | 275 |
return nil |
... | ... |
@@ -312,7 +312,7 @@ func FindLoopDeviceFor(file *os.File) *os.File { |
312 | 312 |
// UdevWait waits for any processes that are waiting for udev to complete the specified cookie. |
313 | 313 |
func UdevWait(cookie *uint) error { |
314 | 314 |
if res := DmUdevWait(*cookie); res != 1 { |
315 |
- logrus.Debugf("Failed to wait on udev cookie %d", *cookie) |
|
315 |
+ logrus.Debugf("devicemapper: Failed to wait on udev cookie %d", *cookie) |
|
316 | 316 |
return ErrUdevWait |
317 | 317 |
} |
318 | 318 |
return nil |
... | ... |
@@ -334,7 +334,7 @@ func LogInit(logger DevmapperLogger) { |
334 | 334 |
// SetDevDir sets the dev folder for the device mapper library (usually /dev). |
335 | 335 |
func SetDevDir(dir string) error { |
336 | 336 |
if res := DmSetDevDir(dir); res != 1 { |
337 |
- logrus.Debugf("Error dm_set_dev_dir") |
|
337 |
+ logrus.Debugf("devicemapper: Error dm_set_dev_dir") |
|
338 | 338 |
return ErrSetDevDir |
339 | 339 |
} |
340 | 340 |
return nil |
... | ... |
@@ -385,7 +385,7 @@ func RemoveDevice(name string) error { |
385 | 385 |
|
386 | 386 |
var cookie uint |
387 | 387 |
if err := task.setCookie(&cookie, 0); err != nil { |
388 |
- return fmt.Errorf("Can not set cookie: %s", err) |
|
388 |
+ return fmt.Errorf("devicemapper: Can not set cookie: %s", err) |
|
389 | 389 |
} |
390 | 390 |
defer UdevWait(&cookie) |
391 | 391 |
|
... | ... |
@@ -394,7 +394,7 @@ func RemoveDevice(name string) error { |
394 | 394 |
if dmSawBusy { |
395 | 395 |
return ErrBusy |
396 | 396 |
} |
397 |
- return fmt.Errorf("Error running RemoveDevice %s", err) |
|
397 |
+ return fmt.Errorf("devicemapper: Error running RemoveDevice %s", err) |
|
398 | 398 |
} |
399 | 399 |
|
400 | 400 |
return nil |
... | ... |
@@ -402,8 +402,8 @@ func RemoveDevice(name string) error { |
402 | 402 |
|
403 | 403 |
// RemoveDeviceDeferred is a useful helper for cleaning up a device, but deferred. |
404 | 404 |
func RemoveDeviceDeferred(name string) error { |
405 |
- logrus.Debugf("[devmapper] RemoveDeviceDeferred START(%s)", name) |
|
406 |
- defer logrus.Debugf("[devmapper] RemoveDeviceDeferred END(%s)", name) |
|
405 |
+ logrus.Debugf("devicemapper: RemoveDeviceDeferred START(%s)", name) |
|
406 |
+ defer logrus.Debugf("devicemapper: RemoveDeviceDeferred END(%s)", name) |
|
407 | 407 |
task, err := TaskCreateNamed(deviceRemove, name) |
408 | 408 |
if task == nil { |
409 | 409 |
return err |
... | ... |
@@ -414,7 +414,7 @@ func RemoveDeviceDeferred(name string) error { |
414 | 414 |
} |
415 | 415 |
|
416 | 416 |
if err = task.run(); err != nil { |
417 |
- return fmt.Errorf("Error running RemoveDeviceDeferred %s", err) |
|
417 |
+ return fmt.Errorf("devicemapper: Error running RemoveDeviceDeferred %s", err) |
|
418 | 418 |
} |
419 | 419 |
|
420 | 420 |
return nil |
... | ... |
@@ -428,11 +428,11 @@ func CancelDeferredRemove(deviceName string) error { |
428 | 428 |
} |
429 | 429 |
|
430 | 430 |
if err := task.setSector(0); err != nil { |
431 |
- return fmt.Errorf("Can't set sector %s", err) |
|
431 |
+ return fmt.Errorf("devicemapper: Can't set sector %s", err) |
|
432 | 432 |
} |
433 | 433 |
|
434 | 434 |
if err := task.setMessage(fmt.Sprintf("@cancel_deferred_remove")); err != nil { |
435 |
- return fmt.Errorf("Can't set message %s", err) |
|
435 |
+ return fmt.Errorf("devicemapper: Can't set message %s", err) |
|
436 | 436 |
} |
437 | 437 |
|
438 | 438 |
dmSawBusy = false |
... | ... |
@@ -444,7 +444,7 @@ func CancelDeferredRemove(deviceName string) error { |
444 | 444 |
} else if dmSawEnxio { |
445 | 445 |
return ErrEnxio |
446 | 446 |
} |
447 |
- return fmt.Errorf("Error running CancelDeferredRemove %s", err) |
|
447 |
+ return fmt.Errorf("devicemapper: Error running CancelDeferredRemove %s", err) |
|
448 | 448 |
|
449 | 449 |
} |
450 | 450 |
return nil |
... | ... |
@@ -454,7 +454,7 @@ func CancelDeferredRemove(deviceName string) error { |
454 | 454 |
func GetBlockDeviceSize(file *os.File) (uint64, error) { |
455 | 455 |
size, err := ioctlBlkGetSize64(file.Fd()) |
456 | 456 |
if err != nil { |
457 |
- logrus.Errorf("Error getblockdevicesize: %s", err) |
|
457 |
+ logrus.Errorf("devicemapper: Error getblockdevicesize: %s", err) |
|
458 | 458 |
return 0, ErrGetBlockSize |
459 | 459 |
} |
460 | 460 |
return uint64(size), nil |
... | ... |
@@ -497,24 +497,24 @@ func CreatePool(poolName string, dataFile, metadataFile *os.File, poolBlockSize |
497 | 497 |
|
498 | 498 |
size, err := GetBlockDeviceSize(dataFile) |
499 | 499 |
if err != nil { |
500 |
- return fmt.Errorf("Can't get data size %s", err) |
|
500 |
+ return fmt.Errorf("devicemapper: Can't get data size %s", err) |
|
501 | 501 |
} |
502 | 502 |
|
503 | 503 |
params := fmt.Sprintf("%s %s %d 32768 1 skip_block_zeroing", metadataFile.Name(), dataFile.Name(), poolBlockSize) |
504 | 504 |
if err := task.addTarget(0, size/512, "thin-pool", params); err != nil { |
505 |
- return fmt.Errorf("Can't add target %s", err) |
|
505 |
+ return fmt.Errorf("devicemapper: Can't add target %s", err) |
|
506 | 506 |
} |
507 | 507 |
|
508 | 508 |
var cookie uint |
509 | 509 |
var flags uint16 |
510 | 510 |
flags = DmUdevDisableSubsystemRulesFlag | DmUdevDisableDiskRulesFlag | DmUdevDisableOtherRulesFlag |
511 | 511 |
if err := task.setCookie(&cookie, flags); err != nil { |
512 |
- return fmt.Errorf("Can't set cookie %s", err) |
|
512 |
+ return fmt.Errorf("devicemapper: Can't set cookie %s", err) |
|
513 | 513 |
} |
514 | 514 |
defer UdevWait(&cookie) |
515 | 515 |
|
516 | 516 |
if err := task.run(); err != nil { |
517 |
- return fmt.Errorf("Error running deviceCreate (CreatePool) %s", err) |
|
517 |
+ return fmt.Errorf("devicemapper: Error running deviceCreate (CreatePool) %s", err) |
|
518 | 518 |
} |
519 | 519 |
|
520 | 520 |
return nil |
... | ... |
@@ -530,16 +530,16 @@ func ReloadPool(poolName string, dataFile, metadataFile *os.File, poolBlockSize |
530 | 530 |
|
531 | 531 |
size, err := GetBlockDeviceSize(dataFile) |
532 | 532 |
if err != nil { |
533 |
- return fmt.Errorf("Can't get data size %s", err) |
|
533 |
+ return fmt.Errorf("devicemapper: Can't get data size %s", err) |
|
534 | 534 |
} |
535 | 535 |
|
536 | 536 |
params := fmt.Sprintf("%s %s %d 32768 1 skip_block_zeroing", metadataFile.Name(), dataFile.Name(), poolBlockSize) |
537 | 537 |
if err := task.addTarget(0, size/512, "thin-pool", params); err != nil { |
538 |
- return fmt.Errorf("Can't add target %s", err) |
|
538 |
+ return fmt.Errorf("devicemapper: Can't add target %s", err) |
|
539 | 539 |
} |
540 | 540 |
|
541 | 541 |
if err := task.run(); err != nil { |
542 |
- return fmt.Errorf("Error running deviceCreate %s", err) |
|
542 |
+ return fmt.Errorf("devicemapper: Error running deviceCreate %s", err) |
|
543 | 543 |
} |
544 | 544 |
|
545 | 545 |
return nil |
... | ... |
@@ -589,7 +589,7 @@ func GetInfoWithDeferred(name string) (*Info, error) { |
589 | 589 |
func GetDriverVersion() (string, error) { |
590 | 590 |
task := TaskCreate(deviceVersion) |
591 | 591 |
if task == nil { |
592 |
- return "", fmt.Errorf("Can't create deviceVersion task") |
|
592 |
+ return "", fmt.Errorf("devicemapper: Can't create deviceVersion task") |
|
593 | 593 |
} |
594 | 594 |
if err := task.run(); err != nil { |
595 | 595 |
return "", err |
... | ... |
@@ -602,22 +602,22 @@ func GetDriverVersion() (string, error) { |
602 | 602 |
func GetStatus(name string) (uint64, uint64, string, string, error) { |
603 | 603 |
task, err := TaskCreateNamed(deviceStatus, name) |
604 | 604 |
if task == nil { |
605 |
- logrus.Debugf("GetStatus: Error TaskCreateNamed: %s", err) |
|
605 |
+ logrus.Debugf("devicemapper: GetStatus() Error TaskCreateNamed: %s", err) |
|
606 | 606 |
return 0, 0, "", "", err |
607 | 607 |
} |
608 | 608 |
if err := task.run(); err != nil { |
609 |
- logrus.Debugf("GetStatus: Error Run: %s", err) |
|
609 |
+ logrus.Debugf("devicemapper: GetStatus() Error Run: %s", err) |
|
610 | 610 |
return 0, 0, "", "", err |
611 | 611 |
} |
612 | 612 |
|
613 | 613 |
devinfo, err := task.getInfo() |
614 | 614 |
if err != nil { |
615 |
- logrus.Debugf("GetStatus: Error GetInfo: %s", err) |
|
615 |
+ logrus.Debugf("devicemapper: GetStatus() Error GetInfo: %s", err) |
|
616 | 616 |
return 0, 0, "", "", err |
617 | 617 |
} |
618 | 618 |
if devinfo.Exists == 0 { |
619 |
- logrus.Debugf("GetStatus: Non existing device %s", name) |
|
620 |
- return 0, 0, "", "", fmt.Errorf("Non existing device %s", name) |
|
619 |
+ logrus.Debugf("devicemapper: GetStatus() Non existing device %s", name) |
|
620 |
+ return 0, 0, "", "", fmt.Errorf("devicemapper: Non existing device %s", name) |
|
621 | 621 |
} |
622 | 622 |
|
623 | 623 |
_, start, length, targetType, params := task.getNextTarget(unsafe.Pointer(nil)) |
... | ... |
@@ -629,22 +629,22 @@ func GetStatus(name string) (uint64, uint64, string, string, error) { |
629 | 629 |
func GetTable(name string) (uint64, uint64, string, string, error) { |
630 | 630 |
task, err := TaskCreateNamed(deviceTable, name) |
631 | 631 |
if task == nil { |
632 |
- logrus.Debugf("GetTable: Error TaskCreateNamed: %s", err) |
|
632 |
+ logrus.Debugf("devicemapper: GetTable() Error TaskCreateNamed: %s", err) |
|
633 | 633 |
return 0, 0, "", "", err |
634 | 634 |
} |
635 | 635 |
if err := task.run(); err != nil { |
636 |
- logrus.Debugf("GetTable: Error Run: %s", err) |
|
636 |
+ logrus.Debugf("devicemapper: GetTable() Error Run: %s", err) |
|
637 | 637 |
return 0, 0, "", "", err |
638 | 638 |
} |
639 | 639 |
|
640 | 640 |
devinfo, err := task.getInfo() |
641 | 641 |
if err != nil { |
642 |
- logrus.Debugf("GetTable: Error GetInfo: %s", err) |
|
642 |
+ logrus.Debugf("devicemapper: GetTable() Error GetInfo: %s", err) |
|
643 | 643 |
return 0, 0, "", "", err |
644 | 644 |
} |
645 | 645 |
if devinfo.Exists == 0 { |
646 |
- logrus.Debugf("GetTable: Non existing device %s", name) |
|
647 |
- return 0, 0, "", "", fmt.Errorf("Non existing device %s", name) |
|
646 |
+ logrus.Debugf("devicemapper: GetTable() Non existing device %s", name) |
|
647 |
+ return 0, 0, "", "", fmt.Errorf("devicemapper: Non existing device %s", name) |
|
648 | 648 |
} |
649 | 649 |
|
650 | 650 |
_, start, length, targetType, params := task.getNextTarget(unsafe.Pointer(nil)) |
... | ... |
@@ -659,15 +659,15 @@ func SetTransactionID(poolName string, oldID uint64, newID uint64) error { |
659 | 659 |
} |
660 | 660 |
|
661 | 661 |
if err := task.setSector(0); err != nil { |
662 |
- return fmt.Errorf("Can't set sector %s", err) |
|
662 |
+ return fmt.Errorf("devicemapper: Can't set sector %s", err) |
|
663 | 663 |
} |
664 | 664 |
|
665 | 665 |
if err := task.setMessage(fmt.Sprintf("set_transaction_id %d %d", oldID, newID)); err != nil { |
666 |
- return fmt.Errorf("Can't set message %s", err) |
|
666 |
+ return fmt.Errorf("devicemapper: Can't set message %s", err) |
|
667 | 667 |
} |
668 | 668 |
|
669 | 669 |
if err := task.run(); err != nil { |
670 |
- return fmt.Errorf("Error running SetTransactionID %s", err) |
|
670 |
+ return fmt.Errorf("devicemapper: Error running SetTransactionID %s", err) |
|
671 | 671 |
} |
672 | 672 |
return nil |
673 | 673 |
} |
... | ... |
@@ -680,7 +680,7 @@ func SuspendDevice(name string) error { |
680 | 680 |
return err |
681 | 681 |
} |
682 | 682 |
if err := task.run(); err != nil { |
683 |
- return fmt.Errorf("Error running deviceSuspend %s", err) |
|
683 |
+ return fmt.Errorf("devicemapper: Error running deviceSuspend %s", err) |
|
684 | 684 |
} |
685 | 685 |
return nil |
686 | 686 |
} |
... | ... |
@@ -695,12 +695,12 @@ func ResumeDevice(name string) error { |
695 | 695 |
|
696 | 696 |
var cookie uint |
697 | 697 |
if err := task.setCookie(&cookie, 0); err != nil { |
698 |
- return fmt.Errorf("Can't set cookie %s", err) |
|
698 |
+ return fmt.Errorf("devicemapper: Can't set cookie %s", err) |
|
699 | 699 |
} |
700 | 700 |
defer UdevWait(&cookie) |
701 | 701 |
|
702 | 702 |
if err := task.run(); err != nil { |
703 |
- return fmt.Errorf("Error running deviceResume %s", err) |
|
703 |
+ return fmt.Errorf("devicemapper: Error running deviceResume %s", err) |
|
704 | 704 |
} |
705 | 705 |
|
706 | 706 |
return nil |
... | ... |
@@ -708,18 +708,18 @@ func ResumeDevice(name string) error { |
708 | 708 |
|
709 | 709 |
// CreateDevice creates a device with the specified poolName with the specified device id. |
710 | 710 |
func CreateDevice(poolName string, deviceID int) error { |
711 |
- logrus.Debugf("[devmapper] CreateDevice(poolName=%v, deviceID=%v)", poolName, deviceID) |
|
711 |
+ logrus.Debugf("devicemapper: CreateDevice(poolName=%v, deviceID=%v)", poolName, deviceID) |
|
712 | 712 |
task, err := TaskCreateNamed(deviceTargetMsg, poolName) |
713 | 713 |
if task == nil { |
714 | 714 |
return err |
715 | 715 |
} |
716 | 716 |
|
717 | 717 |
if err := task.setSector(0); err != nil { |
718 |
- return fmt.Errorf("Can't set sector %s", err) |
|
718 |
+ return fmt.Errorf("devicemapper: Can't set sector %s", err) |
|
719 | 719 |
} |
720 | 720 |
|
721 | 721 |
if err := task.setMessage(fmt.Sprintf("create_thin %d", deviceID)); err != nil { |
722 |
- return fmt.Errorf("Can't set message %s", err) |
|
722 |
+ return fmt.Errorf("devicemapper: Can't set message %s", err) |
|
723 | 723 |
} |
724 | 724 |
|
725 | 725 |
dmSawExist = false // reset before the task is run |
... | ... |
@@ -729,7 +729,7 @@ func CreateDevice(poolName string, deviceID int) error { |
729 | 729 |
return ErrDeviceIDExists |
730 | 730 |
} |
731 | 731 |
|
732 |
- return fmt.Errorf("Error running CreateDevice %s", err) |
|
732 |
+ return fmt.Errorf("devicemapper: Error running CreateDevice %s", err) |
|
733 | 733 |
|
734 | 734 |
} |
735 | 735 |
return nil |
... | ... |
@@ -743,11 +743,11 @@ func DeleteDevice(poolName string, deviceID int) error { |
743 | 743 |
} |
744 | 744 |
|
745 | 745 |
if err := task.setSector(0); err != nil { |
746 |
- return fmt.Errorf("Can't set sector %s", err) |
|
746 |
+ return fmt.Errorf("devicemapper: Can't set sector %s", err) |
|
747 | 747 |
} |
748 | 748 |
|
749 | 749 |
if err := task.setMessage(fmt.Sprintf("delete %d", deviceID)); err != nil { |
750 |
- return fmt.Errorf("Can't set message %s", err) |
|
750 |
+ return fmt.Errorf("devicemapper: Can't set message %s", err) |
|
751 | 751 |
} |
752 | 752 |
|
753 | 753 |
dmSawBusy = false |
... | ... |
@@ -755,7 +755,7 @@ func DeleteDevice(poolName string, deviceID int) error { |
755 | 755 |
if dmSawBusy { |
756 | 756 |
return ErrBusy |
757 | 757 |
} |
758 |
- return fmt.Errorf("Error running DeleteDevice %s", err) |
|
758 |
+ return fmt.Errorf("devicemapper: Error running DeleteDevice %s", err) |
|
759 | 759 |
} |
760 | 760 |
return nil |
761 | 761 |
} |
... | ... |
@@ -785,21 +785,21 @@ func activateDevice(poolName string, name string, deviceID int, size uint64, ext |
785 | 785 |
params = fmt.Sprintf("%s %d", poolName, deviceID) |
786 | 786 |
} |
787 | 787 |
if err := task.addTarget(0, size/512, "thin", params); err != nil { |
788 |
- return fmt.Errorf("Can't add target %s", err) |
|
788 |
+ return fmt.Errorf("devicemapper: Can't add target %s", err) |
|
789 | 789 |
} |
790 | 790 |
if err := task.setAddNode(addNodeOnCreate); err != nil { |
791 |
- return fmt.Errorf("Can't add node %s", err) |
|
791 |
+ return fmt.Errorf("devicemapper: Can't add node %s", err) |
|
792 | 792 |
} |
793 | 793 |
|
794 | 794 |
var cookie uint |
795 | 795 |
if err := task.setCookie(&cookie, 0); err != nil { |
796 |
- return fmt.Errorf("Can't set cookie %s", err) |
|
796 |
+ return fmt.Errorf("devicemapper: Can't set cookie %s", err) |
|
797 | 797 |
} |
798 | 798 |
|
799 | 799 |
defer UdevWait(&cookie) |
800 | 800 |
|
801 | 801 |
if err := task.run(); err != nil { |
802 |
- return fmt.Errorf("Error running deviceCreate (ActivateDevice) %s", err) |
|
802 |
+ return fmt.Errorf("devicemapper: Error running deviceCreate (ActivateDevice) %s", err) |
|
803 | 803 |
} |
804 | 804 |
|
805 | 805 |
return nil |
... | ... |
@@ -828,14 +828,14 @@ func CreateSnapDevice(poolName string, deviceID int, baseName string, baseDevice |
828 | 828 |
if doSuspend { |
829 | 829 |
ResumeDevice(baseName) |
830 | 830 |
} |
831 |
- return fmt.Errorf("Can't set sector %s", err) |
|
831 |
+ return fmt.Errorf("devicemapper: Can't set sector %s", err) |
|
832 | 832 |
} |
833 | 833 |
|
834 | 834 |
if err := task.setMessage(fmt.Sprintf("create_snap %d %d", deviceID, baseDeviceID)); err != nil { |
835 | 835 |
if doSuspend { |
836 | 836 |
ResumeDevice(baseName) |
837 | 837 |
} |
838 |
- return fmt.Errorf("Can't set message %s", err) |
|
838 |
+ return fmt.Errorf("devicemapper: Can't set message %s", err) |
|
839 | 839 |
} |
840 | 840 |
|
841 | 841 |
dmSawExist = false // reset before the task is run |
... | ... |
@@ -848,7 +848,7 @@ func CreateSnapDevice(poolName string, deviceID int, baseName string, baseDevice |
848 | 848 |
return ErrDeviceIDExists |
849 | 849 |
} |
850 | 850 |
|
851 |
- return fmt.Errorf("Error running deviceCreate (createSnapDevice) %s", err) |
|
851 |
+ return fmt.Errorf("devicemapper: Error running deviceCreate (createSnapDevice) %s", err) |
|
852 | 852 |
|
853 | 853 |
} |
854 | 854 |
|