Signed-off-by: John Howard <jhoward@microsoft.com>
John Howard authored on 2017/09/29 01:42:58... | ... |
@@ -27,6 +27,7 @@ import ( |
27 | 27 |
"github.com/docker/docker/integration-cli/cli/build" |
28 | 28 |
"github.com/docker/docker/integration-cli/cli/build/fakecontext" |
29 | 29 |
"github.com/docker/docker/pkg/mount" |
30 |
+ "github.com/docker/docker/pkg/parsers/kernel" |
|
30 | 31 |
"github.com/docker/docker/pkg/stringid" |
31 | 32 |
"github.com/docker/docker/pkg/stringutils" |
32 | 33 |
"github.com/docker/docker/runconfig" |
... | ... |
@@ -4010,6 +4011,20 @@ func (s *DockerSuite) TestRunNamedVolumesFromNotRemoved(c *check.C) { |
4010 | 4010 |
} |
4011 | 4011 |
|
4012 | 4012 |
func (s *DockerSuite) TestRunAttachFailedNoLeak(c *check.C) { |
4013 |
+ // TODO @msabansal - https://github.com/moby/moby/issues/35023. Duplicate |
|
4014 |
+ // port mappings are not errored out on RS3 builds. Temporarily disabling |
|
4015 |
+ // this test pending further investigation. Note we parse kernel.GetKernelVersion |
|
4016 |
+ // rather than system.GetOSVersion as test binaries aren't manifested, so would |
|
4017 |
+ // otherwise report build 9200. |
|
4018 |
+ if runtime.GOOS == "windows" { |
|
4019 |
+ v, err := kernel.GetKernelVersion() |
|
4020 |
+ c.Assert(err, checker.IsNil) |
|
4021 |
+ build, _ := strconv.Atoi(strings.Split(strings.SplitN(v.String(), " ", 3)[2][1:], ".")[0]) |
|
4022 |
+ if build >= 16292 { // @jhowardmsft TODO - replace with final RS3 build and == |
|
4023 |
+ c.Skip("Temporarily disabled on RS3 builds") |
|
4024 |
+ } |
|
4025 |
+ } |
|
4026 |
+ |
|
4013 | 4027 |
nroutines, err := getGoroutineNumber() |
4014 | 4028 |
c.Assert(err, checker.IsNil) |
4015 | 4029 |
|