parser_test only needed the directory-names for
the tests to run. This replaces f.Readdir() with
f.Readdirnames() to only return the names.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
| ... | ... |
@@ -11,7 +11,7 @@ import ( |
| 11 | 11 |
const testDir = "testfiles" |
| 12 | 12 |
const negativeTestDir = "testfiles-negative" |
| 13 | 13 |
|
| 14 |
-func getDirs(t *testing.T, dir string) []os.FileInfo {
|
|
| 14 |
+func getDirs(t *testing.T, dir string) []string {
|
|
| 15 | 15 |
f, err := os.Open(dir) |
| 16 | 16 |
if err != nil {
|
| 17 | 17 |
t.Fatal(err) |
| ... | ... |
@@ -19,7 +19,7 @@ func getDirs(t *testing.T, dir string) []os.FileInfo {
|
| 19 | 19 |
|
| 20 | 20 |
defer f.Close() |
| 21 | 21 |
|
| 22 |
- dirs, err := f.Readdir(0) |
|
| 22 |
+ dirs, err := f.Readdirnames(0) |
|
| 23 | 23 |
if err != nil {
|
| 24 | 24 |
t.Fatal(err) |
| 25 | 25 |
} |
| ... | ... |
@@ -29,16 +29,16 @@ func getDirs(t *testing.T, dir string) []os.FileInfo {
|
| 29 | 29 |
|
| 30 | 30 |
func TestTestNegative(t *testing.T) {
|
| 31 | 31 |
for _, dir := range getDirs(t, negativeTestDir) {
|
| 32 |
- dockerfile := filepath.Join(negativeTestDir, dir.Name(), "Dockerfile") |
|
| 32 |
+ dockerfile := filepath.Join(negativeTestDir, dir, "Dockerfile") |
|
| 33 | 33 |
|
| 34 | 34 |
df, err := os.Open(dockerfile) |
| 35 | 35 |
if err != nil {
|
| 36 |
- t.Fatalf("Dockerfile missing for %s: %s", dir.Name(), err.Error())
|
|
| 36 |
+ t.Fatalf("Dockerfile missing for %s: %s", dir, err.Error())
|
|
| 37 | 37 |
} |
| 38 | 38 |
|
| 39 | 39 |
_, err = Parse(df) |
| 40 | 40 |
if err == nil {
|
| 41 |
- t.Fatalf("No error parsing broken dockerfile for %s", dir.Name())
|
|
| 41 |
+ t.Fatalf("No error parsing broken dockerfile for %s", dir)
|
|
| 42 | 42 |
} |
| 43 | 43 |
|
| 44 | 44 |
df.Close() |
| ... | ... |
@@ -47,29 +47,29 @@ func TestTestNegative(t *testing.T) {
|
| 47 | 47 |
|
| 48 | 48 |
func TestTestData(t *testing.T) {
|
| 49 | 49 |
for _, dir := range getDirs(t, testDir) {
|
| 50 |
- dockerfile := filepath.Join(testDir, dir.Name(), "Dockerfile") |
|
| 51 |
- resultfile := filepath.Join(testDir, dir.Name(), "result") |
|
| 50 |
+ dockerfile := filepath.Join(testDir, dir, "Dockerfile") |
|
| 51 |
+ resultfile := filepath.Join(testDir, dir, "result") |
|
| 52 | 52 |
|
| 53 | 53 |
df, err := os.Open(dockerfile) |
| 54 | 54 |
if err != nil {
|
| 55 |
- t.Fatalf("Dockerfile missing for %s: %s", dir.Name(), err.Error())
|
|
| 55 |
+ t.Fatalf("Dockerfile missing for %s: %s", dir, err.Error())
|
|
| 56 | 56 |
} |
| 57 | 57 |
defer df.Close() |
| 58 | 58 |
|
| 59 | 59 |
ast, err := Parse(df) |
| 60 | 60 |
if err != nil {
|
| 61 |
- t.Fatalf("Error parsing %s's dockerfile: %s", dir.Name(), err.Error())
|
|
| 61 |
+ t.Fatalf("Error parsing %s's dockerfile: %s", dir, err.Error())
|
|
| 62 | 62 |
} |
| 63 | 63 |
|
| 64 | 64 |
content, err := ioutil.ReadFile(resultfile) |
| 65 | 65 |
if err != nil {
|
| 66 |
- t.Fatalf("Error reading %s's result file: %s", dir.Name(), err.Error())
|
|
| 66 |
+ t.Fatalf("Error reading %s's result file: %s", dir, err.Error())
|
|
| 67 | 67 |
} |
| 68 | 68 |
|
| 69 | 69 |
if ast.Dump()+"\n" != string(content) {
|
| 70 | 70 |
fmt.Fprintln(os.Stderr, "Result:\n"+ast.Dump()) |
| 71 | 71 |
fmt.Fprintln(os.Stderr, "Expected:\n"+string(content)) |
| 72 |
- t.Fatalf("%s: AST dump of dockerfile does not match result", dir.Name())
|
|
| 72 |
+ t.Fatalf("%s: AST dump of dockerfile does not match result", dir)
|
|
| 73 | 73 |
} |
| 74 | 74 |
} |
| 75 | 75 |
} |