The documentation for validate_vendor_used in hack/validate/vendor states
that a warning will be emitted if license information cannot be found in
a vendored package. However, because the script is run with pipefail set
(owing to the inclusion of the common validation script .validate) and
`grep -c` is used, the entire script will fail whenever license information
cannot be found in a vendored package.
Signed-off-by: Chris Price <cprice@mirantis.com>
| ... | ... |
@@ -40,8 +40,7 @@ validate_vendor_diff(){
|
| 40 | 40 |
validate_vendor_used() {
|
| 41 | 41 |
for f in $(mawk '/^[a-zA-Z0-9]/ { print $1 }' vendor.conf); do
|
| 42 | 42 |
if [ -d "vendor/$f" ]; then |
| 43 |
- found=$(echo "vendor/$f/"* | grep -iEc '/(LICENSE|COPYING)') |
|
| 44 |
- if [ "$found" -eq 0 ]; then |
|
| 43 |
+ if ! echo "vendor/$f"/* | grep -qiEc '/(LICENSE|COPYING)'; then |
|
| 45 | 44 |
echo "WARNING: could not find copyright information for $f" |
| 46 | 45 |
fi |
| 47 | 46 |
else |