Browse code

integration-cli: rename var that shadowed package-level const

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Sebastiaan van Stijn authored on 2025/12/03 21:57:41
Showing 1 changed files
... ...
@@ -5010,7 +5010,7 @@ func (s *DockerRegistryAuthHtpasswdSuite) TestBuildWithExternalAuth(c *testing.T
5010 5010
 	testPath := fmt.Sprintf("%s%c%s", osPath, filepath.ListSeparator, absolute)
5011 5011
 	c.Setenv("PATH", testPath)
5012 5012
 
5013
-	repoName := fmt.Sprintf("%v/dockercli/busybox:authtest", privateRegistryURL)
5013
+	imgName := fmt.Sprintf("%v/dockercli/busybox:authtest", privateRegistryURL)
5014 5014
 
5015 5015
 	tmp, err := os.MkdirTemp("", "integration-cli-")
5016 5016
 	assert.NilError(c, err)
... ...
@@ -5026,15 +5026,15 @@ func (s *DockerRegistryAuthHtpasswdSuite) TestBuildWithExternalAuth(c *testing.T
5026 5026
 	b, err := os.ReadFile(configPath)
5027 5027
 	assert.NilError(c, err)
5028 5028
 	assert.Assert(c, !strings.Contains(string(b), "\"auth\":"))
5029
-	cli.DockerCmd(c, "--config", tmp, "tag", "busybox", repoName)
5030
-	cli.DockerCmd(c, "--config", tmp, "push", repoName)
5029
+	cli.DockerCmd(c, "--config", tmp, "tag", "busybox", imgName)
5030
+	cli.DockerCmd(c, "--config", tmp, "push", imgName)
5031 5031
 
5032 5032
 	// make sure the image is pulled when building
5033
-	cli.DockerCmd(c, "rmi", repoName)
5033
+	cli.DockerCmd(c, "rmi", imgName)
5034 5034
 
5035 5035
 	icmd.RunCmd(icmd.Cmd{
5036 5036
 		Command: []string{dockerBinary, "--config", tmp, "build", "-"},
5037
-		Stdin:   strings.NewReader(fmt.Sprintf("FROM %s", repoName)),
5037
+		Stdin:   strings.NewReader(fmt.Sprintf("FROM %s", imgName)),
5038 5038
 	}).Assert(c, icmd.Success)
5039 5039
 }
5040 5040
 
... ...
@@ -5784,7 +5784,7 @@ func (s *DockerCLIBuildSuite) TestBuildMultiStageImplicitFrom(c *testing.T) {
5784 5784
 }
5785 5785
 
5786 5786
 func (s *DockerRegistrySuite) TestBuildMultiStageImplicitPull(c *testing.T) {
5787
-	repoName := fmt.Sprintf("%v/dockercli/testf", privateRegistryURL)
5787
+	imgName := fmt.Sprintf("%v/dockercli/testf", privateRegistryURL)
5788 5788
 
5789 5789
 	dockerfile := `
5790 5790
 		FROM busybox
... ...
@@ -5796,16 +5796,16 @@ func (s *DockerRegistrySuite) TestBuildMultiStageImplicitPull(c *testing.T) {
5796 5796
 		}))
5797 5797
 	defer ctx.Close()
5798 5798
 
5799
-	cli.BuildCmd(c, repoName, build.WithExternalBuildContext(ctx))
5799
+	cli.BuildCmd(c, imgName, build.WithExternalBuildContext(ctx))
5800 5800
 
5801
-	cli.DockerCmd(c, "push", repoName)
5802
-	cli.DockerCmd(c, "rmi", repoName)
5801
+	cli.DockerCmd(c, "push", imgName)
5802
+	cli.DockerCmd(c, "rmi", imgName)
5803 5803
 
5804 5804
 	dockerfile = `
5805 5805
 		FROM busybox
5806 5806
 		COPY --from=%s bar baz`
5807 5807
 
5808
-	ctx = fakecontext.New(c, "", fakecontext.WithDockerfile(fmt.Sprintf(dockerfile, repoName)))
5808
+	ctx = fakecontext.New(c, "", fakecontext.WithDockerfile(fmt.Sprintf(dockerfile, imgName)))
5809 5809
 	defer ctx.Close()
5810 5810
 
5811 5811
 	cli.BuildCmd(c, "build1", build.WithExternalBuildContext(ctx))