Browse code

'docker daemon' deprecation message doesn't use the new versioning scheme

Signed-off-by: yuexiao-wang <wang.yuexiao@zte.com.cn>
(cherry picked from commit 5a9cee7bb57e7da7f2793fbb290498bba0531105)
Signed-off-by: Victor Vieux <victorvieux@gmail.com>

yuexiao-wang authored on 2017/03/01 02:28:33
Showing 6 changed files
... ...
@@ -271,7 +271,7 @@ func prettyPrintInfo(dockerCli *command.DockerCli, info types.Info) error {
271 271
 			fmt.Fprintf(dockerCli.Out(), " %s\n", attribute)
272 272
 		}
273 273
 		// TODO: Engine labels with duplicate keys has been deprecated in 1.13 and will be error out
274
-		// after 3 release cycles (1.16). For now, a WARNING will be generated. The following will
274
+		// after 3 release cycles (17.12). For now, a WARNING will be generated. The following will
275 275
 		// be removed eventually.
276 276
 		labelMap := map[string]string{}
277 277
 		for _, label := range info.Labels {
... ...
@@ -433,7 +433,7 @@ func loadDaemonCliConfig(opts daemonOptions) (*daemon.Config, error) {
433 433
 	// This is deprecated in 1.13, and, be removed after 3 release cycles.
434 434
 	// The following will check the conflict of labels, and report a warning for deprecation.
435 435
 	//
436
-	// TODO: After 3 release cycles (1.16) an error will be returned, and labels will be
436
+	// TODO: After 3 release cycles (17.12) an error will be returned, and labels will be
437 437
 	// sanitized to consolidate duplicate key-value pairs (config.Labels = newLabels):
438 438
 	//
439 439
 	// newLabels, err := daemon.GetConflictFreeLabels(config.Labels)
... ...
@@ -279,7 +279,7 @@ func ReloadConfiguration(configFile string, flags *pflag.FlagSet, reload func(*C
279 279
 	// This is deprecated in 1.13, and, be removed after 3 release cycles.
280 280
 	// The following will check the conflict of labels, and report a warning for deprecation.
281 281
 	//
282
-	// TODO: After 3 release cycles (1.16) an error will be returned, and labels will be
282
+	// TODO: After 3 release cycles (17.12) an error will be returned, and labels will be
283 283
 	// sanitized to consolidate duplicate key-value pairs (config.Labels = newLabels):
284 284
 	//
285 285
 	// newLabels, err := GetConflictFreeLabels(newConfig.Labels)
... ...
@@ -144,7 +144,7 @@ func Init(home string, options []string, uidMaps, gidMaps []idtools.IDMap) (grap
144 144
 		return nil, err
145 145
 	}
146 146
 	if !supportsDType {
147
-		// not a fatal error until v1.16 (#27443)
147
+		// not a fatal error until v17.12 (#27443)
148 148
 		logrus.Warn(overlayutils.ErrDTypeNotSupported("overlay", backingFs))
149 149
 	}
150 150
 
... ...
@@ -170,7 +170,7 @@ func Init(home string, options []string, uidMaps, gidMaps []idtools.IDMap) (grap
170 170
 		return nil, err
171 171
 	}
172 172
 	if !supportsDType {
173
-		// not a fatal error until v1.16 (#27443)
173
+		// not a fatal error until v17.12 (#27443)
174 174
 		logrus.Warn(overlayutils.ErrDTypeNotSupported("overlay2", backingFs))
175 175
 	}
176 176
 
... ...
@@ -13,6 +13,6 @@ func ErrDTypeNotSupported(driver, backingFs string) error {
13 13
 	if backingFs == "xfs" {
14 14
 		msg += " Reformat the filesystem with ftype=1 to enable d_type support."
15 15
 	}
16
-	msg += " Running without d_type support will no longer be supported in Docker 1.16."
16
+	msg += " Running without d_type support will no longer be supported in Docker 17.12."
17 17
 	return errors.New(msg)
18 18
 }