Browse code

Add warning about deprecated "cluster" options to "docker info"

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Sebastiaan van Stijn authored on 2020/03/04 01:27:48
Showing 1 changed files
... ...
@@ -63,8 +63,6 @@ func (daemon *Daemon) SystemInfo() (*types.Info, error) {
63 63
 		Labels:             daemon.configStore.Labels,
64 64
 		ExperimentalBuild:  daemon.configStore.Experimental,
65 65
 		ServerVersion:      dockerversion.Version,
66
-		ClusterStore:       daemon.configStore.ClusterStore,
67
-		ClusterAdvertise:   daemon.configStore.ClusterAdvertise,
68 66
 		HTTPProxy:          maskCredentials(getEnvAny("HTTP_PROXY", "http_proxy")),
69 67
 		HTTPSProxy:         maskCredentials(getEnvAny("HTTPS_PROXY", "https_proxy")),
70 68
 		NoProxy:            getEnvAny("NO_PROXY", "no_proxy"),
... ...
@@ -72,6 +70,7 @@ func (daemon *Daemon) SystemInfo() (*types.Info, error) {
72 72
 		Isolation:          daemon.defaultIsolation,
73 73
 	}
74 74
 
75
+	daemon.fillClusterInfo(v)
75 76
 	daemon.fillAPIInfo(v)
76 77
 	// Retrieve platform specific info
77 78
 	daemon.fillPlatformInfo(v, sysInfo)
... ...
@@ -127,6 +126,16 @@ func (daemon *Daemon) SystemVersion() types.Version {
127 127
 	return v
128 128
 }
129 129
 
130
+func (daemon *Daemon) fillClusterInfo(v *types.Info) {
131
+	v.ClusterAdvertise = daemon.configStore.ClusterAdvertise
132
+	v.ClusterStore = daemon.configStore.ClusterStore
133
+
134
+	if v.ClusterAdvertise != "" || v.ClusterStore != "" {
135
+		v.Warnings = append(v.Warnings, `WARNING: node discovery and overlay networks with an external k/v store (cluster-advertise,
136
+         cluster-store, cluster-store-opt) are deprecated and will be removed in a future release.`)
137
+	}
138
+}
139
+
130 140
 func (daemon *Daemon) fillDriverInfo(v *types.Info) {
131 141
 	var ds [][2]string
132 142
 	drivers := ""