Un-indent the comment, so that it doesn't get printed by
the shell script (moved it above the target, as it looked
slightly less cluttered)
Also fixed the "help" comment, so that it shows up in
`make help`, and removed the un-needed dummy `buildx:` target.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
... | ... |
@@ -247,14 +247,13 @@ swagger-docs: ## preview the API documentation |
247 | 247 |
|
248 | 248 |
.PHONY: buildx |
249 | 249 |
ifeq ($(BUILDX), bundles/buildx) |
250 |
-buildx: bundles/buildx # build buildx cli tool |
|
251 |
-else |
|
252 |
-buildx: |
|
250 |
+buildx: bundles/buildx ## build buildx cli tool |
|
253 | 251 |
endif |
254 | 252 |
|
253 |
+# This intentionally is not using the `--output` flag from the docker CLI, which |
|
254 |
+# is a buildkit option. The idea here being that if buildx is being used, it's |
|
255 |
+# because buildkit is not supported natively |
|
255 | 256 |
bundles/buildx: bundles ## build buildx CLI tool |
256 |
- # This intetionally is not using the `--output` flag from the docker CLI which is a buildkit option |
|
257 |
- # The idea here being that if buildx is being used, it's because buildkit is not supported natively |
|
258 | 257 |
docker build -f $${BUILDX_DOCKERFILE:-Dockerfile.buildx} -t "moby-buildx:$${BUILDX_COMMIT:-latest}" \ |
259 | 258 |
--build-arg BUILDX_COMMIT \ |
260 | 259 |
--build-arg BUILDX_REPO \ |