Browse code

fixed some `go vet` issues.

Andrews Medina authored on 2013/11/30 09:53:20
Showing 6 changed files
... ...
@@ -247,7 +247,7 @@ func TestChangesDirsMutated(t *testing.T) {
247 247
 		}
248 248
 		if changes[i].Path == expectedChanges[i].Path {
249 249
 			if changes[i] != expectedChanges[i] {
250
-				t.Fatalf("Wrong change for %s, expected %s, got %d\n", changes[i].Path, changes[i].String(), expectedChanges[i].String())
250
+				t.Fatalf("Wrong change for %s, expected %s, got %s\n", changes[i].Path, changes[i].String(), expectedChanges[i].String())
251 251
 			}
252 252
 		} else if changes[i].Path < expectedChanges[i].Path {
253 253
 			t.Fatalf("unexpected change %s\n", changes[i].String())
... ...
@@ -261,45 +261,45 @@ func TestApplyLayer(t *testing.T) {
261 261
 	t.Skip("Skipping TestApplyLayer due to known failures") // Disable this for now as it is broken
262 262
 	return
263 263
 
264
-	src, err := ioutil.TempDir("", "docker-changes-test")
265
-	if err != nil {
266
-		t.Fatal(err)
267
-	}
268
-	createSampleDir(t, src)
269
-	dst := src + "-copy"
270
-	if err := copyDir(src, dst); err != nil {
271
-		t.Fatal(err)
272
-	}
273
-	mutateSampleDir(t, dst)
274
-
275
-	changes, err := ChangesDirs(dst, src)
276
-	if err != nil {
277
-		t.Fatal(err)
278
-	}
279
-
280
-	layer, err := ExportChanges(dst, changes)
281
-	if err != nil {
282
-		t.Fatal(err)
283
-	}
284
-
285
-	layerCopy, err := NewTempArchive(layer, "")
286
-	if err != nil {
287
-		t.Fatal(err)
288
-	}
289
-
290
-	if err := ApplyLayer(src, layerCopy); err != nil {
291
-		t.Fatal(err)
292
-	}
293
-
294
-	changes2, err := ChangesDirs(src, dst)
295
-	if err != nil {
296
-		t.Fatal(err)
297
-	}
298
-
299
-	if len(changes2) != 0 {
300
-		t.Fatalf("Unexpected differences after re applying mutation: %v", changes)
301
-	}
302
-
303
-	os.RemoveAll(src)
304
-	os.RemoveAll(dst)
264
+	// src, err := ioutil.TempDir("", "docker-changes-test")
265
+	// if err != nil {
266
+	// 	t.Fatal(err)
267
+	// }
268
+	// createSampleDir(t, src)
269
+	// dst := src + "-copy"
270
+	// if err := copyDir(src, dst); err != nil {
271
+	// 	t.Fatal(err)
272
+	// }
273
+	// mutateSampleDir(t, dst)
274
+
275
+	// changes, err := ChangesDirs(dst, src)
276
+	// if err != nil {
277
+	// 	t.Fatal(err)
278
+	// }
279
+
280
+	// layer, err := ExportChanges(dst, changes)
281
+	// if err != nil {
282
+	// 	t.Fatal(err)
283
+	// }
284
+
285
+	// layerCopy, err := NewTempArchive(layer, "")
286
+	// if err != nil {
287
+	// 	t.Fatal(err)
288
+	// }
289
+
290
+	// if err := ApplyLayer(src, layerCopy); err != nil {
291
+	// 	t.Fatal(err)
292
+	// }
293
+
294
+	// changes2, err := ChangesDirs(src, dst)
295
+	// if err != nil {
296
+	// 	t.Fatal(err)
297
+	// }
298
+
299
+	// if len(changes2) != 0 {
300
+	// 	t.Fatalf("Unexpected differences after re applying mutation: %v", changes)
301
+	// }
302
+
303
+	// os.RemoveAll(src)
304
+	// os.RemoveAll(dst)
305 305
 }
... ...
@@ -37,16 +37,16 @@ func TestSetenvBool(t *testing.T) {
37 37
 	job := mkJob(t, "dummy")
38 38
 	job.SetenvBool("foo", true)
39 39
 	if val := job.GetenvBool("foo"); !val {
40
-		t.Fatalf("GetenvBool returns incorrect value: %b", val)
40
+		t.Fatalf("GetenvBool returns incorrect value: %t", val)
41 41
 	}
42 42
 
43 43
 	job.SetenvBool("bar", false)
44 44
 	if val := job.GetenvBool("bar"); val {
45
-		t.Fatalf("GetenvBool returns incorrect value: %b", val)
45
+		t.Fatalf("GetenvBool returns incorrect value: %t", val)
46 46
 	}
47 47
 
48 48
 	if val := job.GetenvBool("nonexistent"); val {
49
-		t.Fatalf("GetenvBool returns incorrect value: %b", val)
49
+		t.Fatalf("GetenvBool returns incorrect value: %t", val)
50 50
 	}
51 51
 }
52 52
 
... ...
@@ -172,7 +172,7 @@ func (devices *DeviceSet) saveMetadata() error {
172 172
 		return fmt.Errorf("Error closing metadata file %s: %s", tmpFile.Name(), err)
173 173
 	}
174 174
 	if err := osRename(tmpFile.Name(), devices.jsonFile()); err != nil {
175
-		return fmt.Errorf("Error committing metadata file", err)
175
+		return fmt.Errorf("Error committing metadata file %s: %s", tmpFile.Name(), err)
176 176
 	}
177 177
 
178 178
 	if devices.NewTransactionId != devices.TransactionId {
... ...
@@ -439,11 +439,11 @@ func (devices *DeviceSet) initDevmapper(doInit bool) error {
439 439
 	hasMetadata := devices.hasImage("metadata")
440 440
 
441 441
 	if !doInit && !hasData {
442
-		return fmt.Errorf("Looback data file not found %s")
442
+		return fmt.Error("Looback data file not found")
443 443
 	}
444 444
 
445 445
 	if !doInit && !hasMetadata {
446
-		return fmt.Errorf("Looback metadata file not found %s")
446
+		return fmt.Error("Looback metadata file not found")
447 447
 	}
448 448
 
449 449
 	createdLoopback := !hasData || !hasMetadata
... ...
@@ -127,7 +127,7 @@ func setupBaseImage() {
127 127
 	job.SetenvBool("Autorestart", false)
128 128
 	job.Setenv("BridgeIface", unitTestNetworkBridge)
129 129
 	if err := job.Run(); err != nil {
130
-		log.Fatalf("Unable to create a runtime for tests:", err)
130
+		log.Fatalf("Unable to create a runtime for tests: %s", err)
131 131
 	}
132 132
 	srv := mkServerFromEngine(eng, log.New(os.Stderr, "", 0))
133 133
 
... ...
@@ -173,7 +173,7 @@ func spawnGlobalDaemon() {
173 173
 func GetTestImage(runtime *docker.Runtime) *docker.Image {
174 174
 	imgs, err := runtime.Graph().Map()
175 175
 	if err != nil {
176
-		log.Fatalf("Unable to get the test image:", err)
176
+		log.Fatalf("Unable to get the test image: %s", err)
177 177
 	}
178 178
 	for _, image := range imgs {
179 179
 		if image.ID == unitTestImageID {
... ...
@@ -580,7 +580,7 @@ type Nat struct {
580 580
 }
581 581
 
582 582
 func (n *Nat) String() string {
583
-	return fmt.Sprintf("%s:%d:%d/%s", n.Binding.HostIp, n.Binding.HostPort, n.Port.Port(), n.Port.Proto())
583
+	return fmt.Sprintf("%s:%s:%s/%s", n.Binding.HostIp, n.Binding.HostPort, n.Port.Port(), n.Port.Proto())
584 584
 }
585 585
 
586 586
 // Release: Network cleanup - release all resources
... ...
@@ -386,8 +386,8 @@ func (srv *Server) recursiveLoad(address, tmpImageDir string) error {
386 386
 
387 387
 		imageJson, err := ioutil.ReadFile(path.Join(tmpImageDir, "repo", address, "json"))
388 388
 		if err != nil {
389
-			return err
390 389
 			utils.Debugf("Error reading json", err)
390
+			return err
391 391
 		}
392 392
 
393 393
 		layer, err := os.Open(path.Join(tmpImageDir, "repo", address, "layer.tar"))