Browse code

Remove "-e" / "--email" from integration tests

This option is no longer supported in docker 17.06,
so should not be used.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Sebastiaan van Stijn authored on 2017/06/12 20:25:26
Showing 3 changed files
... ...
@@ -28,17 +28,3 @@ func (s *DockerRegistryAuthHtpasswdSuite) TestLoginToPrivateRegistry(c *check.C)
28 28
 	// now it's fine
29 29
 	dockerCmd(c, "login", "-u", s.reg.Username(), "-p", s.reg.Password(), privateRegistryURL)
30 30
 }
31
-
32
-func (s *DockerRegistryAuthHtpasswdSuite) TestLoginToPrivateRegistryDeprecatedEmailFlag(c *check.C) {
33
-	// Test to make sure login still works with the deprecated -e and --email flags
34
-	// wrong credentials
35
-	out, _, err := dockerCmdWithError("login", "-u", s.reg.Username(), "-p", "WRONGPASSWORD", "-e", s.reg.Email(), privateRegistryURL)
36
-	c.Assert(err, checker.NotNil, check.Commentf(out))
37
-	c.Assert(out, checker.Contains, "401 Unauthorized")
38
-
39
-	// now it's fine
40
-	// -e flag
41
-	dockerCmd(c, "login", "-u", s.reg.Username(), "-p", s.reg.Password(), "-e", s.reg.Email(), privateRegistryURL)
42
-	// --email flag
43
-	dockerCmd(c, "login", "-u", s.reg.Username(), "-p", s.reg.Password(), "--email", s.reg.Email(), privateRegistryURL)
44
-}
... ...
@@ -107,7 +107,7 @@ func (s *DockerRegistrySuite) TestUserAgentPassThrough(c *check.C) {
107 107
 	s.d.Cmd("build", "--file", dockerfileName, ".")
108 108
 	regexpCheckUA(c, buildUA)
109 109
 
110
-	s.d.Cmd("login", "-u", "richard", "-p", "testtest", "-e", "testuser@testdomain.com", loginReg.URL())
110
+	s.d.Cmd("login", "-u", "richard", "-p", "testtest", loginReg.URL())
111 111
 	regexpCheckUA(c, loginUA)
112 112
 
113 113
 	s.d.Cmd("pull", pullRepoName)
... ...
@@ -60,7 +60,7 @@ func (s *DockerRegistrySuite) TestV2Only(c *check.C) {
60 60
 	s.d.Cmd("build", "--file", dockerfileName, ".")
61 61
 
62 62
 	s.d.Cmd("run", repoName)
63
-	s.d.Cmd("login", "-u", "richard", "-p", "testtest", "-e", "testuser@testdomain.com", reg.URL())
63
+	s.d.Cmd("login", "-u", "richard", "-p", "testtest", reg.URL())
64 64
 	s.d.Cmd("tag", "busybox", repoName)
65 65
 	s.d.Cmd("push", repoName)
66 66
 	s.d.Cmd("pull", repoName)