Browse code

Merge pull request #12453 from runcom/style-minor-fixes

Add minor stylistic fixes

Alexander Morozov authored on 2015/04/21 03:51:04
Showing 5 changed files
... ...
@@ -609,11 +609,10 @@ func (b *Builder) run(c *daemon.Container) error {
609 609
 
610 610
 	// Wait for it to finish
611 611
 	if ret, _ := c.WaitStop(-1 * time.Second); ret != 0 {
612
-		err := &jsonmessage.JSONError{
612
+		return &jsonmessage.JSONError{
613 613
 			Message: fmt.Sprintf("The command %v returned a non-zero code: %d", b.Config.Cmd, ret),
614 614
 			Code:    ret,
615 615
 		}
616
-		return err
617 616
 	}
618 617
 
619 618
 	return nil
... ...
@@ -308,7 +308,7 @@ func setupIPTables(addr net.Addr, icc, ipmasq bool) error {
308 308
 				"-t", string(iptables.Nat), "-I", "POSTROUTING"}, natArgs...)...); err != nil {
309 309
 				return fmt.Errorf("Unable to enable network bridge NAT: %s", err)
310 310
 			} else if len(output) != 0 {
311
-				return &iptables.ChainError{Chain: "POSTROUTING", Output: output}
311
+				return iptables.ChainError{Chain: "POSTROUTING", Output: output}
312 312
 			}
313 313
 		}
314 314
 	}
... ...
@@ -349,7 +349,7 @@ func setupIPTables(addr net.Addr, icc, ipmasq bool) error {
349 349
 		if output, err := iptables.Raw(append([]string{"-I", "FORWARD"}, outgoingArgs...)...); err != nil {
350 350
 			return fmt.Errorf("Unable to allow outgoing packets: %s", err)
351 351
 		} else if len(output) != 0 {
352
-			return &iptables.ChainError{Chain: "FORWARD outgoing", Output: output}
352
+			return iptables.ChainError{Chain: "FORWARD outgoing", Output: output}
353 353
 		}
354 354
 	}
355 355
 
... ...
@@ -360,7 +360,7 @@ func setupIPTables(addr net.Addr, icc, ipmasq bool) error {
360 360
 		if output, err := iptables.Raw(append([]string{"-I", "FORWARD"}, existingArgs...)...); err != nil {
361 361
 			return fmt.Errorf("Unable to allow incoming packets: %s", err)
362 362
 		} else if len(output) != 0 {
363
-			return &iptables.ChainError{Chain: "FORWARD incoming", Output: output}
363
+			return iptables.ChainError{Chain: "FORWARD incoming", Output: output}
364 364
 		}
365 365
 	}
366 366
 	return nil
... ...
@@ -41,7 +41,7 @@ type ChainError struct {
41 41
 	Output []byte
42 42
 }
43 43
 
44
-func (e *ChainError) Error() string {
44
+func (e ChainError) Error() string {
45 45
 	return fmt.Sprintf("Error iptables %s: %s", e.Chain, string(e.Output))
46 46
 }
47 47
 
... ...
@@ -142,7 +142,7 @@ func (c *Chain) Forward(action Action, ip net.IP, port int, proto, destAddr stri
142 142
 		"--to-destination", net.JoinHostPort(destAddr, strconv.Itoa(destPort))); err != nil {
143 143
 		return err
144 144
 	} else if len(output) != 0 {
145
-		return &ChainError{Chain: "FORWARD", Output: output}
145
+		return ChainError{Chain: "FORWARD", Output: output}
146 146
 	}
147 147
 
148 148
 	if output, err := Raw("-t", string(Filter), string(action), c.Name,
... ...
@@ -154,7 +154,7 @@ func (c *Chain) Forward(action Action, ip net.IP, port int, proto, destAddr stri
154 154
 		"-j", "ACCEPT"); err != nil {
155 155
 		return err
156 156
 	} else if len(output) != 0 {
157
-		return &ChainError{Chain: "FORWARD", Output: output}
157
+		return ChainError{Chain: "FORWARD", Output: output}
158 158
 	}
159 159
 
160 160
 	if output, err := Raw("-t", string(Nat), string(action), "POSTROUTING",
... ...
@@ -165,7 +165,7 @@ func (c *Chain) Forward(action Action, ip net.IP, port int, proto, destAddr stri
165 165
 		"-j", "MASQUERADE"); err != nil {
166 166
 		return err
167 167
 	} else if len(output) != 0 {
168
-		return &ChainError{Chain: "FORWARD", Output: output}
168
+		return ChainError{Chain: "FORWARD", Output: output}
169 169
 	}
170 170
 
171 171
 	return nil
... ...
@@ -208,7 +208,7 @@ func (c *Chain) Prerouting(action Action, args ...string) error {
208 208
 	if output, err := Raw(append(a, "-j", c.Name)...); err != nil {
209 209
 		return err
210 210
 	} else if len(output) != 0 {
211
-		return &ChainError{Chain: "PREROUTING", Output: output}
211
+		return ChainError{Chain: "PREROUTING", Output: output}
212 212
 	}
213 213
 	return nil
214 214
 }
... ...
@@ -222,7 +222,7 @@ func (c *Chain) Output(action Action, args ...string) error {
222 222
 	if output, err := Raw(append(a, "-j", c.Name)...); err != nil {
223 223
 		return err
224 224
 	} else if len(output) != 0 {
225
-		return &ChainError{Chain: "OUTPUT", Output: output}
225
+		return ChainError{Chain: "OUTPUT", Output: output}
226 226
 	}
227 227
 	return nil
228 228
 }
... ...
@@ -3,8 +3,9 @@ package streamformatter
3 3
 import (
4 4
 	"encoding/json"
5 5
 	"fmt"
6
-	"github.com/docker/docker/pkg/jsonmessage"
7 6
 	"io"
7
+
8
+	"github.com/docker/docker/pkg/jsonmessage"
8 9
 )
9 10
 
10 11
 type StreamFormatter struct {
... ...
@@ -3,9 +3,10 @@ package streamformatter
3 3
 import (
4 4
 	"encoding/json"
5 5
 	"errors"
6
-	"github.com/docker/docker/pkg/jsonmessage"
7 6
 	"reflect"
8 7
 	"testing"
8
+
9
+	"github.com/docker/docker/pkg/jsonmessage"
9 10
 )
10 11
 
11 12
 func TestFormatStream(t *testing.T) {