integration-cli: TestContainersAPICreateMountsValidation: use subtests
Before:
--- PASS: TestDockerSuite/TestContainersAPICreateMountsValidation (0.52s)
docker_api_containers_test.go:1927: case 0
docker_api_containers_test.go:1927: case 1
docker_api_containers_test.go:1927: case 2
docker_api_containers_test.go:1927: case 3
docker_api_containers_test.go:1927: case 4
docker_api_containers_test.go:1927: case 5
docker_api_containers_test.go:1927: case 6
docker_api_containers_test.go:1927: case 7
docker_api_containers_test.go:1927: case 8
docker_api_containers_test.go:1927: case 9
docker_api_containers_test.go:1927: case 10
docker_api_containers_test.go:1927: case 11
docker_api_containers_test.go:1927: case 12
docker_api_containers_test.go:1927: case 13
docker_api_containers_test.go:1927: case 14
docker_api_containers_test.go:1927: case 15
After:
--- PASS: TestDockerSuite/TestContainersAPICreateMountsValidation (1.13s)
--- PASS: TestDockerSuite/TestContainersAPICreateMountsValidation/case_0 (0.01s)
--- PASS: TestDockerSuite/TestContainersAPICreateMountsValidation/case_1 (0.00s)
--- PASS: TestDockerSuite/TestContainersAPICreateMountsValidation/case_2 (0.00s)
--- PASS: TestDockerSuite/TestContainersAPICreateMountsValidation/case_3 (0.00s)
--- PASS: TestDockerSuite/TestContainersAPICreateMountsValidation/case_4 (0.00s)
--- PASS: TestDockerSuite/TestContainersAPICreateMountsValidation/case_5 (0.11s)
--- PASS: TestDockerSuite/TestContainersAPICreateMountsValidation/case_6 (0.12s)
--- PASS: TestDockerSuite/TestContainersAPICreateMountsValidation/case_7 (0.13s)
--- PASS: TestDockerSuite/TestContainersAPICreateMountsValidation/case_8 (0.00s)
--- PASS: TestDockerSuite/TestContainersAPICreateMountsValidation/case_9 (0.06s)
--- PASS: TestDockerSuite/TestContainersAPICreateMountsValidation/case_10 (0.08s)
--- PASS: TestDockerSuite/TestContainersAPICreateMountsValidation/case_11 (0.10s)
--- PASS: TestDockerSuite/TestContainersAPICreateMountsValidation/case_12 (0.18s)
--- PASS: TestDockerSuite/TestContainersAPICreateMountsValidation/case_13 (0.12s)
--- PASS: TestDockerSuite/TestContainersAPICreateMountsValidation/case_14 (0.14s)
--- PASS: TestDockerSuite/TestContainersAPICreateMountsValidation/case_15 (0.00s)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sebastiaan van Stijn authored on 2019/10/21 23:02:39Showing 1 changed files
| ... | ... |
@@ -1918,19 +1918,21 @@ func (s *DockerSuite) TestContainersAPICreateMountsValidation(c *testing.T) {
|
| 1918 | 1918 |
}...) |
| 1919 | 1919 |
|
| 1920 | 1920 |
} |
| 1921 |
- cli, err := client.NewClientWithOpts(client.FromEnv) |
|
| 1921 |
+ apiClient, err := client.NewClientWithOpts(client.FromEnv) |
|
| 1922 | 1922 |
assert.NilError(c, err) |
| 1923 |
- defer cli.Close() |
|
| 1923 |
+ defer apiClient.Close() |
|
| 1924 | 1924 |
|
| 1925 | 1925 |
// TODO add checks for statuscode returned by API |
| 1926 | 1926 |
for i, x := range cases {
|
| 1927 |
- c.Logf("case %d", i)
|
|
| 1928 |
- _, err = cli.ContainerCreate(context.Background(), &x.config, &x.hostConfig, &networktypes.NetworkingConfig{}, "")
|
|
| 1929 |
- if len(x.msg) > 0 {
|
|
| 1930 |
- assert.ErrorContains(c, err, x.msg, "%v", cases[i].config) |
|
| 1931 |
- } else {
|
|
| 1932 |
- assert.NilError(c, err) |
|
| 1933 |
- } |
|
| 1927 |
+ x := x |
|
| 1928 |
+ c.Run(fmt.Sprintf("case %d", i), func(c *testing.T) {
|
|
| 1929 |
+ _, err = apiClient.ContainerCreate(context.Background(), &x.config, &x.hostConfig, &networktypes.NetworkingConfig{}, "")
|
|
| 1930 |
+ if len(x.msg) > 0 {
|
|
| 1931 |
+ assert.ErrorContains(c, err, x.msg, "%v", cases[i].config) |
|
| 1932 |
+ } else {
|
|
| 1933 |
+ assert.NilError(c, err) |
|
| 1934 |
+ } |
|
| 1935 |
+ }) |
|
| 1934 | 1936 |
} |
| 1935 | 1937 |
} |
| 1936 | 1938 |
|