1. After running d.Cmd(), in case an error is returned, it makes sense
to print command output, as its stderr may contain a clue about what
went wrong. This is by no means complete, just as far as I could go.
2. In case the comment in c.Assert is a constant string, it's better
to provide it as a comment which will be printed.
3. An arbitrary string should not be passed on to a function expecting
%-style formatting. Use %s to fix this.
4. Print the output string before transformation, not after.
5. Unify the output format (drop "out:" prefix").
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
| ... | ... |
@@ -404,7 +404,7 @@ func (s *DockerSwarmSuite) TestAPISwarmLeaveRemovesContainer(c *check.C) {
|
| 404 | 404 |
d.CreateService(c, simpleTestService, setInstances(instances)) |
| 405 | 405 |
|
| 406 | 406 |
id, err := d.Cmd("run", "-d", "busybox", "top")
|
| 407 |
- c.Assert(err, checker.IsNil) |
|
| 407 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", id))
|
|
| 408 | 408 |
id = strings.TrimSpace(id) |
| 409 | 409 |
|
| 410 | 410 |
waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, instances+1) |
| ... | ... |
@@ -415,7 +415,7 @@ func (s *DockerSwarmSuite) TestAPISwarmLeaveRemovesContainer(c *check.C) {
|
| 415 | 415 |
waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, 1) |
| 416 | 416 |
|
| 417 | 417 |
id2, err := d.Cmd("ps", "-q")
|
| 418 |
- c.Assert(err, checker.IsNil) |
|
| 418 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", id2))
|
|
| 419 | 419 |
c.Assert(id, checker.HasPrefix, strings.TrimSpace(id2)) |
| 420 | 420 |
} |
| 421 | 421 |
|
| ... | ... |
@@ -426,7 +426,7 @@ func (s *DockerSwarmSuite) TestAPISwarmLeaveOnPendingJoin(c *check.C) {
|
| 426 | 426 |
d2 := s.AddDaemon(c, false, false) |
| 427 | 427 |
|
| 428 | 428 |
id, err := d2.Cmd("run", "-d", "busybox", "top")
|
| 429 |
- c.Assert(err, checker.IsNil) |
|
| 429 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", id))
|
|
| 430 | 430 |
id = strings.TrimSpace(id) |
| 431 | 431 |
|
| 432 | 432 |
c2 := d2.NewClientT(c) |
| ... | ... |
@@ -445,7 +445,7 @@ func (s *DockerSwarmSuite) TestAPISwarmLeaveOnPendingJoin(c *check.C) {
|
| 445 | 445 |
waitAndAssert(c, defaultReconciliationTimeout, d2.CheckActiveContainerCount, checker.Equals, 1) |
| 446 | 446 |
|
| 447 | 447 |
id2, err := d2.Cmd("ps", "-q")
|
| 448 |
- c.Assert(err, checker.IsNil) |
|
| 448 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", id2))
|
|
| 449 | 449 |
c.Assert(id, checker.HasPrefix, strings.TrimSpace(id2)) |
| 450 | 450 |
} |
| 451 | 451 |
|
| ... | ... |
@@ -15,17 +15,17 @@ func (s *DockerSwarmSuite) TestConfigCreateWithFile(c *check.C) {
|
| 15 | 15 |
d := s.AddDaemon(c, true, true) |
| 16 | 16 |
|
| 17 | 17 |
testFile, err := ioutil.TempFile("", "configCreateTest")
|
| 18 |
- c.Assert(err, checker.IsNil, check.Commentf("failed to create temporary file"))
|
|
| 18 |
+ c.Assert(err, checker.IsNil) // ensure temp file is created |
|
| 19 | 19 |
defer os.Remove(testFile.Name()) |
| 20 | 20 |
|
| 21 | 21 |
testData := "TESTINGDATA" |
| 22 | 22 |
_, err = testFile.Write([]byte(testData)) |
| 23 |
- c.Assert(err, checker.IsNil, check.Commentf("failed to write to temporary file"))
|
|
| 23 |
+ c.Assert(err, checker.IsNil) // ensure temp file is written |
|
| 24 | 24 |
|
| 25 | 25 |
testName := "test_config" |
| 26 | 26 |
out, err := d.Cmd("config", "create", testName, testFile.Name())
|
| 27 |
- c.Assert(err, checker.IsNil) |
|
| 28 |
- c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "", check.Commentf("%s", out))
|
|
| 27 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 28 |
+ c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") |
|
| 29 | 29 |
|
| 30 | 30 |
id := strings.TrimSpace(out) |
| 31 | 31 |
config := d.GetConfig(c, id) |
| ... | ... |
@@ -287,16 +287,16 @@ func (s *DockerDaemonSuite) TestPluginListFilterEnabled(c *check.C) {
|
| 287 | 287 |
}() |
| 288 | 288 |
|
| 289 | 289 |
out, err = s.d.Cmd("plugin", "ls", "--filter", "enabled=true")
|
| 290 |
- c.Assert(err, checker.IsNil) |
|
| 290 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 291 | 291 |
c.Assert(out, checker.Not(checker.Contains), pName) |
| 292 | 292 |
|
| 293 | 293 |
out, err = s.d.Cmd("plugin", "ls", "--filter", "enabled=false")
|
| 294 |
- c.Assert(err, checker.IsNil) |
|
| 294 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 295 | 295 |
c.Assert(out, checker.Contains, pName) |
| 296 | 296 |
c.Assert(out, checker.Contains, "false") |
| 297 | 297 |
|
| 298 | 298 |
out, err = s.d.Cmd("plugin", "ls")
|
| 299 |
- c.Assert(err, checker.IsNil) |
|
| 299 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 300 | 300 |
c.Assert(out, checker.Contains, pName) |
| 301 | 301 |
} |
| 302 | 302 |
|
| ... | ... |
@@ -315,14 +315,14 @@ func (s *DockerDaemonSuite) TestPluginListFilterCapability(c *check.C) {
|
| 315 | 315 |
}() |
| 316 | 316 |
|
| 317 | 317 |
out, err = s.d.Cmd("plugin", "ls", "--filter", "capability=volumedriver")
|
| 318 |
- c.Assert(err, checker.IsNil) |
|
| 318 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 319 | 319 |
c.Assert(out, checker.Contains, pName) |
| 320 | 320 |
|
| 321 | 321 |
out, err = s.d.Cmd("plugin", "ls", "--filter", "capability=authz")
|
| 322 |
- c.Assert(err, checker.IsNil) |
|
| 322 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 323 | 323 |
c.Assert(out, checker.Not(checker.Contains), pName) |
| 324 | 324 |
|
| 325 | 325 |
out, err = s.d.Cmd("plugin", "ls")
|
| 326 |
- c.Assert(err, checker.IsNil) |
|
| 326 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 327 | 327 |
c.Assert(out, checker.Contains, pName) |
| 328 | 328 |
} |
| ... | ... |
@@ -107,7 +107,7 @@ func (s *DockerDaemonSuite) TestDaemonRestartWithVolumesRefs(c *check.C) {
|
| 107 | 107 |
} |
| 108 | 108 |
|
| 109 | 109 |
out, err := s.d.Cmd("inspect", "-f", "{{json .Mounts}}", "volrestarttest1")
|
| 110 |
- c.Assert(err, check.IsNil) |
|
| 110 |
+ c.Assert(err, check.IsNil, check.Commentf("%s", out))
|
|
| 111 | 111 |
|
| 112 | 112 |
if _, err := inspectMountPointJSON(out, "/foo"); err != nil {
|
| 113 | 113 |
c.Fatalf("Expected volume to exist: /foo, error: %v\n", err)
|
| ... | ... |
@@ -387,22 +387,20 @@ func (s *DockerDaemonSuite) TestDaemonIPv6Enabled(c *check.C) {
|
| 387 | 387 |
} |
| 388 | 388 |
|
| 389 | 389 |
out, err := s.d.Cmd("inspect", "--format", "'{{.NetworkSettings.Networks.bridge.LinkLocalIPv6Address}}'", "ipv6test")
|
| 390 |
- out = strings.Trim(out, " \r\n'") |
|
| 391 |
- |
|
| 392 | 390 |
if err != nil {
|
| 393 | 391 |
c.Fatalf("Error inspecting container: %s, %v", out, err)
|
| 394 | 392 |
} |
| 393 |
+ out = strings.Trim(out, " \r\n'") |
|
| 395 | 394 |
|
| 396 | 395 |
if ip := net.ParseIP(out); ip == nil {
|
| 397 | 396 |
c.Fatalf("Container should have a link-local IPv6 address")
|
| 398 | 397 |
} |
| 399 | 398 |
|
| 400 | 399 |
out, err = s.d.Cmd("inspect", "--format", "'{{.NetworkSettings.Networks.bridge.GlobalIPv6Address}}'", "ipv6test")
|
| 401 |
- out = strings.Trim(out, " \r\n'") |
|
| 402 |
- |
|
| 403 | 400 |
if err != nil {
|
| 404 | 401 |
c.Fatalf("Error inspecting container: %s, %v", out, err)
|
| 405 | 402 |
} |
| 403 |
+ out = strings.Trim(out, " \r\n'") |
|
| 406 | 404 |
|
| 407 | 405 |
if ip := net.ParseIP(out); ip != nil {
|
| 408 | 406 |
c.Fatalf("Container should not have a global IPv6 address: %v", out)
|
| ... | ... |
@@ -424,9 +422,8 @@ func (s *DockerDaemonSuite) TestDaemonIPv6FixedCIDR(c *check.C) {
|
| 424 | 424 |
c.Assert(err, checker.IsNil, check.Commentf("Could not run container: %s, %v", out, err))
|
| 425 | 425 |
|
| 426 | 426 |
out, err = s.d.Cmd("inspect", "--format", "{{.NetworkSettings.Networks.bridge.GlobalIPv6Address}}", "ipv6test")
|
| 427 |
- out = strings.Trim(out, " \r\n'") |
|
| 428 |
- |
|
| 429 | 427 |
c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
| 428 |
+ out = strings.Trim(out, " \r\n'") |
|
| 430 | 429 |
|
| 431 | 430 |
ip := net.ParseIP(out) |
| 432 | 431 |
c.Assert(ip, checker.NotNil, check.Commentf("Container should have a global IPv6 address"))
|
| ... | ... |
@@ -448,11 +445,11 @@ func (s *DockerDaemonSuite) TestDaemonIPv6FixedCIDRAndMac(c *check.C) {
|
| 448 | 448 |
|
| 449 | 449 |
s.d.StartWithBusybox(c, "--ipv6", "--fixed-cidr-v6=2001:db8:1::/64") |
| 450 | 450 |
|
| 451 |
- _, err := s.d.Cmd("run", "-itd", "--name=ipv6test", "--mac-address", "AA:BB:CC:DD:EE:FF", "busybox")
|
|
| 452 |
- c.Assert(err, checker.IsNil) |
|
| 451 |
+ out, err := s.d.Cmd("run", "-itd", "--name=ipv6test", "--mac-address", "AA:BB:CC:DD:EE:FF", "busybox")
|
|
| 452 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 453 | 453 |
|
| 454 |
- out, err := s.d.Cmd("inspect", "--format", "{{.NetworkSettings.Networks.bridge.GlobalIPv6Address}}", "ipv6test")
|
|
| 455 |
- c.Assert(err, checker.IsNil) |
|
| 454 |
+ out, err = s.d.Cmd("inspect", "--format", "{{.NetworkSettings.Networks.bridge.GlobalIPv6Address}}", "ipv6test")
|
|
| 455 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 456 | 456 |
c.Assert(strings.Trim(out, " \r\n'"), checker.Equals, "2001:db8:1::aabb:ccdd:eeff") |
| 457 | 457 |
} |
| 458 | 458 |
|
| ... | ... |
@@ -467,7 +464,7 @@ func (s *DockerDaemonSuite) TestDaemonIPv6HostMode(c *check.C) {
|
| 467 | 467 |
c.Assert(err, checker.IsNil, check.Commentf("Could not run container: %s, %v", out, err))
|
| 468 | 468 |
|
| 469 | 469 |
out, err = s.d.Cmd("exec", "hostcnt", "ip", "-6", "addr", "show", "docker0")
|
| 470 |
- c.Assert(err, checker.IsNil) |
|
| 470 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 471 | 471 |
c.Assert(strings.Trim(out, " \r\n'"), checker.Contains, "2001:db8:2::1") |
| 472 | 472 |
} |
| 473 | 473 |
|
| ... | ... |
@@ -600,8 +597,8 @@ func (s *DockerDaemonSuite) TestDaemonBridgeExternal(c *check.C) {
|
| 600 | 600 |
Out: ipTablesSearchString, |
| 601 | 601 |
}) |
| 602 | 602 |
|
| 603 |
- _, err = d.Cmd("run", "-d", "--name", "ExtContainer", "busybox", "top")
|
|
| 604 |
- c.Assert(err, check.IsNil) |
|
| 603 |
+ out, err := d.Cmd("run", "-d", "--name", "ExtContainer", "busybox", "top")
|
|
| 604 |
+ c.Assert(err, check.IsNil, check.Commentf("%s", out))
|
|
| 605 | 605 |
|
| 606 | 606 |
containerIP := d.FindContainerIP(c, "ExtContainer") |
| 607 | 607 |
ip := net.ParseIP(containerIP) |
| ... | ... |
@@ -671,8 +668,8 @@ func (s *DockerDaemonSuite) TestDaemonBridgeIP(c *check.C) {
|
| 671 | 671 |
Out: ipTablesSearchString, |
| 672 | 672 |
}) |
| 673 | 673 |
|
| 674 |
- _, err := d.Cmd("run", "-d", "--name", "test", "busybox", "top")
|
|
| 675 |
- c.Assert(err, check.IsNil) |
|
| 674 |
+ out, err := d.Cmd("run", "-d", "--name", "test", "busybox", "top")
|
|
| 675 |
+ c.Assert(err, check.IsNil, check.Commentf("%s", out))
|
|
| 676 | 676 |
|
| 677 | 677 |
containerIP := d.FindContainerIP(c, "test") |
| 678 | 678 |
ip = net.ParseIP(containerIP) |
| ... | ... |
@@ -782,7 +779,7 @@ func (s *DockerDaemonSuite) TestDaemonDefaultGatewayIPv4Implicit(c *check.C) {
|
| 782 | 782 |
|
| 783 | 783 |
expectedMessage := fmt.Sprintf("default via %s dev", bridgeIP)
|
| 784 | 784 |
out, err := d.Cmd("run", "busybox", "ip", "-4", "route", "list", "0/0")
|
| 785 |
- c.Assert(err, checker.IsNil) |
|
| 785 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 786 | 786 |
c.Assert(strings.Contains(out, expectedMessage), check.Equals, true, |
| 787 | 787 |
check.Commentf("Implicit default gateway should be bridge IP %s, but default route was '%s'",
|
| 788 | 788 |
bridgeIP, strings.TrimSpace(out))) |
| ... | ... |
@@ -804,7 +801,7 @@ func (s *DockerDaemonSuite) TestDaemonDefaultGatewayIPv4Explicit(c *check.C) {
|
| 804 | 804 |
|
| 805 | 805 |
expectedMessage := fmt.Sprintf("default via %s dev", gatewayIP)
|
| 806 | 806 |
out, err := d.Cmd("run", "busybox", "ip", "-4", "route", "list", "0/0")
|
| 807 |
- c.Assert(err, checker.IsNil) |
|
| 807 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 808 | 808 |
c.Assert(strings.Contains(out, expectedMessage), check.Equals, true, |
| 809 | 809 |
check.Commentf("Explicit default gateway should be %s, but default route was '%s'",
|
| 810 | 810 |
gatewayIP, strings.TrimSpace(out))) |
| ... | ... |
@@ -858,7 +855,7 @@ func (s *DockerDaemonSuite) TestDaemonIP(c *check.C) {
|
| 858 | 858 |
defer deleteInterface(c, ifName) |
| 859 | 859 |
|
| 860 | 860 |
_, err = d.Cmd("run", "-d", "-p", "8000:8000", "busybox", "top")
|
| 861 |
- c.Assert(err, check.IsNil) |
|
| 861 |
+ c.Assert(err, check.IsNil, check.Commentf("%s", out))
|
|
| 862 | 862 |
|
| 863 | 863 |
result := icmd.RunCommand("iptables", "-t", "nat", "-nvL")
|
| 864 | 864 |
result.Assert(c, icmd.Success) |
| ... | ... |
@@ -900,8 +897,8 @@ func (s *DockerDaemonSuite) TestDaemonICCPing(c *check.C) {
|
| 900 | 900 |
// But, Pinging external or a Host interface must succeed |
| 901 | 901 |
pingCmd := fmt.Sprintf("ping -c 1 %s -W 1", ip.String())
|
| 902 | 902 |
runArgs := []string{"run", "--rm", "busybox", "sh", "-c", pingCmd}
|
| 903 |
- _, err := d.Cmd(runArgs...) |
|
| 904 |
- c.Assert(err, check.IsNil) |
|
| 903 |
+ out, err := d.Cmd(runArgs...) |
|
| 904 |
+ c.Assert(err, check.IsNil, check.Commentf("%s", out))
|
|
| 905 | 905 |
} |
| 906 | 906 |
|
| 907 | 907 |
func (s *DockerDaemonSuite) TestDaemonICCLinkExpose(c *check.C) {
|
| ... | ... |
@@ -940,10 +937,10 @@ func (s *DockerDaemonSuite) TestDaemonLinksIpTablesRulesWhenLinkAndUnlink(c *che |
| 940 | 940 |
s.d.StartWithBusybox(c, "--bridge", bridgeName, "--icc=false") |
| 941 | 941 |
defer s.d.Restart(c) |
| 942 | 942 |
|
| 943 |
- _, err := s.d.Cmd("run", "-d", "--name", "child", "--publish", "8080:80", "busybox", "top")
|
|
| 944 |
- c.Assert(err, check.IsNil) |
|
| 945 |
- _, err = s.d.Cmd("run", "-d", "--name", "parent", "--link", "child:http", "busybox", "top")
|
|
| 946 |
- c.Assert(err, check.IsNil) |
|
| 943 |
+ out, err := s.d.Cmd("run", "-d", "--name", "child", "--publish", "8080:80", "busybox", "top")
|
|
| 944 |
+ c.Assert(err, check.IsNil, check.Commentf("%s", out))
|
|
| 945 |
+ out, err = s.d.Cmd("run", "-d", "--name", "parent", "--link", "child:http", "busybox", "top")
|
|
| 946 |
+ c.Assert(err, check.IsNil, check.Commentf("%s", out))
|
|
| 947 | 947 |
|
| 948 | 948 |
childIP := s.d.FindContainerIP(c, "child") |
| 949 | 949 |
parentIP := s.d.FindContainerIP(c, "parent") |
| ... | ... |
@@ -970,7 +967,7 @@ func (s *DockerDaemonSuite) TestDaemonUlimitDefaults(c *check.C) {
|
| 970 | 970 |
|
| 971 | 971 |
out, err := s.d.Cmd("run", "--ulimit", "nproc=2048", "--name=test", "busybox", "/bin/sh", "-c", "echo $(ulimit -n); echo $(ulimit -p)")
|
| 972 | 972 |
if err != nil {
|
| 973 |
- c.Fatal(out, err) |
|
| 973 |
+ c.Fatal(err, out) |
|
| 974 | 974 |
} |
| 975 | 975 |
|
| 976 | 976 |
outArr := strings.Split(out, "\n") |
| ... | ... |
@@ -992,7 +989,7 @@ func (s *DockerDaemonSuite) TestDaemonUlimitDefaults(c *check.C) {
|
| 992 | 992 |
|
| 993 | 993 |
out, err = s.d.Cmd("start", "-a", "test")
|
| 994 | 994 |
if err != nil {
|
| 995 |
- c.Fatal(err) |
|
| 995 |
+ c.Fatal(err, out) |
|
| 996 | 996 |
} |
| 997 | 997 |
|
| 998 | 998 |
outArr = strings.Split(out, "\n") |
| ... | ... |
@@ -1566,22 +1563,22 @@ func (s *DockerDaemonSuite) TestDaemonRestartWithContainerWithRestartPolicyAlway |
| 1566 | 1566 |
s.d.StartWithBusybox(c) |
| 1567 | 1567 |
|
| 1568 | 1568 |
out, err := s.d.Cmd("run", "-d", "--restart", "always", "busybox", "top")
|
| 1569 |
- c.Assert(err, check.IsNil) |
|
| 1569 |
+ c.Assert(err, check.IsNil, check.Commentf("%s", out))
|
|
| 1570 | 1570 |
id := strings.TrimSpace(out) |
| 1571 | 1571 |
|
| 1572 |
- _, err = s.d.Cmd("stop", id)
|
|
| 1573 |
- c.Assert(err, check.IsNil) |
|
| 1574 |
- _, err = s.d.Cmd("wait", id)
|
|
| 1575 |
- c.Assert(err, check.IsNil) |
|
| 1572 |
+ out, err = s.d.Cmd("stop", id)
|
|
| 1573 |
+ c.Assert(err, check.IsNil, check.Commentf("%s", out))
|
|
| 1574 |
+ out, err = s.d.Cmd("wait", id)
|
|
| 1575 |
+ c.Assert(err, check.IsNil, check.Commentf("%s", out))
|
|
| 1576 | 1576 |
|
| 1577 | 1577 |
out, err = s.d.Cmd("ps", "-q")
|
| 1578 |
- c.Assert(err, check.IsNil) |
|
| 1578 |
+ c.Assert(err, check.IsNil, check.Commentf("%s", out))
|
|
| 1579 | 1579 |
c.Assert(out, check.Equals, "") |
| 1580 | 1580 |
|
| 1581 | 1581 |
s.d.Restart(c) |
| 1582 | 1582 |
|
| 1583 | 1583 |
out, err = s.d.Cmd("ps", "-q")
|
| 1584 |
- c.Assert(err, check.IsNil) |
|
| 1584 |
+ c.Assert(err, check.IsNil, check.Commentf("%s", out))
|
|
| 1585 | 1585 |
c.Assert(strings.TrimSpace(out), check.Equals, id[:12]) |
| 1586 | 1586 |
} |
| 1587 | 1587 |
|
| ... | ... |
@@ -1650,12 +1647,12 @@ func (s *DockerDaemonSuite) TestDaemonRestartRmVolumeInUse(c *check.C) {
|
| 1650 | 1650 |
func (s *DockerDaemonSuite) TestDaemonRestartLocalVolumes(c *check.C) {
|
| 1651 | 1651 |
s.d.Start(c) |
| 1652 | 1652 |
|
| 1653 |
- _, err := s.d.Cmd("volume", "create", "test")
|
|
| 1654 |
- c.Assert(err, check.IsNil) |
|
| 1653 |
+ out, err := s.d.Cmd("volume", "create", "test")
|
|
| 1654 |
+ c.Assert(err, check.IsNil, check.Commentf("%s", out))
|
|
| 1655 | 1655 |
s.d.Restart(c) |
| 1656 | 1656 |
|
| 1657 |
- _, err = s.d.Cmd("volume", "inspect", "test")
|
|
| 1658 |
- c.Assert(err, check.IsNil) |
|
| 1657 |
+ out, err = s.d.Cmd("volume", "inspect", "test")
|
|
| 1658 |
+ c.Assert(err, check.IsNil, check.Commentf("%s", out))
|
|
| 1659 | 1659 |
} |
| 1660 | 1660 |
|
| 1661 | 1661 |
// FIXME(vdemeester) should be a unit test |
| ... | ... |
@@ -1762,7 +1759,7 @@ func (s *DockerDaemonSuite) TestBridgeIPIsExcludedFromAllocatorPool(c *check.C) |
| 1762 | 1762 |
break |
| 1763 | 1763 |
} |
| 1764 | 1764 |
ip, err := s.d.Cmd("inspect", "--format", "'{{.NetworkSettings.IPAddress}}'", contName)
|
| 1765 |
- c.Assert(err, check.IsNil) |
|
| 1765 |
+ c.Assert(err, check.IsNil, check.Commentf("%s", ip))
|
|
| 1766 | 1766 |
|
| 1767 | 1767 |
c.Assert(ip, check.Not(check.Equals), bridgeIP) |
| 1768 | 1768 |
cont++ |
| ... | ... |
@@ -1792,7 +1789,7 @@ func (s *DockerDaemonSuite) TestDaemonNoSpaceLeftOnDeviceError(c *check.C) {
|
| 1792 | 1792 |
|
| 1793 | 1793 |
// pull a repository large enough to overfill the mounted filesystem |
| 1794 | 1794 |
pullOut, err := s.d.Cmd("pull", "debian:stretch")
|
| 1795 |
- c.Assert(err, checker.NotNil, check.Commentf(pullOut)) |
|
| 1795 |
+ c.Assert(err, checker.NotNil, check.Commentf("%s", pullOut))
|
|
| 1796 | 1796 |
c.Assert(pullOut, checker.Contains, "no space left on device") |
| 1797 | 1797 |
} |
| 1798 | 1798 |
|
| ... | ... |
@@ -41,7 +41,7 @@ func (s *DockerSwarmSuite) TestSwarmUpdate(c *check.C) {
|
| 41 | 41 |
} |
| 42 | 42 |
|
| 43 | 43 |
out, err := d.Cmd("swarm", "update", "--cert-expiry", "30h", "--dispatcher-heartbeat", "11s")
|
| 44 |
- c.Assert(err, checker.IsNil, check.Commentf("out: %v", out))
|
|
| 44 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 45 | 45 |
|
| 46 | 46 |
spec := getSpec() |
| 47 | 47 |
c.Assert(spec.CAConfig.NodeCertExpiry, checker.Equals, 30*time.Hour) |
| ... | ... |
@@ -169,7 +169,7 @@ func (s *DockerSwarmSuite) TestSwarmIncompatibleDaemon(c *check.C) {
|
| 169 | 169 |
func (s *DockerSwarmSuite) TestSwarmServiceTemplatingHostname(c *check.C) {
|
| 170 | 170 |
d := s.AddDaemon(c, true, true) |
| 171 | 171 |
hostname, err := d.Cmd("node", "inspect", "--format", "{{.Description.Hostname}}", "self")
|
| 172 |
- c.Assert(err, checker.IsNil, check.Commentf(hostname)) |
|
| 172 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", hostname))
|
|
| 173 | 173 |
|
| 174 | 174 |
out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", "test", "--hostname", "{{.Service.Name}}-{{.Task.Slot}}-{{.Node.Hostname}}", "busybox", "top")
|
| 175 | 175 |
c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
| ... | ... |
@@ -191,15 +191,15 @@ func (s *DockerSwarmSuite) TestSwarmServiceListFilter(c *check.C) {
|
| 191 | 191 |
name2 := "redis-cluster" |
| 192 | 192 |
name3 := "other-cluster" |
| 193 | 193 |
out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name1, "busybox", "top")
|
| 194 |
- c.Assert(err, checker.IsNil) |
|
| 194 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 195 | 195 |
c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") |
| 196 | 196 |
|
| 197 | 197 |
out, err = d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name2, "busybox", "top")
|
| 198 |
- c.Assert(err, checker.IsNil) |
|
| 198 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 199 | 199 |
c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") |
| 200 | 200 |
|
| 201 | 201 |
out, err = d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name3, "busybox", "top")
|
| 202 |
- c.Assert(err, checker.IsNil) |
|
| 202 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 203 | 203 |
c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") |
| 204 | 204 |
|
| 205 | 205 |
filter1 := "name=redis-cluster-md5" |
| ... | ... |
@@ -207,19 +207,19 @@ func (s *DockerSwarmSuite) TestSwarmServiceListFilter(c *check.C) {
|
| 207 | 207 |
|
| 208 | 208 |
// We search checker.Contains with `name+" "` to prevent prefix only. |
| 209 | 209 |
out, err = d.Cmd("service", "ls", "--filter", filter1)
|
| 210 |
- c.Assert(err, checker.IsNil) |
|
| 210 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 211 | 211 |
c.Assert(out, checker.Contains, name1+" ") |
| 212 | 212 |
c.Assert(out, checker.Not(checker.Contains), name2+" ") |
| 213 | 213 |
c.Assert(out, checker.Not(checker.Contains), name3+" ") |
| 214 | 214 |
|
| 215 | 215 |
out, err = d.Cmd("service", "ls", "--filter", filter2)
|
| 216 |
- c.Assert(err, checker.IsNil) |
|
| 216 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 217 | 217 |
c.Assert(out, checker.Contains, name1+" ") |
| 218 | 218 |
c.Assert(out, checker.Contains, name2+" ") |
| 219 | 219 |
c.Assert(out, checker.Not(checker.Contains), name3+" ") |
| 220 | 220 |
|
| 221 | 221 |
out, err = d.Cmd("service", "ls")
|
| 222 |
- c.Assert(err, checker.IsNil) |
|
| 222 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 223 | 223 |
c.Assert(out, checker.Contains, name1+" ") |
| 224 | 224 |
c.Assert(out, checker.Contains, name2+" ") |
| 225 | 225 |
c.Assert(out, checker.Contains, name3+" ") |
| ... | ... |
@@ -229,18 +229,18 @@ func (s *DockerSwarmSuite) TestSwarmNodeListFilter(c *check.C) {
|
| 229 | 229 |
d := s.AddDaemon(c, true, true) |
| 230 | 230 |
|
| 231 | 231 |
out, err := d.Cmd("node", "inspect", "--format", "{{ .Description.Hostname }}", "self")
|
| 232 |
- c.Assert(err, checker.IsNil) |
|
| 232 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 233 | 233 |
c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") |
| 234 | 234 |
name := strings.TrimSpace(out) |
| 235 | 235 |
|
| 236 | 236 |
filter := "name=" + name[:4] |
| 237 | 237 |
|
| 238 | 238 |
out, err = d.Cmd("node", "ls", "--filter", filter)
|
| 239 |
- c.Assert(err, checker.IsNil) |
|
| 239 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 240 | 240 |
c.Assert(out, checker.Contains, name) |
| 241 | 241 |
|
| 242 | 242 |
out, err = d.Cmd("node", "ls", "--filter", "name=none")
|
| 243 |
- c.Assert(err, checker.IsNil) |
|
| 243 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 244 | 244 |
c.Assert(out, checker.Not(checker.Contains), name) |
| 245 | 245 |
} |
| 246 | 246 |
|
| ... | ... |
@@ -249,7 +249,7 @@ func (s *DockerSwarmSuite) TestSwarmNodeTaskListFilter(c *check.C) {
|
| 249 | 249 |
|
| 250 | 250 |
name := "redis-cluster-md5" |
| 251 | 251 |
out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "--replicas=3", "busybox", "top")
|
| 252 |
- c.Assert(err, checker.IsNil) |
|
| 252 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 253 | 253 |
c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") |
| 254 | 254 |
|
| 255 | 255 |
// make sure task has been deployed. |
| ... | ... |
@@ -258,13 +258,13 @@ func (s *DockerSwarmSuite) TestSwarmNodeTaskListFilter(c *check.C) {
|
| 258 | 258 |
filter := "name=redis-cluster" |
| 259 | 259 |
|
| 260 | 260 |
out, err = d.Cmd("node", "ps", "--filter", filter, "self")
|
| 261 |
- c.Assert(err, checker.IsNil) |
|
| 261 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 262 | 262 |
c.Assert(out, checker.Contains, name+".1") |
| 263 | 263 |
c.Assert(out, checker.Contains, name+".2") |
| 264 | 264 |
c.Assert(out, checker.Contains, name+".3") |
| 265 | 265 |
|
| 266 | 266 |
out, err = d.Cmd("node", "ps", "--filter", "name=none", "self")
|
| 267 |
- c.Assert(err, checker.IsNil) |
|
| 267 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 268 | 268 |
c.Assert(out, checker.Not(checker.Contains), name+".1") |
| 269 | 269 |
c.Assert(out, checker.Not(checker.Contains), name+".2") |
| 270 | 270 |
c.Assert(out, checker.Not(checker.Contains), name+".3") |
| ... | ... |
@@ -276,20 +276,20 @@ func (s *DockerSwarmSuite) TestSwarmPublishAdd(c *check.C) {
|
| 276 | 276 |
|
| 277 | 277 |
name := "top" |
| 278 | 278 |
out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "--label", "x=y", "busybox", "top")
|
| 279 |
- c.Assert(err, checker.IsNil) |
|
| 279 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 280 | 280 |
c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") |
| 281 | 281 |
|
| 282 |
- _, err = d.Cmd("service", "update", "--detach", "--publish-add", "80:80", name)
|
|
| 283 |
- c.Assert(err, checker.IsNil) |
|
| 282 |
+ out, err = d.Cmd("service", "update", "--detach", "--publish-add", "80:80", name)
|
|
| 283 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 284 | 284 |
|
| 285 |
- _, err = d.Cmd("service", "update", "--detach", "--publish-add", "80:80", name)
|
|
| 286 |
- c.Assert(err, checker.IsNil) |
|
| 285 |
+ out, err = d.Cmd("service", "update", "--detach", "--publish-add", "80:80", name)
|
|
| 286 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 287 | 287 |
|
| 288 | 288 |
_, err = d.Cmd("service", "update", "--detach", "--publish-add", "80:80", "--publish-add", "80:20", name)
|
| 289 | 289 |
c.Assert(err, checker.NotNil) |
| 290 | 290 |
|
| 291 | 291 |
out, err = d.Cmd("service", "inspect", "--format", "{{ .Spec.EndpointSpec.Ports }}", name)
|
| 292 |
- c.Assert(err, checker.IsNil) |
|
| 292 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 293 | 293 |
c.Assert(strings.TrimSpace(out), checker.Equals, "[{ tcp 80 80 ingress}]")
|
| 294 | 294 |
} |
| 295 | 295 |
|
| ... | ... |
@@ -298,20 +298,20 @@ func (s *DockerSwarmSuite) TestSwarmServiceWithGroup(c *check.C) {
|
| 298 | 298 |
|
| 299 | 299 |
name := "top" |
| 300 | 300 |
out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "--user", "root:root", "--group", "wheel", "--group", "audio", "--group", "staff", "--group", "777", "busybox", "top")
|
| 301 |
- c.Assert(err, checker.IsNil) |
|
| 301 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 302 | 302 |
c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") |
| 303 | 303 |
|
| 304 | 304 |
// make sure task has been deployed. |
| 305 | 305 |
waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, 1) |
| 306 | 306 |
|
| 307 | 307 |
out, err = d.Cmd("ps", "-q")
|
| 308 |
- c.Assert(err, checker.IsNil) |
|
| 308 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 309 | 309 |
c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") |
| 310 | 310 |
|
| 311 | 311 |
container := strings.TrimSpace(out) |
| 312 | 312 |
|
| 313 | 313 |
out, err = d.Cmd("exec", container, "id")
|
| 314 |
- c.Assert(err, checker.IsNil) |
|
| 314 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 315 | 315 |
c.Assert(strings.TrimSpace(out), checker.Equals, "uid=0(root) gid=0(root) groups=10(wheel),29(audio),50(staff),777") |
| 316 | 316 |
} |
| 317 | 317 |
|
| ... | ... |
@@ -319,7 +319,7 @@ func (s *DockerSwarmSuite) TestSwarmContainerAutoStart(c *check.C) {
|
| 319 | 319 |
d := s.AddDaemon(c, true, true) |
| 320 | 320 |
|
| 321 | 321 |
out, err := d.Cmd("network", "create", "--attachable", "-d", "overlay", "foo")
|
| 322 |
- c.Assert(err, checker.IsNil) |
|
| 322 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 323 | 323 |
c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") |
| 324 | 324 |
|
| 325 | 325 |
out, err = d.Cmd("run", "-id", "--restart=always", "--net=foo", "--name=test", "busybox", "top")
|
| ... | ... |
@@ -366,20 +366,20 @@ func (s *DockerSwarmSuite) TestSwarmContainerAttachByNetworkId(c *check.C) {
|
| 366 | 366 |
d := s.AddDaemon(c, true, true) |
| 367 | 367 |
|
| 368 | 368 |
out, err := d.Cmd("network", "create", "--attachable", "-d", "overlay", "testnet")
|
| 369 |
- c.Assert(err, checker.IsNil) |
|
| 369 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 370 | 370 |
c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") |
| 371 | 371 |
networkID := strings.TrimSpace(out) |
| 372 | 372 |
|
| 373 | 373 |
out, err = d.Cmd("run", "-d", "--net", networkID, "busybox", "top")
|
| 374 |
- c.Assert(err, checker.IsNil) |
|
| 374 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 375 | 375 |
cID := strings.TrimSpace(out) |
| 376 | 376 |
d.WaitRun(cID) |
| 377 | 377 |
|
| 378 |
- _, err = d.Cmd("rm", "-f", cID)
|
|
| 379 |
- c.Assert(err, checker.IsNil) |
|
| 378 |
+ out, err = d.Cmd("rm", "-f", cID)
|
|
| 379 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 380 | 380 |
|
| 381 |
- _, err = d.Cmd("network", "rm", "testnet")
|
|
| 382 |
- c.Assert(err, checker.IsNil) |
|
| 381 |
+ out, err = d.Cmd("network", "rm", "testnet")
|
|
| 382 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 383 | 383 |
|
| 384 | 384 |
checkNetwork := func(*check.C) (interface{}, check.CommentInterface) {
|
| 385 | 385 |
out, err := d.Cmd("network", "ls")
|
| ... | ... |
@@ -430,12 +430,12 @@ func (s *DockerSwarmSuite) TestOverlayAttachableOnSwarmLeave(c *check.C) {
|
| 430 | 430 |
|
| 431 | 431 |
// Check the container is disconnected |
| 432 | 432 |
out, err = d.Cmd("inspect", "c1", "--format", "{{.NetworkSettings.Networks."+nwName+"}}")
|
| 433 |
- c.Assert(err, checker.IsNil) |
|
| 433 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 434 | 434 |
c.Assert(strings.TrimSpace(out), checker.Equals, "<no value>") |
| 435 | 435 |
|
| 436 | 436 |
// Check the network is gone |
| 437 | 437 |
out, err = d.Cmd("network", "ls", "--format", "{{.Name}}")
|
| 438 |
- c.Assert(err, checker.IsNil) |
|
| 438 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 439 | 439 |
c.Assert(out, checker.Not(checker.Contains), nwName) |
| 440 | 440 |
} |
| 441 | 441 |
|
| ... | ... |
@@ -451,8 +451,8 @@ func (s *DockerSwarmSuite) TestOverlayAttachableReleaseResourcesOnFailure(c *che |
| 451 | 451 |
c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
| 452 | 452 |
|
| 453 | 453 |
// Attempt to attach another container with same IP, must fail |
| 454 |
- _, err = d.Cmd("run", "-d", "--network", "ovnet", "--name", "c2", "--ip", "10.10.9.33", "busybox", "top")
|
|
| 455 |
- c.Assert(err, checker.NotNil) |
|
| 454 |
+ out, err = d.Cmd("run", "-d", "--network", "ovnet", "--name", "c2", "--ip", "10.10.9.33", "busybox", "top")
|
|
| 455 |
+ c.Assert(err, checker.NotNil, check.Commentf("%s", out))
|
|
| 456 | 456 |
|
| 457 | 457 |
// Remove first container |
| 458 | 458 |
out, err = d.Cmd("rm", "-f", "c1")
|
| ... | ... |
@@ -541,14 +541,14 @@ func (s *DockerSwarmSuite) TestSwarmTaskListFilter(c *check.C) {
|
| 541 | 541 |
|
| 542 | 542 |
name := "redis-cluster-md5" |
| 543 | 543 |
out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "--replicas=3", "busybox", "top")
|
| 544 |
- c.Assert(err, checker.IsNil) |
|
| 544 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 545 | 545 |
c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") |
| 546 | 546 |
|
| 547 | 547 |
filter := "name=redis-cluster" |
| 548 | 548 |
|
| 549 | 549 |
checkNumTasks := func(*check.C) (interface{}, check.CommentInterface) {
|
| 550 | 550 |
out, err := d.Cmd("service", "ps", "--filter", filter, name)
|
| 551 |
- c.Assert(err, checker.IsNil) |
|
| 551 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 552 | 552 |
return len(strings.Split(out, "\n")) - 2, nil // includes header and nl in last line |
| 553 | 553 |
} |
| 554 | 554 |
|
| ... | ... |
@@ -556,41 +556,41 @@ func (s *DockerSwarmSuite) TestSwarmTaskListFilter(c *check.C) {
|
| 556 | 556 |
waitAndAssert(c, defaultReconciliationTimeout, checkNumTasks, checker.Equals, 3) |
| 557 | 557 |
|
| 558 | 558 |
out, err = d.Cmd("service", "ps", "--filter", filter, name)
|
| 559 |
- c.Assert(err, checker.IsNil) |
|
| 559 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 560 | 560 |
c.Assert(out, checker.Contains, name+".1") |
| 561 | 561 |
c.Assert(out, checker.Contains, name+".2") |
| 562 | 562 |
c.Assert(out, checker.Contains, name+".3") |
| 563 | 563 |
|
| 564 | 564 |
out, err = d.Cmd("service", "ps", "--filter", "name="+name+".1", name)
|
| 565 |
- c.Assert(err, checker.IsNil) |
|
| 565 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 566 | 566 |
c.Assert(out, checker.Contains, name+".1") |
| 567 | 567 |
c.Assert(out, checker.Not(checker.Contains), name+".2") |
| 568 | 568 |
c.Assert(out, checker.Not(checker.Contains), name+".3") |
| 569 | 569 |
|
| 570 | 570 |
out, err = d.Cmd("service", "ps", "--filter", "name=none", name)
|
| 571 |
- c.Assert(err, checker.IsNil) |
|
| 571 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 572 | 572 |
c.Assert(out, checker.Not(checker.Contains), name+".1") |
| 573 | 573 |
c.Assert(out, checker.Not(checker.Contains), name+".2") |
| 574 | 574 |
c.Assert(out, checker.Not(checker.Contains), name+".3") |
| 575 | 575 |
|
| 576 | 576 |
name = "redis-cluster-sha1" |
| 577 | 577 |
out, err = d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "--mode=global", "busybox", "top")
|
| 578 |
- c.Assert(err, checker.IsNil) |
|
| 578 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 579 | 579 |
c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") |
| 580 | 580 |
|
| 581 | 581 |
waitAndAssert(c, defaultReconciliationTimeout, checkNumTasks, checker.Equals, 1) |
| 582 | 582 |
|
| 583 | 583 |
filter = "name=redis-cluster" |
| 584 | 584 |
out, err = d.Cmd("service", "ps", "--filter", filter, name)
|
| 585 |
- c.Assert(err, checker.IsNil) |
|
| 585 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 586 | 586 |
c.Assert(out, checker.Contains, name) |
| 587 | 587 |
|
| 588 | 588 |
out, err = d.Cmd("service", "ps", "--filter", "name="+name, name)
|
| 589 |
- c.Assert(err, checker.IsNil) |
|
| 589 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 590 | 590 |
c.Assert(out, checker.Contains, name) |
| 591 | 591 |
|
| 592 | 592 |
out, err = d.Cmd("service", "ps", "--filter", "name=none", name)
|
| 593 |
- c.Assert(err, checker.IsNil) |
|
| 593 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 594 | 594 |
c.Assert(out, checker.Not(checker.Contains), name) |
| 595 | 595 |
} |
| 596 | 596 |
|
| ... | ... |
@@ -599,12 +599,12 @@ func (s *DockerSwarmSuite) TestPsListContainersFilterIsTask(c *check.C) {
|
| 599 | 599 |
|
| 600 | 600 |
// Create a bare container |
| 601 | 601 |
out, err := d.Cmd("run", "-d", "--name=bare-container", "busybox", "top")
|
| 602 |
- c.Assert(err, checker.IsNil) |
|
| 602 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 603 | 603 |
bareID := strings.TrimSpace(out)[:12] |
| 604 | 604 |
// Create a service |
| 605 | 605 |
name := "busybox-top" |
| 606 | 606 |
out, err = d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "busybox", "top")
|
| 607 |
- c.Assert(err, checker.IsNil) |
|
| 607 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 608 | 608 |
c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") |
| 609 | 609 |
|
| 610 | 610 |
// make sure task has been deployed. |
| ... | ... |
@@ -612,13 +612,13 @@ func (s *DockerSwarmSuite) TestPsListContainersFilterIsTask(c *check.C) {
|
| 612 | 612 |
|
| 613 | 613 |
// Filter non-tasks |
| 614 | 614 |
out, err = d.Cmd("ps", "-a", "-q", "--filter=is-task=false")
|
| 615 |
- c.Assert(err, checker.IsNil) |
|
| 615 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 616 | 616 |
psOut := strings.TrimSpace(out) |
| 617 | 617 |
c.Assert(psOut, checker.Equals, bareID, check.Commentf("Expected id %s, got %s for is-task label, output %q", bareID, psOut, out))
|
| 618 | 618 |
|
| 619 | 619 |
// Filter tasks |
| 620 | 620 |
out, err = d.Cmd("ps", "-a", "-q", "--filter=is-task=true")
|
| 621 |
- c.Assert(err, checker.IsNil) |
|
| 621 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 622 | 622 |
lines := strings.Split(strings.Trim(out, "\n "), "\n") |
| 623 | 623 |
c.Assert(lines, checker.HasLen, 1) |
| 624 | 624 |
c.Assert(lines[0], checker.Not(checker.Equals), bareID, check.Commentf("Expected not %s, but got it for is-task label, output %q", bareID, out))
|
| ... | ... |
@@ -798,7 +798,7 @@ func setupRemoteGlobalNetworkPlugin(c *check.C, mux *http.ServeMux, url, netDrv, |
| 798 | 798 |
func (s *DockerSwarmSuite) TestSwarmNetworkPlugin(c *check.C) {
|
| 799 | 799 |
mux := http.NewServeMux() |
| 800 | 800 |
s.server = httptest.NewServer(mux) |
| 801 |
- c.Assert(s.server, check.NotNil, check.Commentf("Failed to start an HTTP Server"))
|
|
| 801 |
+ c.Assert(s.server, check.NotNil) // check that HTTP server has started |
|
| 802 | 802 |
setupRemoteGlobalNetworkPlugin(c, mux, s.server.URL, globalNetworkPlugin, globalIPAMPlugin) |
| 803 | 803 |
defer func() {
|
| 804 | 804 |
s.server.Close() |
| ... | ... |
@@ -809,7 +809,7 @@ func (s *DockerSwarmSuite) TestSwarmNetworkPlugin(c *check.C) {
|
| 809 | 809 |
d := s.AddDaemon(c, true, true) |
| 810 | 810 |
|
| 811 | 811 |
out, err := d.Cmd("network", "create", "-d", globalNetworkPlugin, "foo")
|
| 812 |
- c.Assert(err, checker.NotNil) |
|
| 812 |
+ c.Assert(err, checker.NotNil, check.Commentf("%s", out))
|
|
| 813 | 813 |
c.Assert(out, checker.Contains, "not supported in swarm mode") |
| 814 | 814 |
} |
| 815 | 815 |
|
| ... | ... |
@@ -823,12 +823,12 @@ func (s *DockerSwarmSuite) TestSwarmServiceEnvFile(c *check.C) {
|
| 823 | 823 |
|
| 824 | 824 |
name := "worker" |
| 825 | 825 |
out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--env-file", path, "--env", "VAR1=B", "--env", "VAR1=C", "--env", "VAR2=", "--env", "VAR2", "--name", name, "busybox", "top")
|
| 826 |
- c.Assert(err, checker.IsNil) |
|
| 826 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 827 | 827 |
c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") |
| 828 | 828 |
|
| 829 | 829 |
// The complete env is [VAR1=A VAR2=A VAR1=B VAR1=C VAR2= VAR2] and duplicates will be removed => [VAR1=C VAR2] |
| 830 | 830 |
out, err = d.Cmd("inspect", "--format", "{{ .Spec.TaskTemplate.ContainerSpec.Env }}", name)
|
| 831 |
- c.Assert(err, checker.IsNil) |
|
| 831 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 832 | 832 |
c.Assert(out, checker.Contains, "[VAR1=C VAR2]") |
| 833 | 833 |
} |
| 834 | 834 |
|
| ... | ... |
@@ -841,42 +841,42 @@ func (s *DockerSwarmSuite) TestSwarmServiceTTY(c *check.C) {
|
| 841 | 841 |
|
| 842 | 842 |
// Without --tty |
| 843 | 843 |
expectedOutput := "none" |
| 844 |
- _, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "busybox", "sh", "-c", ttyCheck)
|
|
| 845 |
- c.Assert(err, checker.IsNil) |
|
| 844 |
+ out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "busybox", "sh", "-c", ttyCheck)
|
|
| 845 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 846 | 846 |
|
| 847 | 847 |
// Make sure task has been deployed. |
| 848 | 848 |
waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, 1) |
| 849 | 849 |
|
| 850 | 850 |
// We need to get the container id. |
| 851 |
- out, err := d.Cmd("ps", "-q", "--no-trunc")
|
|
| 852 |
- c.Assert(err, checker.IsNil) |
|
| 851 |
+ out, err = d.Cmd("ps", "-q", "--no-trunc")
|
|
| 852 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 853 | 853 |
id := strings.TrimSpace(out) |
| 854 | 854 |
|
| 855 | 855 |
out, err = d.Cmd("exec", id, "cat", "/status")
|
| 856 |
- c.Assert(err, checker.IsNil) |
|
| 856 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 857 | 857 |
c.Assert(out, checker.Contains, expectedOutput, check.Commentf("Expected '%s', but got %q", expectedOutput, out))
|
| 858 | 858 |
|
| 859 | 859 |
// Remove service |
| 860 |
- _, err = d.Cmd("service", "rm", name)
|
|
| 861 |
- c.Assert(err, checker.IsNil) |
|
| 860 |
+ out, err = d.Cmd("service", "rm", name)
|
|
| 861 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 862 | 862 |
// Make sure container has been destroyed. |
| 863 | 863 |
waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, 0) |
| 864 | 864 |
|
| 865 | 865 |
// With --tty |
| 866 | 866 |
expectedOutput = "TTY" |
| 867 |
- _, err = d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "--tty", "busybox", "sh", "-c", ttyCheck)
|
|
| 868 |
- c.Assert(err, checker.IsNil) |
|
| 867 |
+ out, err = d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "--tty", "busybox", "sh", "-c", ttyCheck)
|
|
| 868 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 869 | 869 |
|
| 870 | 870 |
// Make sure task has been deployed. |
| 871 | 871 |
waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, 1) |
| 872 | 872 |
|
| 873 | 873 |
// We need to get the container id. |
| 874 | 874 |
out, err = d.Cmd("ps", "-q", "--no-trunc")
|
| 875 |
- c.Assert(err, checker.IsNil) |
|
| 875 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 876 | 876 |
id = strings.TrimSpace(out) |
| 877 | 877 |
|
| 878 | 878 |
out, err = d.Cmd("exec", id, "cat", "/status")
|
| 879 |
- c.Assert(err, checker.IsNil) |
|
| 879 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 880 | 880 |
c.Assert(out, checker.Contains, expectedOutput, check.Commentf("Expected '%s', but got %q", expectedOutput, out))
|
| 881 | 881 |
} |
| 882 | 882 |
|
| ... | ... |
@@ -885,21 +885,21 @@ func (s *DockerSwarmSuite) TestSwarmServiceTTYUpdate(c *check.C) {
|
| 885 | 885 |
|
| 886 | 886 |
// Create a service |
| 887 | 887 |
name := "top" |
| 888 |
- _, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "busybox", "top")
|
|
| 889 |
- c.Assert(err, checker.IsNil) |
|
| 888 |
+ out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "busybox", "top")
|
|
| 889 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 890 | 890 |
|
| 891 | 891 |
// Make sure task has been deployed. |
| 892 | 892 |
waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, 1) |
| 893 | 893 |
|
| 894 |
- out, err := d.Cmd("service", "inspect", "--format", "{{ .Spec.TaskTemplate.ContainerSpec.TTY }}", name)
|
|
| 895 |
- c.Assert(err, checker.IsNil) |
|
| 894 |
+ out, err = d.Cmd("service", "inspect", "--format", "{{ .Spec.TaskTemplate.ContainerSpec.TTY }}", name)
|
|
| 895 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 896 | 896 |
c.Assert(strings.TrimSpace(out), checker.Equals, "false") |
| 897 | 897 |
|
| 898 |
- _, err = d.Cmd("service", "update", "--detach", "--tty", name)
|
|
| 899 |
- c.Assert(err, checker.IsNil) |
|
| 898 |
+ out, err = d.Cmd("service", "update", "--detach", "--tty", name)
|
|
| 899 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 900 | 900 |
|
| 901 | 901 |
out, err = d.Cmd("service", "inspect", "--format", "{{ .Spec.TaskTemplate.ContainerSpec.TTY }}", name)
|
| 902 |
- c.Assert(err, checker.IsNil) |
|
| 902 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 903 | 903 |
c.Assert(strings.TrimSpace(out), checker.Equals, "true") |
| 904 | 904 |
} |
| 905 | 905 |
|
| ... | ... |
@@ -947,15 +947,15 @@ func (s *DockerSwarmSuite) TestDNSConfig(c *check.C) {
|
| 947 | 947 |
|
| 948 | 948 |
// Create a service |
| 949 | 949 |
name := "top" |
| 950 |
- _, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "--dns=1.2.3.4", "--dns-search=example.com", "--dns-option=timeout:3", "busybox", "top")
|
|
| 951 |
- c.Assert(err, checker.IsNil) |
|
| 950 |
+ out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "--dns=1.2.3.4", "--dns-search=example.com", "--dns-option=timeout:3", "busybox", "top")
|
|
| 951 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 952 | 952 |
|
| 953 | 953 |
// Make sure task has been deployed. |
| 954 | 954 |
waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, 1) |
| 955 | 955 |
|
| 956 | 956 |
// We need to get the container id. |
| 957 |
- out, err := d.Cmd("ps", "-a", "-q", "--no-trunc")
|
|
| 958 |
- c.Assert(err, checker.IsNil) |
|
| 957 |
+ out, err = d.Cmd("ps", "-a", "-q", "--no-trunc")
|
|
| 958 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 959 | 959 |
id := strings.TrimSpace(out) |
| 960 | 960 |
|
| 961 | 961 |
// Compare against expected output. |
| ... | ... |
@@ -963,7 +963,7 @@ func (s *DockerSwarmSuite) TestDNSConfig(c *check.C) {
|
| 963 | 963 |
expectedOutput2 := "search example.com" |
| 964 | 964 |
expectedOutput3 := "options timeout:3" |
| 965 | 965 |
out, err = d.Cmd("exec", id, "cat", "/etc/resolv.conf")
|
| 966 |
- c.Assert(err, checker.IsNil) |
|
| 966 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 967 | 967 |
c.Assert(out, checker.Contains, expectedOutput1, check.Commentf("Expected '%s', but got %q", expectedOutput1, out))
|
| 968 | 968 |
c.Assert(out, checker.Contains, expectedOutput2, check.Commentf("Expected '%s', but got %q", expectedOutput2, out))
|
| 969 | 969 |
c.Assert(out, checker.Contains, expectedOutput3, check.Commentf("Expected '%s', but got %q", expectedOutput3, out))
|
| ... | ... |
@@ -974,17 +974,17 @@ func (s *DockerSwarmSuite) TestDNSConfigUpdate(c *check.C) {
|
| 974 | 974 |
|
| 975 | 975 |
// Create a service |
| 976 | 976 |
name := "top" |
| 977 |
- _, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "busybox", "top")
|
|
| 978 |
- c.Assert(err, checker.IsNil) |
|
| 977 |
+ out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "busybox", "top")
|
|
| 978 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 979 | 979 |
|
| 980 | 980 |
// Make sure task has been deployed. |
| 981 | 981 |
waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, 1) |
| 982 | 982 |
|
| 983 |
- _, err = d.Cmd("service", "update", "--detach", "--dns-add=1.2.3.4", "--dns-search-add=example.com", "--dns-option-add=timeout:3", name)
|
|
| 984 |
- c.Assert(err, checker.IsNil) |
|
| 983 |
+ out, err = d.Cmd("service", "update", "--detach", "--dns-add=1.2.3.4", "--dns-search-add=example.com", "--dns-option-add=timeout:3", name)
|
|
| 984 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 985 | 985 |
|
| 986 |
- out, err := d.Cmd("service", "inspect", "--format", "{{ .Spec.TaskTemplate.ContainerSpec.DNSConfig }}", name)
|
|
| 987 |
- c.Assert(err, checker.IsNil) |
|
| 986 |
+ out, err = d.Cmd("service", "inspect", "--format", "{{ .Spec.TaskTemplate.ContainerSpec.DNSConfig }}", name)
|
|
| 987 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 988 | 988 |
c.Assert(strings.TrimSpace(out), checker.Equals, "{[1.2.3.4] [example.com] [timeout:3]}")
|
| 989 | 989 |
} |
| 990 | 990 |
|
| ... | ... |
@@ -1037,8 +1037,8 @@ func (s *DockerSwarmSuite) TestUnlockEngineAndUnlockedSwarm(c *check.C) {
|
| 1037 | 1037 |
c.Assert(result.Combined(), checker.Contains, "Error: This node is not part of a swarm") |
| 1038 | 1038 |
c.Assert(result.Combined(), checker.Not(checker.Contains), "Please enter unlock key") |
| 1039 | 1039 |
|
| 1040 |
- _, err := d.Cmd("swarm", "init")
|
|
| 1041 |
- c.Assert(err, checker.IsNil) |
|
| 1040 |
+ out, err := d.Cmd("swarm", "init")
|
|
| 1041 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 1042 | 1042 |
|
| 1043 | 1043 |
// unlocking an unlocked swarm should return an error - it does not even ask for the key |
| 1044 | 1044 |
cmd = d.Command("swarm", "unlock")
|
| ... | ... |
@@ -1054,7 +1054,7 @@ func (s *DockerSwarmSuite) TestSwarmInitLocked(c *check.C) {
|
| 1054 | 1054 |
d := s.AddDaemon(c, false, false) |
| 1055 | 1055 |
|
| 1056 | 1056 |
outs, err := d.Cmd("swarm", "init", "--autolock")
|
| 1057 |
- c.Assert(err, checker.IsNil, check.Commentf("out: %v", outs))
|
|
| 1057 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", outs))
|
|
| 1058 | 1058 |
|
| 1059 | 1059 |
c.Assert(outs, checker.Contains, "docker swarm unlock") |
| 1060 | 1060 |
|
| ... | ... |
@@ -1069,7 +1069,7 @@ func (s *DockerSwarmSuite) TestSwarmInitLocked(c *check.C) {
|
| 1069 | 1069 |
c.Assert(unlockKey, checker.Not(checker.Equals), "") |
| 1070 | 1070 |
|
| 1071 | 1071 |
outs, err = d.Cmd("swarm", "unlock-key", "-q")
|
| 1072 |
- c.Assert(err, checker.IsNil) |
|
| 1072 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", outs))
|
|
| 1073 | 1073 |
c.Assert(outs, checker.Equals, unlockKey+"\n") |
| 1074 | 1074 |
|
| 1075 | 1075 |
c.Assert(getNodeStatus(c, d), checker.Equals, swarm.LocalNodeStateActive) |
| ... | ... |
@@ -1094,16 +1094,16 @@ func (s *DockerSwarmSuite) TestSwarmInitLocked(c *check.C) {
|
| 1094 | 1094 |
c.Assert(getNodeStatus(c, d), checker.Equals, swarm.LocalNodeStateActive) |
| 1095 | 1095 |
|
| 1096 | 1096 |
outs, err = d.Cmd("node", "ls")
|
| 1097 |
- c.Assert(err, checker.IsNil) |
|
| 1097 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", outs))
|
|
| 1098 | 1098 |
c.Assert(outs, checker.Not(checker.Contains), "Swarm is encrypted and needs to be unlocked") |
| 1099 | 1099 |
|
| 1100 | 1100 |
outs, err = d.Cmd("swarm", "update", "--autolock=false")
|
| 1101 |
- c.Assert(err, checker.IsNil, check.Commentf("out: %v", outs))
|
|
| 1101 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", outs))
|
|
| 1102 | 1102 |
|
| 1103 | 1103 |
checkSwarmLockedToUnlocked(c, d, unlockKey) |
| 1104 | 1104 |
|
| 1105 | 1105 |
outs, err = d.Cmd("node", "ls")
|
| 1106 |
- c.Assert(err, checker.IsNil) |
|
| 1106 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", outs))
|
|
| 1107 | 1107 |
c.Assert(outs, checker.Not(checker.Contains), "Swarm is encrypted and needs to be unlocked") |
| 1108 | 1108 |
} |
| 1109 | 1109 |
|
| ... | ... |
@@ -1111,7 +1111,7 @@ func (s *DockerSwarmSuite) TestSwarmLeaveLocked(c *check.C) {
|
| 1111 | 1111 |
d := s.AddDaemon(c, false, false) |
| 1112 | 1112 |
|
| 1113 | 1113 |
outs, err := d.Cmd("swarm", "init", "--autolock")
|
| 1114 |
- c.Assert(err, checker.IsNil, check.Commentf("out: %v", outs))
|
|
| 1114 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", outs))
|
|
| 1115 | 1115 |
|
| 1116 | 1116 |
// It starts off locked |
| 1117 | 1117 |
d.Restart(c, "--swarm-default-advertise-addr=lo") |
| ... | ... |
@@ -1128,13 +1128,13 @@ func (s *DockerSwarmSuite) TestSwarmLeaveLocked(c *check.C) {
|
| 1128 | 1128 |
|
| 1129 | 1129 |
// It is OK for user to leave a locked swarm with --force |
| 1130 | 1130 |
outs, err = d.Cmd("swarm", "leave", "--force")
|
| 1131 |
- c.Assert(err, checker.IsNil, check.Commentf("out: %v", outs))
|
|
| 1131 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", outs))
|
|
| 1132 | 1132 |
|
| 1133 | 1133 |
info = d.SwarmInfo(c) |
| 1134 | 1134 |
c.Assert(info.LocalNodeState, checker.Equals, swarm.LocalNodeStateInactive) |
| 1135 | 1135 |
|
| 1136 | 1136 |
outs, err = d.Cmd("swarm", "init")
|
| 1137 |
- c.Assert(err, checker.IsNil, check.Commentf("out: %v", outs))
|
|
| 1137 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", outs))
|
|
| 1138 | 1138 |
|
| 1139 | 1139 |
info = d.SwarmInfo(c) |
| 1140 | 1140 |
c.Assert(info.LocalNodeState, checker.Equals, swarm.LocalNodeStateActive) |
| ... | ... |
@@ -1154,7 +1154,7 @@ func (s *DockerSwarmSuite) TestSwarmLockUnlockCluster(c *check.C) {
|
| 1154 | 1154 |
|
| 1155 | 1155 |
// enable autolock |
| 1156 | 1156 |
outs, err := d1.Cmd("swarm", "update", "--autolock")
|
| 1157 |
- c.Assert(err, checker.IsNil, check.Commentf("out: %v", outs))
|
|
| 1157 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", outs))
|
|
| 1158 | 1158 |
|
| 1159 | 1159 |
c.Assert(outs, checker.Contains, "docker swarm unlock") |
| 1160 | 1160 |
|
| ... | ... |
@@ -1379,7 +1379,7 @@ func (s *DockerSwarmSuite) TestSwarmClusterRotateUnlockKey(c *check.C) {
|
| 1379 | 1379 |
d3 := s.AddDaemon(c, true, true) |
| 1380 | 1380 |
|
| 1381 | 1381 |
outs, err := d1.Cmd("swarm", "update", "--autolock")
|
| 1382 |
- c.Assert(err, checker.IsNil, check.Commentf("out: %v", outs))
|
|
| 1382 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", outs))
|
|
| 1383 | 1383 |
|
| 1384 | 1384 |
c.Assert(outs, checker.Contains, "docker swarm unlock") |
| 1385 | 1385 |
|
| ... | ... |
@@ -1394,13 +1394,13 @@ func (s *DockerSwarmSuite) TestSwarmClusterRotateUnlockKey(c *check.C) {
|
| 1394 | 1394 |
c.Assert(unlockKey, checker.Not(checker.Equals), "") |
| 1395 | 1395 |
|
| 1396 | 1396 |
outs, err = d1.Cmd("swarm", "unlock-key", "-q")
|
| 1397 |
- c.Assert(err, checker.IsNil) |
|
| 1397 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", outs))
|
|
| 1398 | 1398 |
c.Assert(outs, checker.Equals, unlockKey+"\n") |
| 1399 | 1399 |
|
| 1400 | 1400 |
// Rotate multiple times |
| 1401 | 1401 |
for i := 0; i != 3; i++ {
|
| 1402 | 1402 |
outs, err = d1.Cmd("swarm", "unlock-key", "-q", "--rotate")
|
| 1403 |
- c.Assert(err, checker.IsNil, check.Commentf("out: %v", outs))
|
|
| 1403 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", outs))
|
|
| 1404 | 1404 |
// Strip \n |
| 1405 | 1405 |
newUnlockKey := outs[:len(outs)-1] |
| 1406 | 1406 |
c.Assert(newUnlockKey, checker.Not(checker.Equals), "") |
| ... | ... |
@@ -1451,7 +1451,7 @@ func (s *DockerSwarmSuite) TestSwarmClusterRotateUnlockKey(c *check.C) {
|
| 1451 | 1451 |
c.Assert(getNodeStatus(c, d), checker.Equals, swarm.LocalNodeStateActive) |
| 1452 | 1452 |
|
| 1453 | 1453 |
outs, err = d.Cmd("node", "ls")
|
| 1454 |
- c.Assert(err, checker.IsNil) |
|
| 1454 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", outs))
|
|
| 1455 | 1455 |
c.Assert(outs, checker.Not(checker.Contains), "Swarm is encrypted and needs to be unlocked") |
| 1456 | 1456 |
} |
| 1457 | 1457 |
|
| ... | ... |
@@ -1497,21 +1497,21 @@ func (s *DockerSwarmSuite) TestExtraHosts(c *check.C) {
|
| 1497 | 1497 |
|
| 1498 | 1498 |
// Create a service |
| 1499 | 1499 |
name := "top" |
| 1500 |
- _, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "--host=example.com:1.2.3.4", "busybox", "top")
|
|
| 1501 |
- c.Assert(err, checker.IsNil) |
|
| 1500 |
+ out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "--host=example.com:1.2.3.4", "busybox", "top")
|
|
| 1501 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 1502 | 1502 |
|
| 1503 | 1503 |
// Make sure task has been deployed. |
| 1504 | 1504 |
waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, 1) |
| 1505 | 1505 |
|
| 1506 | 1506 |
// We need to get the container id. |
| 1507 |
- out, err := d.Cmd("ps", "-a", "-q", "--no-trunc")
|
|
| 1508 |
- c.Assert(err, checker.IsNil) |
|
| 1507 |
+ out, err = d.Cmd("ps", "-a", "-q", "--no-trunc")
|
|
| 1508 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 1509 | 1509 |
id := strings.TrimSpace(out) |
| 1510 | 1510 |
|
| 1511 | 1511 |
// Compare against expected output. |
| 1512 | 1512 |
expectedOutput := "1.2.3.4\texample.com" |
| 1513 | 1513 |
out, err = d.Cmd("exec", id, "cat", "/etc/hosts")
|
| 1514 |
- c.Assert(err, checker.IsNil) |
|
| 1514 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 1515 | 1515 |
c.Assert(out, checker.Contains, expectedOutput, check.Commentf("Expected '%s', but got %q", expectedOutput, out))
|
| 1516 | 1516 |
} |
| 1517 | 1517 |
|
| ... | ... |
@@ -1524,15 +1524,15 @@ func (s *DockerSwarmSuite) TestSwarmManagerAddress(c *check.C) {
|
| 1524 | 1524 |
expectedOutput := fmt.Sprintf("Manager Addresses:\n 127.0.0.1:%d\n", d1.SwarmPort)
|
| 1525 | 1525 |
|
| 1526 | 1526 |
out, err := d1.Cmd("info")
|
| 1527 |
- c.Assert(err, checker.IsNil) |
|
| 1527 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 1528 | 1528 |
c.Assert(out, checker.Contains, expectedOutput) |
| 1529 | 1529 |
|
| 1530 | 1530 |
out, err = d2.Cmd("info")
|
| 1531 |
- c.Assert(err, checker.IsNil) |
|
| 1531 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 1532 | 1532 |
c.Assert(out, checker.Contains, expectedOutput) |
| 1533 | 1533 |
|
| 1534 | 1534 |
out, err = d3.Cmd("info")
|
| 1535 |
- c.Assert(err, checker.IsNil) |
|
| 1535 |
+ c.Assert(err, checker.IsNil, check.Commentf("%s", out))
|
|
| 1536 | 1536 |
c.Assert(out, checker.Contains, expectedOutput) |
| 1537 | 1537 |
} |
| 1538 | 1538 |
|