Signed-off-by: Darren Stahl <darst@microsoft.com>
| ... | ... |
@@ -17,10 +17,6 @@ import ( |
| 17 | 17 |
) |
| 18 | 18 |
|
| 19 | 19 |
func (s *DockerSuite) TestPsListContainersBase(c *check.C) {
|
| 20 |
- // TODO Windows: Figure out why TestPsListContainers* are flakey |
|
| 21 |
- if daemonPlatform == "windows" {
|
|
| 22 |
- c.Skip("Flaky on windowsTP4")
|
|
| 23 |
- } |
|
| 24 | 20 |
out, _ := runSleepingContainer(c, "-d") |
| 25 | 21 |
firstID := strings.TrimSpace(out) |
| 26 | 22 |
|
| ... | ... |
@@ -123,11 +119,6 @@ func (s *DockerSuite) TestPsListContainersBase(c *check.C) {
|
| 123 | 123 |
|
| 124 | 124 |
// FIXME remove this for 1.12 as --since and --before are deprecated |
| 125 | 125 |
func (s *DockerSuite) TestPsListContainersDeprecatedSinceAndBefore(c *check.C) {
|
| 126 |
- // TODO Windows: Figure out why TestPsListContainers* are flakey |
|
| 127 |
- if daemonPlatform == "windows" {
|
|
| 128 |
- c.Skip("Flaky on windowsTP4")
|
|
| 129 |
- } |
|
| 130 |
- |
|
| 131 | 126 |
out, _ := runSleepingContainer(c, "-d") |
| 132 | 127 |
firstID := strings.TrimSpace(out) |
| 133 | 128 |
|
| ... | ... |
@@ -223,11 +214,6 @@ func assertContainerList(out string, expected []string) bool {
|
| 223 | 223 |
} |
| 224 | 224 |
|
| 225 | 225 |
func (s *DockerSuite) TestPsListContainersSize(c *check.C) {
|
| 226 |
- // TODO Windows: Figure out why TestPsListContainers* are flakey |
|
| 227 |
- if daemonPlatform == "windows" {
|
|
| 228 |
- c.Skip("Flaky on windowsTP4")
|
|
| 229 |
- } |
|
| 230 |
- |
|
| 231 | 226 |
// Problematic on Windows as it doesn't report the size correctly @swernli |
| 232 | 227 |
testRequires(c, DaemonIsLinux) |
| 233 | 228 |
dockerCmd(c, "run", "-d", "busybox") |
| ... | ... |
@@ -270,11 +256,6 @@ func (s *DockerSuite) TestPsListContainersSize(c *check.C) {
|
| 270 | 270 |
} |
| 271 | 271 |
|
| 272 | 272 |
func (s *DockerSuite) TestPsListContainersFilterStatus(c *check.C) {
|
| 273 |
- // TODO Windows: Figure out why TestPsListContainers* are flakey |
|
| 274 |
- if daemonPlatform == "windows" {
|
|
| 275 |
- c.Skip("Flaky on windowsTP4")
|
|
| 276 |
- } |
|
| 277 |
- |
|
| 278 | 273 |
// start exited container |
| 279 | 274 |
out, _ := dockerCmd(c, "run", "-d", "busybox") |
| 280 | 275 |
firstID := strings.TrimSpace(out) |
| ... | ... |
@@ -314,11 +295,6 @@ func (s *DockerSuite) TestPsListContainersFilterStatus(c *check.C) {
|
| 314 | 314 |
} |
| 315 | 315 |
|
| 316 | 316 |
func (s *DockerSuite) TestPsListContainersFilterID(c *check.C) {
|
| 317 |
- // TODO Windows: Figure out why TestPsListContainers* are flakey |
|
| 318 |
- if daemonPlatform == "windows" {
|
|
| 319 |
- c.Skip("Flaky on windowsTP4")
|
|
| 320 |
- } |
|
| 321 |
- |
|
| 322 | 317 |
// start container |
| 323 | 318 |
out, _ := dockerCmd(c, "run", "-d", "busybox") |
| 324 | 319 |
firstID := strings.TrimSpace(out) |
| ... | ... |
@@ -334,11 +310,6 @@ func (s *DockerSuite) TestPsListContainersFilterID(c *check.C) {
|
| 334 | 334 |
} |
| 335 | 335 |
|
| 336 | 336 |
func (s *DockerSuite) TestPsListContainersFilterName(c *check.C) {
|
| 337 |
- // TODO Windows: Figure out why TestPsListContainers* are flakey |
|
| 338 |
- if daemonPlatform == "windows" {
|
|
| 339 |
- c.Skip("Flaky on windowsTP4")
|
|
| 340 |
- } |
|
| 341 |
- |
|
| 342 | 337 |
// start container |
| 343 | 338 |
dockerCmd(c, "run", "--name=a_name_to_match", "busybox") |
| 344 | 339 |
id, err := getIDByName("a_name_to_match")
|
| ... | ... |
@@ -362,11 +333,6 @@ func (s *DockerSuite) TestPsListContainersFilterName(c *check.C) {
|
| 362 | 362 |
// - Run containers for each of those image (busybox, images_ps_filter_test1, images_ps_filter_test2) |
| 363 | 363 |
// - Filter them out :P |
| 364 | 364 |
func (s *DockerSuite) TestPsListContainersFilterAncestorImage(c *check.C) {
|
| 365 |
- // TODO Windows: Figure out why TestPsListContainers* are flakey |
|
| 366 |
- if daemonPlatform == "windows" {
|
|
| 367 |
- c.Skip("Flaky on windowsTP4")
|
|
| 368 |
- } |
|
| 369 |
- |
|
| 370 | 365 |
// Build images |
| 371 | 366 |
imageName1 := "images_ps_filter_test1" |
| 372 | 367 |
imageID1, err := buildImage(imageName1, |
| ... | ... |
@@ -468,11 +434,6 @@ func checkPsAncestorFilterOutput(c *check.C, out string, filterName string, expe |
| 468 | 468 |
} |
| 469 | 469 |
|
| 470 | 470 |
func (s *DockerSuite) TestPsListContainersFilterLabel(c *check.C) {
|
| 471 |
- // TODO Windows: Figure out why TestPsListContainers* are flakey |
|
| 472 |
- if daemonPlatform == "windows" {
|
|
| 473 |
- c.Skip("Flaky on windowsTP4")
|
|
| 474 |
- } |
|
| 475 |
- |
|
| 476 | 471 |
// start container |
| 477 | 472 |
dockerCmd(c, "run", "--name=first", "-l", "match=me", "-l", "second=tag", "busybox") |
| 478 | 473 |
firstID, err := getIDByName("first")
|
| ... | ... |
@@ -512,11 +473,6 @@ func (s *DockerSuite) TestPsListContainersFilterLabel(c *check.C) {
|
| 512 | 512 |
} |
| 513 | 513 |
|
| 514 | 514 |
func (s *DockerSuite) TestPsListContainersFilterExited(c *check.C) {
|
| 515 |
- // TODO Windows: Figure out why TestPsListContainers* are flakey |
|
| 516 |
- if daemonPlatform == "windows" {
|
|
| 517 |
- c.Skip("Flaky on windowsTP4")
|
|
| 518 |
- } |
|
| 519 |
- |
|
| 520 | 515 |
runSleepingContainer(c, "--name=sleep") |
| 521 | 516 |
|
| 522 | 517 |
dockerCmd(c, "run", "--name", "zero1", "busybox", "true") |
| ... | ... |
@@ -636,11 +592,6 @@ func (s *DockerSuite) TestPsWithSize(c *check.C) {
|
| 636 | 636 |
} |
| 637 | 637 |
|
| 638 | 638 |
func (s *DockerSuite) TestPsListContainersFilterCreated(c *check.C) {
|
| 639 |
- // TODO Windows: Figure out why TestPsListContainers* are flakey |
|
| 640 |
- if daemonPlatform == "windows" {
|
|
| 641 |
- c.Skip("Flaky on windowsTP4")
|
|
| 642 |
- } |
|
| 643 |
- |
|
| 644 | 639 |
// create a container |
| 645 | 640 |
out, _ := dockerCmd(c, "create", "busybox") |
| 646 | 641 |
cID := strings.TrimSpace(out) |