GitList

Browse code

chroot: remount everything as private in new mntns

If parent of the destination path is shared, this
path will be unmounted from the parent ns even if
the path itself is private.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>

Tonis Tiigi authored on 2016/10/21 07:29:23
Showing 1 changed files

pkg/chrootarchive/chroot_linux.go index 7153b48..9f1dd52 100644

pkg/chrootarchive/chroot_linux.go

History View file @ b511d1f

@@ -26,7 +26,12 @@ func chroot(path string) (err error) {
                      		return fmt.Errorf("Error creating mount namespace before pivot: %v", err)
+                     	}
                     -	if err := mount.MakeRPrivate(path); err != nil {
                     +	// make everything in new ns private
                     +	if err := mount.MakeRPrivate("/"); err != nil {
                     +		return err
                     +	}
                     +	// ensure path is a mountpoint
                     +	if err := mount.MakePrivate(path); err != nil {
                      		return err
+                     	}