Browse code

Bump golang 1.12.8 (CVE-2019-9512, CVE-2019-9514)

go1.12.8 (released 2019/08/13) includes security fixes to the net/http and net/url packages.
See the Go 1.12.8 milestone on our issue tracker for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.12.8

- net/http: Denial of Service vulnerabilities in the HTTP/2 implementation
net/http and golang.org/x/net/http2 servers that accept direct connections from untrusted
clients could be remotely made to allocate an unlimited amount of memory, until the program
crashes. Servers will now close connections if the send queue accumulates too many control
messages.
The issues are CVE-2019-9512 and CVE-2019-9514, and Go issue golang.org/issue/33606.
Thanks to Jonathan Looney from Netflix for discovering and reporting these issues.
This is also fixed in version v0.0.0-20190813141303-74dc4d7220e7 of golang.org/x/net/http2.
net/url: parsing validation issue
- url.Parse would accept URLs with malformed hosts, such that the Host field could have arbitrary
suffixes that would appear in neither Hostname() nor Port(), allowing authorization bypasses
in certain applications. Note that URLs with invalid, not numeric ports will now return an error
from url.Parse.
The issue is CVE-2019-14809 and Go issue golang.org/issue/29098.
Thanks to Julian Hector and Nikolai Krein from Cure53, and Adi Cohen (adico.me) for discovering
and reporting this issue.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 73b0e4c58995927ab31e0e42351de7cdefe96e55)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Sebastiaan van Stijn authored on 2019/08/14 09:27:05
Showing 5 changed files
... ...
@@ -25,7 +25,7 @@
25 25
 #
26 26
 
27 27
 ARG CROSS="false"
28
-ARG GO_VERSION=1.12.7
28
+ARG GO_VERSION=1.12.8
29 29
 
30 30
 FROM golang:${GO_VERSION}-stretch AS base
31 31
 ARG APT_MIRROR
... ...
@@ -1,4 +1,4 @@
1
-ARG GO_VERSION=1.12.7
1
+ARG GO_VERSION=1.12.8
2 2
 
3 3
 FROM golang:${GO_VERSION}-alpine AS base
4 4
 
... ...
@@ -5,7 +5,7 @@
5 5
 
6 6
 # This represents the bare minimum required to build and test Docker.
7 7
 
8
-ARG GO_VERSION=1.12.7
8
+ARG GO_VERSION=1.12.8
9 9
 
10 10
 FROM golang:${GO_VERSION}-stretch
11 11
 
... ...
@@ -165,7 +165,7 @@ FROM microsoft/windowsservercore
165 165
 # Use PowerShell as the default shell
166 166
 SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"]
167 167
 
168
-ARG GO_VERSION=1.12.7
168
+ARG GO_VERSION=1.12.8
169 169
 
170 170
 # Environment variable notes:
171 171
 #  - GO_VERSION must be consistent with 'Dockerfile' used by Linux.
... ...
@@ -92,5 +92,5 @@ You can change a version of golang used for building stuff that is being tested
92 92
 by setting `GO_VERSION` variable, for example:
93 93
 
94 94
 ```
95
-make GO_VERSION=1.12.7 test
95
+make GO_VERSION=1.12.8 test
96 96
 ```