Browse code

Revert "Fix line delimited JSON response"

This reverts commit d2f75a3040e72562ffa825d5c3efa7004af2640a.

Conflicts:
integration-cli/docker_api_events_test.go

Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <jess@docker.com> (github: jfrazelle)

Jessica Frazelle authored on 2014/10/10 05:20:38
Showing 4 changed files
... ...
@@ -168,7 +168,7 @@ func (cli *DockerCli) streamHelper(method, path string, setRawTerminal bool, in
168 168
 	}
169 169
 
170 170
 	if api.MatchesContentType(resp.Header.Get("Content-Type"), "application/json") {
171
-		return utils.DisplayJSONMessagesStream(resp.Body, stdout, cli.terminalFd, cli.isTerminal)
171
+		return utils.DisplayJSONMessagesStream(resp.Body, stdout, cli.outFd, cli.isTerminalOut)
172 172
 	}
173 173
 	if stdout != nil || stderr != nil {
174 174
 		// When TTY is ON, use regular copy
... ...
@@ -297,8 +297,6 @@ func getEvents(eng *engine.Engine, version version.Version, w http.ResponseWrite
297 297
 	}
298 298
 
299 299
 	var job = eng.Job("events")
300
-	// lineDelimited JSON events was added #7047
301
-	job.SetenvBool("lineDelim", version.GreaterThanOrEqualTo("1.15"))
302 300
 	streamJSON(job, w, true)
303 301
 	job.Setenv("since", r.Form.Get("since"))
304 302
 	job.Setenv("until", r.Form.Get("until"))
... ...
@@ -101,11 +101,6 @@ func writeEvent(job *engine.Job, event *utils.JSONMessage) error {
101 101
 	// When sending an event JSON serialization errors are ignored, but all
102 102
 	// other errors lead to the eviction of the listener.
103 103
 	if b, err := json.Marshal(event); err == nil {
104
-
105
-		if job.GetenvBool("lineDelim") {
106
-			b = append(b, []byte("\r\n")...)
107
-		}
108
-
109 104
 		if _, err = job.Stdout.Write(b); err != nil {
110 105
 			return err
111 106
 		}
112 107
deleted file mode 100644
... ...
@@ -1,57 +0,0 @@
1
-package main
2
-
3
-import (
4
-	"bufio"
5
-	"bytes"
6
-	"encoding/json"
7
-	"fmt"
8
-	"testing"
9
-	"time"
10
-)
11
-
12
-func TestEventsApiGetLineDelim(t *testing.T) {
13
-	name := "testimageevents"
14
-	defer deleteImages(name)
15
-	_, err := buildImage(name,
16
-		`FROM scratch
17
-        MAINTAINER "docker"`,
18
-		true)
19
-	if err != nil {
20
-		t.Fatal(err)
21
-	}
22
-	if err := deleteImages(name); err != nil {
23
-		t.Fatal(err)
24
-	}
25
-
26
-	endpoint := fmt.Sprintf("/events?since=1&until=%d", time.Now().Unix())
27
-	body, err := sockRequest("GET", endpoint)
28
-	if err != nil {
29
-		t.Fatal(err)
30
-	}
31
-
32
-	linesRead := 0
33
-	scanner := bufio.NewScanner(bytes.NewReader(body))
34
-	for scanner.Scan() && linesRead < 2 {
35
-		line := scanner.Bytes()
36
-		if len(line) == 0 {
37
-			continue
38
-		}
39
-
40
-		// make sure line delimited json
41
-		res := make(map[string]interface{})
42
-		if err := json.Unmarshal(line, &res); err != nil {
43
-			t.Fatalf("Unmarshaling the line as JSON failed: %v", err)
44
-		}
45
-
46
-		linesRead++
47
-	}
48
-	if err := scanner.Err(); err != nil {
49
-		t.Fatalf("Scanner failed: %v", err)
50
-	}
51
-
52
-	if linesRead < 2 {
53
-		t.Fatalf("Only %d lines were read from the stream", linesRead)
54
-	}
55
-
56
-	logDone("events - test the api response is line delimited json")
57
-}