Browse code

Windows: Enable multiple cli build tests

Signed-off-by: John Howard <jhoward@microsoft.com>

John Howard authored on 2016/08/31 01:26:06
Showing 1 changed files
... ...
@@ -2048,7 +2048,6 @@ func (s *DockerSuite) TestBuildContextCleanup(c *check.C) {
2048 2048
 }
2049 2049
 
2050 2050
 func (s *DockerSuite) TestBuildContextCleanupFailedBuild(c *check.C) {
2051
-	testRequires(c, DaemonIsLinux)
2052 2051
 	testRequires(c, SameHostDaemon)
2053 2052
 
2054 2053
 	name := "testbuildcontextcleanup"
... ...
@@ -2057,7 +2056,7 @@ func (s *DockerSuite) TestBuildContextCleanupFailedBuild(c *check.C) {
2057 2057
 		c.Fatalf("failed to list contents of tmp dir: %s", err)
2058 2058
 	}
2059 2059
 	_, err = buildImage(name,
2060
-		`FROM scratch
2060
+		`FROM `+minimalBaseImage()+`
2061 2061
 	RUN /non/existing/command`,
2062 2062
 		true)
2063 2063
 	if err == nil {
... ...
@@ -3092,10 +3091,6 @@ func (s *DockerSuite) TestBuildVerifyIntString(c *check.C) {
3092 3092
 }
3093 3093
 
3094 3094
 func (s *DockerSuite) TestBuildDockerignore(c *check.C) {
3095
-	testRequires(c, DaemonIsLinux) // TODO Windows: This test passes on Windows,
3096
-	// but currently adds a disproportionate amount of time for the value it has.
3097
-	// Removing it from Windows CI for now, but this will be revisited in the
3098
-	// TP5 timeframe when perf is better.
3099 3095
 	name := "testbuilddockerignore"
3100 3096
 	dockerfile := `
3101 3097
         FROM busybox
... ...
@@ -3162,10 +3157,6 @@ func (s *DockerSuite) TestBuildDockerignoreCleanPaths(c *check.C) {
3162 3162
 }
3163 3163
 
3164 3164
 func (s *DockerSuite) TestBuildDockerignoreExceptions(c *check.C) {
3165
-	testRequires(c, DaemonIsLinux) // TODO Windows: This test passes on Windows,
3166
-	// but currently adds a disproportionate amount of time for the value it has.
3167
-	// Removing it from Windows CI for now, but this will be revisited in the
3168
-	// TP5 timeframe when perf is better.
3169 3165
 	name := "testbuilddockerignoreexceptions"
3170 3166
 	dockerfile := `
3171 3167
         FROM busybox
... ...
@@ -3432,8 +3423,6 @@ func (s *DockerSuite) TestBuildDockerignoringWildTopDir(c *check.C) {
3432 3432
 }
3433 3433
 
3434 3434
 func (s *DockerSuite) TestBuildDockerignoringWildDirs(c *check.C) {
3435
-	testRequires(c, DaemonIsLinux) // TODO Windows: Fix this test; also perf
3436
-
3437 3435
 	dockerfile := `
3438 3436
         FROM busybox
3439 3437
 		COPY . /
... ...
@@ -4068,7 +4057,6 @@ func (s *DockerSuite) TestBuildFromGITwithF(c *check.C) {
4068 4068
 }
4069 4069
 
4070 4070
 func (s *DockerSuite) TestBuildFromRemoteTarball(c *check.C) {
4071
-	testRequires(c, DaemonIsLinux)
4072 4071
 	name := "testbuildfromremotetarball"
4073 4072
 
4074 4073
 	buffer := new(bytes.Buffer)
... ...
@@ -4941,8 +4929,6 @@ RUN echo from Dockerfile`,
4941 4941
 }
4942 4942
 
4943 4943
 func (s *DockerSuite) TestBuildFromURLWithF(c *check.C) {
4944
-	testRequires(c, DaemonIsLinux)
4945
-
4946 4944
 	server, err := fakeStorage(map[string]string{"baz": `FROM busybox
4947 4945
 RUN echo from baz
4948 4946
 COPY * /tmp/
... ...
@@ -5649,7 +5635,6 @@ func (s *DockerSuite) TestBuildBuildTimeArg(c *check.C) {
5649 5649
 }
5650 5650
 
5651 5651
 func (s *DockerSuite) TestBuildBuildTimeArgHistory(c *check.C) {
5652
-	testRequires(c, DaemonIsLinux) // Windows does not support ARG
5653 5652
 	imgName := "bldargtest"
5654 5653
 	envKey := "foo"
5655 5654
 	envVal := "bar"
... ...
@@ -5675,7 +5660,6 @@ func (s *DockerSuite) TestBuildBuildTimeArgHistory(c *check.C) {
5675 5675
 }
5676 5676
 
5677 5677
 func (s *DockerSuite) TestBuildBuildTimeArgCacheHit(c *check.C) {
5678
-	testRequires(c, DaemonIsLinux) // Windows does not support ARG
5679 5678
 	imgName := "bldargtest"
5680 5679
 	envKey := "foo"
5681 5680
 	envVal := "bar"
... ...
@@ -5702,7 +5686,6 @@ func (s *DockerSuite) TestBuildBuildTimeArgCacheHit(c *check.C) {
5702 5702
 }
5703 5703
 
5704 5704
 func (s *DockerSuite) TestBuildBuildTimeArgCacheMissExtraArg(c *check.C) {
5705
-	testRequires(c, DaemonIsLinux) // Windows does not support ARG
5706 5705
 	imgName := "bldargtest"
5707 5706
 	envKey := "foo"
5708 5707
 	envVal := "bar"
... ...
@@ -5734,7 +5717,6 @@ func (s *DockerSuite) TestBuildBuildTimeArgCacheMissExtraArg(c *check.C) {
5734 5734
 }
5735 5735
 
5736 5736
 func (s *DockerSuite) TestBuildBuildTimeArgCacheMissSameArgDiffVal(c *check.C) {
5737
-	testRequires(c, DaemonIsLinux) // Windows does not support ARG
5738 5737
 	imgName := "bldargtest"
5739 5738
 	envKey := "foo"
5740 5739
 	envVal := "bar"
... ...
@@ -6028,7 +6010,6 @@ func (s *DockerSuite) TestBuildBuildTimeArgDefaultOverride(c *check.C) {
6028 6028
 }
6029 6029
 
6030 6030
 func (s *DockerSuite) TestBuildBuildTimeArgUnconsumedArg(c *check.C) {
6031
-	testRequires(c, DaemonIsLinux) // Windows does not support --build-arg
6032 6031
 	imgName := "bldargtest"
6033 6032
 	envKey := "foo"
6034 6033
 	envVal := "bar"
... ...
@@ -6049,7 +6030,6 @@ func (s *DockerSuite) TestBuildBuildTimeArgUnconsumedArg(c *check.C) {
6049 6049
 }
6050 6050
 
6051 6051
 func (s *DockerSuite) TestBuildBuildTimeArgQuotedValVariants(c *check.C) {
6052
-	testRequires(c, DaemonIsLinux) // Windows does not support ARG
6053 6052
 	imgName := "bldargtest"
6054 6053
 	envKey := "foo"
6055 6054
 	envKey1 := "foo1"
... ...
@@ -6095,7 +6075,6 @@ func (s *DockerSuite) TestBuildBuildTimeArgEmptyValVariants(c *check.C) {
6095 6095
 }
6096 6096
 
6097 6097
 func (s *DockerSuite) TestBuildBuildTimeArgDefintionWithNoEnvInjection(c *check.C) {
6098
-	testRequires(c, DaemonIsLinux) // Windows does not support ARG
6099 6098
 	imgName := "bldargtest"
6100 6099
 	envKey := "foo"
6101 6100
 	args := []string{}
... ...
@@ -6172,7 +6151,6 @@ func (s *DockerSuite) TestBuildMultipleTags(c *check.C) {
6172 6172
 
6173 6173
 // #17290
6174 6174
 func (s *DockerSuite) TestBuildCacheBrokenSymlink(c *check.C) {
6175
-	testRequires(c, DaemonIsLinux)
6176 6175
 	name := "testbuildbrokensymlink"
6177 6176
 	ctx, err := fakeContext(`
6178 6177
 	FROM busybox
... ...
@@ -6202,7 +6180,6 @@ func (s *DockerSuite) TestBuildCacheBrokenSymlink(c *check.C) {
6202 6202
 }
6203 6203
 
6204 6204
 func (s *DockerSuite) TestBuildFollowSymlinkToFile(c *check.C) {
6205
-	testRequires(c, DaemonIsLinux)
6206 6205
 	name := "testbuildbrokensymlink"
6207 6206
 	ctx, err := fakeContext(`
6208 6207
 	FROM busybox
... ...
@@ -6235,7 +6212,6 @@ func (s *DockerSuite) TestBuildFollowSymlinkToFile(c *check.C) {
6235 6235
 }
6236 6236
 
6237 6237
 func (s *DockerSuite) TestBuildFollowSymlinkToDir(c *check.C) {
6238
-	testRequires(c, DaemonIsLinux)
6239 6238
 	name := "testbuildbrokensymlink"
6240 6239
 	ctx, err := fakeContext(`
6241 6240
 	FROM busybox