Signed-off-by: Mohammed Aaqib Ansari <maaquib@gmail.com>
| ... | ... |
@@ -12,6 +12,7 @@ import ( |
| 12 | 12 |
"time" |
| 13 | 13 |
"unicode" |
| 14 | 14 |
|
| 15 |
+ "github.com/docker/docker/pkg/integration/checker" |
|
| 15 | 16 |
"github.com/go-check/check" |
| 16 | 17 |
"github.com/kr/pty" |
| 17 | 18 |
) |
| ... | ... |
@@ -22,35 +23,25 @@ func (s *DockerSuite) TestEventsRedirectStdout(c *check.C) {
|
| 22 | 22 |
dockerCmd(c, "run", "busybox", "true") |
| 23 | 23 |
|
| 24 | 24 |
file, err := ioutil.TempFile("", "")
|
| 25 |
- if err != nil {
|
|
| 26 |
- c.Fatalf("could not create temp file: %v", err)
|
|
| 27 |
- } |
|
| 25 |
+ c.Assert(err, checker.IsNil, check.Commentf("could not create temp file"))
|
|
| 28 | 26 |
defer os.Remove(file.Name()) |
| 29 | 27 |
|
| 30 | 28 |
command := fmt.Sprintf("%s events --since=%d --until=%d > %s", dockerBinary, since, daemonTime(c).Unix(), file.Name())
|
| 31 | 29 |
_, tty, err := pty.Open() |
| 32 |
- if err != nil {
|
|
| 33 |
- c.Fatalf("Could not open pty: %v", err)
|
|
| 34 |
- } |
|
| 30 |
+ c.Assert(err, checker.IsNil, check.Commentf("Could not open pty"))
|
|
| 35 | 31 |
cmd := exec.Command("sh", "-c", command)
|
| 36 | 32 |
cmd.Stdin = tty |
| 37 | 33 |
cmd.Stdout = tty |
| 38 | 34 |
cmd.Stderr = tty |
| 39 |
- if err := cmd.Run(); err != nil {
|
|
| 40 |
- c.Fatalf("run err for command %q: %v", command, err)
|
|
| 41 |
- } |
|
| 35 |
+ c.Assert(cmd.Run(), checker.IsNil, check.Commentf("run err for command %q", command))
|
|
| 42 | 36 |
|
| 43 | 37 |
scanner := bufio.NewScanner(file) |
| 44 | 38 |
for scanner.Scan() {
|
| 45 | 39 |
for _, ch := range scanner.Text() {
|
| 46 |
- if unicode.IsControl(ch) {
|
|
| 47 |
- c.Fatalf("found control character %v", []byte(string(ch)))
|
|
| 48 |
- } |
|
| 40 |
+ c.Assert(unicode.IsControl(ch), checker.False, check.Commentf("found control character %v", []byte(string(ch))))
|
|
| 49 | 41 |
} |
| 50 | 42 |
} |
| 51 |
- if err := scanner.Err(); err != nil {
|
|
| 52 |
- c.Fatalf("Scan err for command %q: %v", command, err)
|
|
| 53 |
- } |
|
| 43 |
+ c.Assert(scanner.Err(), checker.IsNil, check.Commentf("Scan err for command %q", command))
|
|
| 54 | 44 |
|
| 55 | 45 |
} |
| 56 | 46 |
|
| ... | ... |
@@ -69,37 +60,25 @@ func (s *DockerSuite) TestEventsOOMDisableFalse(c *check.C) {
|
| 69 | 69 |
}() |
| 70 | 70 |
select {
|
| 71 | 71 |
case err := <-errChan: |
| 72 |
- c.Assert(err, check.IsNil) |
|
| 72 |
+ c.Assert(err, checker.IsNil) |
|
| 73 | 73 |
case <-time.After(30 * time.Second): |
| 74 | 74 |
c.Fatal("Timeout waiting for container to die on OOM")
|
| 75 | 75 |
} |
| 76 | 76 |
|
| 77 | 77 |
out, _ := dockerCmd(c, "events", "--since=0", "-f", "container=oomFalse", fmt.Sprintf("--until=%d", daemonTime(c).Unix()))
|
| 78 | 78 |
events := strings.Split(strings.TrimSuffix(out, "\n"), "\n") |
| 79 |
- if len(events) < 5 {
|
|
| 80 |
- c.Fatalf("Missing expected event")
|
|
| 81 |
- } |
|
| 79 |
+ c.Assert(len(events), checker.GreaterOrEqualThan, 5) //Missing expected event |
|
| 82 | 80 |
|
| 83 | 81 |
createEvent := strings.Fields(events[len(events)-5]) |
| 84 | 82 |
attachEvent := strings.Fields(events[len(events)-4]) |
| 85 | 83 |
startEvent := strings.Fields(events[len(events)-3]) |
| 86 | 84 |
oomEvent := strings.Fields(events[len(events)-2]) |
| 87 | 85 |
dieEvent := strings.Fields(events[len(events)-1]) |
| 88 |
- if createEvent[len(createEvent)-1] != "create" {
|
|
| 89 |
- c.Fatalf("event should be create, not %#v", createEvent)
|
|
| 90 |
- } |
|
| 91 |
- if attachEvent[len(attachEvent)-1] != "attach" {
|
|
| 92 |
- c.Fatalf("event should be attach, not %#v", attachEvent)
|
|
| 93 |
- } |
|
| 94 |
- if startEvent[len(startEvent)-1] != "start" {
|
|
| 95 |
- c.Fatalf("event should be start, not %#v", startEvent)
|
|
| 96 |
- } |
|
| 97 |
- if oomEvent[len(oomEvent)-1] != "oom" {
|
|
| 98 |
- c.Fatalf("event should be oom, not %#v", oomEvent)
|
|
| 99 |
- } |
|
| 100 |
- if dieEvent[len(dieEvent)-1] != "die" {
|
|
| 101 |
- c.Fatalf("event should be die, not %#v", dieEvent)
|
|
| 102 |
- } |
|
| 86 |
+ c.Assert(createEvent[len(createEvent)-1], checker.Equals, "create", check.Commentf("event should be create, not %#v", createEvent))
|
|
| 87 |
+ c.Assert(attachEvent[len(attachEvent)-1], checker.Equals, "attach", check.Commentf("event should be attach, not %#v", attachEvent))
|
|
| 88 |
+ c.Assert(startEvent[len(startEvent)-1], checker.Equals, "start", check.Commentf("event should be start, not %#v", startEvent))
|
|
| 89 |
+ c.Assert(oomEvent[len(oomEvent)-1], checker.Equals, "oom", check.Commentf("event should be oom, not %#v", oomEvent))
|
|
| 90 |
+ c.Assert(dieEvent[len(dieEvent)-1], checker.Equals, "die", check.Commentf("event should be die, not %#v", dieEvent))
|
|
| 103 | 91 |
} |
| 104 | 92 |
|
| 105 | 93 |
func (s *DockerSuite) TestEventsOOMDisableTrue(c *check.C) {
|
| ... | ... |
@@ -117,37 +96,25 @@ func (s *DockerSuite) TestEventsOOMDisableTrue(c *check.C) {
|
| 117 | 117 |
}() |
| 118 | 118 |
select {
|
| 119 | 119 |
case err := <-errChan: |
| 120 |
- c.Assert(err, check.IsNil) |
|
| 120 |
+ c.Assert(err, checker.IsNil) |
|
| 121 | 121 |
case <-time.After(20 * time.Second): |
| 122 | 122 |
defer dockerCmd(c, "kill", "oomTrue") |
| 123 | 123 |
|
| 124 | 124 |
out, _ := dockerCmd(c, "events", "--since=0", "-f", "container=oomTrue", fmt.Sprintf("--until=%d", daemonTime(c).Unix()))
|
| 125 | 125 |
events := strings.Split(strings.TrimSuffix(out, "\n"), "\n") |
| 126 |
- if len(events) < 4 {
|
|
| 127 |
- c.Fatalf("Missing expected event")
|
|
| 128 |
- } |
|
| 126 |
+ c.Assert(len(events), checker.GreaterOrEqualThan, 4) //Missing expected event |
|
| 129 | 127 |
|
| 130 | 128 |
createEvent := strings.Fields(events[len(events)-4]) |
| 131 | 129 |
attachEvent := strings.Fields(events[len(events)-3]) |
| 132 | 130 |
startEvent := strings.Fields(events[len(events)-2]) |
| 133 | 131 |
oomEvent := strings.Fields(events[len(events)-1]) |
| 134 | 132 |
|
| 135 |
- if createEvent[len(createEvent)-1] != "create" {
|
|
| 136 |
- c.Fatalf("event should be create, not %#v", createEvent)
|
|
| 137 |
- } |
|
| 138 |
- if attachEvent[len(attachEvent)-1] != "attach" {
|
|
| 139 |
- c.Fatalf("event should be attach, not %#v", attachEvent)
|
|
| 140 |
- } |
|
| 141 |
- if startEvent[len(startEvent)-1] != "start" {
|
|
| 142 |
- c.Fatalf("event should be start, not %#v", startEvent)
|
|
| 143 |
- } |
|
| 144 |
- if oomEvent[len(oomEvent)-1] != "oom" {
|
|
| 145 |
- c.Fatalf("event should be oom, not %#v", oomEvent)
|
|
| 146 |
- } |
|
| 133 |
+ c.Assert(createEvent[len(createEvent)-1], checker.Equals, "create", check.Commentf("event should be create, not %#v", createEvent))
|
|
| 134 |
+ c.Assert(attachEvent[len(attachEvent)-1], checker.Equals, "attach", check.Commentf("event should be attach, not %#v", attachEvent))
|
|
| 135 |
+ c.Assert(startEvent[len(startEvent)-1], checker.Equals, "start", check.Commentf("event should be start, not %#v", startEvent))
|
|
| 136 |
+ c.Assert(oomEvent[len(oomEvent)-1], checker.Equals, "oom", check.Commentf("event should be oom, not %#v", oomEvent))
|
|
| 147 | 137 |
|
| 148 | 138 |
out, _ = dockerCmd(c, "inspect", "-f", "{{.State.Status}}", "oomTrue")
|
| 149 |
- if strings.TrimSpace(out) != "running" {
|
|
| 150 |
- c.Fatalf("container should be still running, not %v", out)
|
|
| 151 |
- } |
|
| 139 |
+ c.Assert(strings.TrimSpace(out), checker.Equals, "running", check.Commentf("container should be still running"))
|
|
| 152 | 140 |
} |
| 153 | 141 |
} |