Browse code

Remove test-integration-cli and references to it.

Signed-off-by: Daniel Nephin <dnephin@docker.com>

Daniel Nephin authored on 2017/06/17 09:18:44
Showing 15 changed files
... ...
@@ -9,7 +9,7 @@
9 9
 # docker run -v `pwd`:/go/src/github.com/docker/docker --privileged -i -t docker bash
10 10
 #
11 11
 # # Run the test suite:
12
-# docker run -e DOCKER_GITCOMMIT=foo --privileged docker hack/make.sh test-unit test-integration-cli test-docker-py
12
+# docker run -e DOCKER_GITCOMMIT=foo --privileged docker hack/make.sh test-unit test-integration test-docker-py
13 13
 #
14 14
 # # Publish a release:
15 15
 # docker run --privileged \
... ...
@@ -9,7 +9,7 @@
9 9
 # docker run -v `pwd`:/go/src/github.com/docker/docker --privileged -i -t docker bash
10 10
 #
11 11
 # # Run the test suite:
12
-# docker run --privileged docker hack/make.sh test-unit test-integration-cli test-docker-py
12
+# docker run --privileged docker hack/make.sh test-unit test-integration test-docker-py
13 13
 #
14 14
 # Note: AppArmor used to mess with privileged mode, but this is no longer
15 15
 # the case. Therefore, you don't have to disable it anymore.
... ...
@@ -9,7 +9,7 @@
9 9
 # docker run -v `pwd`:/go/src/github.com/docker/docker --privileged -i -t docker bash
10 10
 #
11 11
 # # Run the test suite:
12
-# docker run --privileged docker hack/make.sh test-unit test-integration-cli test-docker-py
12
+# docker run --privileged docker hack/make.sh test-unit test-integration test-docker-py
13 13
 #
14 14
 # Note: AppArmor used to mess with privileged mode, but this is no longer
15 15
 # the case. Therefore, you don't have to disable it anymore.
... ...
@@ -9,7 +9,7 @@
9 9
 # docker run -v `pwd`:/go/src/github.com/docker/docker --privileged -i -t docker bash
10 10
 #
11 11
 # # Run the test suite:
12
-# docker run --privileged docker hack/make.sh test-unit test-integration-cli test-docker-py
12
+# docker run --privileged docker hack/make.sh test-unit test-integration test-docker-py
13 13
 #
14 14
 # Note: AppArmor used to mess with privileged mode, but this is no longer
15 15
 # the case. Therefore, you don't have to disable it anymore.
... ...
@@ -9,7 +9,7 @@
9 9
 # docker run -v `pwd`:/go/src/github.com/docker/docker --privileged -i -t docker bash
10 10
 #
11 11
 # # Run the test suite:
12
-# docker run --privileged docker hack/make.sh test-unit test-integration-cli test-docker-py
12
+# docker run --privileged docker hack/make.sh test-unit test-integration test-docker-py
13 13
 #
14 14
 # Note: AppArmor used to mess with privileged mode, but this is no longer
15 15
 # the case. Therefore, you don't have to disable it anymore.
... ...
@@ -1,7 +1,7 @@
1 1
 # docker build -t docker:simple -f Dockerfile.simple .
2 2
 # docker run --rm docker:simple hack/make.sh dynbinary
3 3
 # docker run --rm --privileged docker:simple hack/dind hack/make.sh test-unit
4
-# docker run --rm --privileged -v /var/lib/docker docker:simple hack/dind hack/make.sh dynbinary test-integration-cli
4
+# docker run --rm --privileged -v /var/lib/docker docker:simple hack/dind hack/make.sh dynbinary test-integration
5 5
 
6 6
 # This represents the bare minimum required to build and test Docker.
7 7
 
... ...
@@ -1,4 +1,4 @@
1
-.PHONY: all binary dynbinary build cross deb help init-go-pkg-cache install manpages rpm run shell test test-docker-py test-integration-cli test-unit tgz validate win
1
+.PHONY: all binary dynbinary build cross deb help init-go-pkg-cache install manpages rpm run shell test test-docker-py test-integration test-unit tgz validate win
2 2
 
3 3
 # set the graph driver as the current graphdriver if not set
4 4
 DOCKER_GRAPHDRIVER := $(if $(DOCKER_GRAPHDRIVER),$(DOCKER_GRAPHDRIVER),$(shell docker info 2>&1 | grep "Storage Driver" | sed 's/.*: //'))
... ...
@@ -149,13 +149,12 @@ shell: build ## start a shell inside the build env
149 149
 	$(DOCKER_RUN_DOCKER) bash
150 150
 
151 151
 test: build ## run the unit, integration and docker-py tests
152
-	$(DOCKER_RUN_DOCKER) hack/make.sh dynbinary cross test-unit test-integration-cli test-docker-py
152
+	$(DOCKER_RUN_DOCKER) hack/make.sh dynbinary cross test-unit test-integration test-docker-py
153 153
 
154 154
 test-docker-py: build ## run the docker-py tests
155 155
 	$(DOCKER_RUN_DOCKER) hack/make.sh dynbinary test-docker-py
156 156
 
157
-test-integration-cli: build ## (DEPRECATED) use test-integration
158
-	$(DOCKER_RUN_DOCKER) hack/make.sh build-integration-test-cli-binary dynbinary test-integration
157
+test-integration-cli: test-integration ## (DEPRECATED) use test-integration
159 158
 
160 159
 test-integration: build ## run the integration tests
161 160
 	$(DOCKER_RUN_DOCKER) hack/make.sh dynbinary test-integration
... ...
@@ -37,14 +37,14 @@ More information is found within `make.ps1` by the author, @jhowardmsft
37 37
 - Referenced via `make test` when running tests on a local machine,
38 38
 or directly referenced when running tests inside a Docker development container.  
39 39
 - When running on a local machine, `make test` to run all tests found in
40
-`test`, `test-unit`, `test-integration-cli`, and `test-docker-py` on
40
+`test`, `test-unit`, `test-integration`, and `test-docker-py` on
41 41
 your local machine. The default timeout is set in `make.sh` to 60 minutes
42 42
 (`${TIMEOUT:=60m}`), since it currently takes up to an hour to run
43 43
 all of the tests.
44 44
 - When running inside a Docker development container, `hack/make.sh` does
45 45
 not have a single target that runs all the tests. You need to provide a
46 46
 single command line with multiple targets that performs the same thing.
47
-An example referenced from [Run targets inside a development container](https://docs.docker.com/opensource/project/test-and-docs/#run-targets-inside-a-development-container): `root@5f8630b873fe:/go/src/github.com/moby/moby# hack/make.sh dynbinary binary cross test-unit test-integration-cli test-docker-py`
47
+An example referenced from [Run targets inside a development container](https://docs.docker.com/opensource/project/test-and-docs/#run-targets-inside-a-development-container): `root@5f8630b873fe:/go/src/github.com/moby/moby# hack/make.sh dynbinary binary cross test-unit test-integration test-docker-py`
48 48
 - For more information related to testing outside the scope of this README,
49 49
 refer to
50 50
 [Run tests and test documentation](https://docs.docker.com/opensource/project/test-and-docs/)
... ...
@@ -61,7 +61,6 @@ DEFAULT_BUNDLES=(
61 61
 
62 62
 	test-unit
63 63
 	test-integration
64
-	test-integration-cli
65 64
 	test-docker-py
66 65
 
67 66
 	cross
... ...
@@ -1,6 +1,6 @@
1 1
 #!/usr/bin/env bash
2 2
 
3
-# see test-integration-cli for example usage of this script
3
+# see test-integration for example usage of this script
4 4
 
5 5
 base="$ABS_DEST/.."
6 6
 export PATH="$base/binary-daemon:$base/dynbinary-daemon:$PATH"
... ...
@@ -2,7 +2,7 @@
2 2
 set -e
3 3
 
4 4
 rm -rf "$DEST"
5
-DEST="$ABS_DEST/../test-integration-cli"
5
+DEST="$ABS_DEST/../test-integration"
6 6
 
7 7
 source "$SCRIPTDIR/make/.go-autogen"
8 8
 
... ...
@@ -1,10 +1,13 @@
1 1
 #!/usr/bin/env bash
2 2
 set -e
3 3
 
4
+source "${MAKEDIR}/.go-autogen"
4 5
 source hack/make/.integration-test-helpers
5 6
 
6 7
 # subshell so that we can export PATH without breaking other things
7 8
 (
9
+	bundle build-integration-cli-test-binary
10
+
8 11
 	bundle .integration-daemon-start
9 12
 
10 13
 	bundle .integration-daemon-setup
... ...
@@ -15,7 +18,7 @@ source hack/make/.integration-test-helpers
15 15
 
16 16
 	if [ "$(go env GOOS)" != 'windows' ]
17 17
 	then
18
-		leftovers=$(ps -ax -o pid,cmd | awk '$2 == "docker-containerd-shim" && $4 ~ /.*\/bundles\/.*\/test-integration-cli/ { print $1 }')
18
+		leftovers=$(ps -ax -o pid,cmd | awk '$2 == "docker-containerd-shim" && $4 ~ /.*\/bundles\/.*\/test-integration/ { print $1 }')
19 19
 		if [ -n "$leftovers" ]
20 20
 		then
21 21
 			ps aux
... ...
@@ -1,29 +1,4 @@
1 1
 #!/usr/bin/env bash
2 2
 set -e
3
-
4
-source "${MAKEDIR}/.go-autogen"
5
-source hack/make/.integration-test-helpers
6
-
7
-# subshell so that we can export PATH without breaking other things
8
-(
9
-	bundle .integration-daemon-start
10
-
11
-	bundle .integration-daemon-setup
12
-
13
-	bundle_test_integration_cli
14
-
15
-	bundle .integration-daemon-stop
16
-
17
-	if [ "$(go env GOOS)" != 'windows' ]
18
-	then
19
-		leftovers=$(ps -ax -o pid,cmd | awk '$2 == "docker-containerd-shim" && $4 ~ /.*\/bundles\/.*\/test-integration-cli/ { print $1 }')
20
-		if [ -n "$leftovers" ]
21
-		then
22
-			ps aux
23
-			kill -9 $leftovers 2> /dev/null
24
-			echo "!!!! WARNING you have left over shim(s), Cleanup your test !!!!"
25
-			exit 1
26
-		fi
27
-	fi
28
-
29
-) 2>&1 | tee -a "$DEST/test.log"
3
+echo "WARNING: test-integration-cli is DEREPCATED. Use test-integration." >&2
4
+exit 1
... ...
@@ -57,7 +57,7 @@ if [ "$1" != '--release-regardless-of-test-failure' ]; then
57 57
 	RELEASE_BUNDLES=(
58 58
 		test-unit
59 59
 		"${RELEASE_BUNDLES[@]}"
60
-		test-integration-cli
60
+		test-integration
61 61
 	)
62 62
 fi
63 63
 
... ...
@@ -17,7 +17,7 @@ From the root of the Docker/Docker repo one can use make to execute the followin
17 17
 - make default
18 18
 - make shell
19 19
 - make test-unit
20
-- make test-integration-cli
20
+- make test-integration
21 21
 - make
22 22
 
23 23
 The Makefile does include logic to determine on which OS and architecture the Docker Development Image is built.