Browse code

Merge pull request #36021 from yongtang/30897-follow-up

Rename FindUniqueNetwork to FindNetwork

Vincent Demeester authored on 2018/01/16 17:38:16
Showing 10 changed files
... ...
@@ -12,7 +12,7 @@ import (
12 12
 // Backend is all the methods that need to be implemented
13 13
 // to provide network specific functionality.
14 14
 type Backend interface {
15
-	FindUniqueNetwork(idName string) (libnetwork.Network, error)
15
+	FindNetwork(idName string) (libnetwork.Network, error)
16 16
 	GetNetworks() []libnetwork.Network
17 17
 	CreateNetwork(nc types.NetworkCreateRequest) (*types.NetworkCreateResponse, error)
18 18
 	ConnectContainerToNetwork(containerName, networkName string, endpointConfig *network.EndpointSettings) error
... ...
@@ -276,7 +276,7 @@ func (n *networkRouter) postNetworkConnect(ctx context.Context, w http.ResponseW
276 276
 	}
277 277
 
278 278
 	// Always make sure there is no ambiguity with respect to the network ID/name
279
-	nw, err := n.backend.FindUniqueNetwork(vars["id"])
279
+	nw, err := n.backend.FindNetwork(vars["id"])
280 280
 	if err != nil {
281 281
 		return err
282 282
 	}
... ...
@@ -516,7 +516,7 @@ func (n *networkRouter) postNetworksPrune(ctx context.Context, w http.ResponseWr
516 516
 }
517 517
 
518 518
 // findUniqueNetwork will search network across different scopes (both local and swarm).
519
-// NOTE: This findUniqueNetwork is different from FindUniqueNetwork in the daemon.
519
+// NOTE: This findUniqueNetwork is different from FindNetwork in the daemon.
520 520
 // In case multiple networks have duplicate names, return error.
521 521
 // First find based on full ID, return immediately once one is found.
522 522
 // If a network appears both in swarm and local, assume it is in local first
... ...
@@ -28,7 +28,7 @@ import (
28 28
 type Backend interface {
29 29
 	CreateManagedNetwork(clustertypes.NetworkCreateRequest) error
30 30
 	DeleteManagedNetwork(networkID string) error
31
-	FindUniqueNetwork(idName string) (libnetwork.Network, error)
31
+	FindNetwork(idName string) (libnetwork.Network, error)
32 32
 	SetupIngress(clustertypes.NetworkCreateRequest, string) (<-chan struct{}, error)
33 33
 	ReleaseIngress() (<-chan struct{}, error)
34 34
 	PullImage(ctx context.Context, image, tag, platform string, metaHeaders map[string][]string, authConfig *types.AuthConfig, outStream io.Writer) error
... ...
@@ -507,7 +507,7 @@ func getEndpointConfig(na *api.NetworkAttachment, b executorpkg.Backend) *networ
507 507
 		DriverOpts: na.DriverAttachmentOpts,
508 508
 	}
509 509
 	if v, ok := na.Network.Spec.Annotations.Labels["com.docker.swarm.predefined"]; ok && v == "true" {
510
-		if ln, err := b.FindUniqueNetwork(na.Network.Spec.Annotations.Name); err == nil {
510
+		if ln, err := b.FindNetwork(na.Network.Spec.Annotations.Name); err == nil {
511 511
 			n.NetworkID = ln.ID()
512 512
 		}
513 513
 	}
... ...
@@ -293,7 +293,7 @@ func (c *Cluster) populateNetworkID(ctx context.Context, client swarmapi.Control
293 293
 	for i, n := range networks {
294 294
 		apiNetwork, err := getNetwork(ctx, client, n.Target)
295 295
 		if err != nil {
296
-			ln, _ := c.config.Backend.FindUniqueNetwork(n.Target)
296
+			ln, _ := c.config.Backend.FindNetwork(n.Target)
297 297
 			if ln != nil && runconfig.IsPreDefinedNetwork(ln.Name()) {
298 298
 				// Need to retrieve the corresponding predefined swarm network
299 299
 				// and use its id for the request.
... ...
@@ -253,7 +253,7 @@ func (daemon *Daemon) updateNetworkSettings(container *container.Container, n li
253 253
 	}
254 254
 
255 255
 	for s, v := range container.NetworkSettings.Networks {
256
-		sn, err := daemon.FindUniqueNetwork(getNetworkID(s, v.EndpointSettings))
256
+		sn, err := daemon.FindNetwork(getNetworkID(s, v.EndpointSettings))
257 257
 		if err != nil {
258 258
 			continue
259 259
 		}
... ...
@@ -310,7 +310,7 @@ func (daemon *Daemon) updateNetwork(container *container.Container) error {
310 310
 	// Find if container is connected to the default bridge network
311 311
 	var n libnetwork.Network
312 312
 	for name, v := range container.NetworkSettings.Networks {
313
-		sn, err := daemon.FindUniqueNetwork(getNetworkID(name, v.EndpointSettings))
313
+		sn, err := daemon.FindNetwork(getNetworkID(name, v.EndpointSettings))
314 314
 		if err != nil {
315 315
 			continue
316 316
 		}
... ...
@@ -340,7 +340,7 @@ func (daemon *Daemon) updateNetwork(container *container.Container) error {
340 340
 }
341 341
 
342 342
 func (daemon *Daemon) findAndAttachNetwork(container *container.Container, idOrName string, epConfig *networktypes.EndpointSettings) (libnetwork.Network, *networktypes.NetworkingConfig, error) {
343
-	n, err := daemon.FindUniqueNetwork(getNetworkID(idOrName, epConfig))
343
+	n, err := daemon.FindNetwork(getNetworkID(idOrName, epConfig))
344 344
 	if err != nil {
345 345
 		// We should always be able to find the network for a
346 346
 		// managed container.
... ...
@@ -384,7 +384,7 @@ func (daemon *Daemon) findAndAttachNetwork(container *container.Container, idOrN
384 384
 			}
385 385
 		}
386 386
 
387
-		n, err = daemon.FindUniqueNetwork(getNetworkID(idOrName, epConfig))
387
+		n, err = daemon.FindNetwork(getNetworkID(idOrName, epConfig))
388 388
 		if err != nil {
389 389
 			if daemon.clusterProvider != nil {
390 390
 				if err := daemon.clusterProvider.DetachNetwork(getNetworkID(idOrName, epConfig), container.ID); err != nil {
... ...
@@ -438,7 +438,7 @@ func (daemon *Daemon) updateContainerNetworkSettings(container *container.Contai
438 438
 	if mode.IsUserDefined() {
439 439
 		var err error
440 440
 
441
-		n, err = daemon.FindUniqueNetwork(networkName)
441
+		n, err = daemon.FindNetwork(networkName)
442 442
 		if err == nil {
443 443
 			networkName = n.Name()
444 444
 		}
... ...
@@ -798,7 +798,7 @@ func (daemon *Daemon) connectToNetwork(container *container.Container, idOrName
798 798
 
799 799
 // ForceEndpointDelete deletes an endpoint from a network forcefully
800 800
 func (daemon *Daemon) ForceEndpointDelete(name string, networkName string) error {
801
-	n, err := daemon.FindUniqueNetwork(networkName)
801
+	n, err := daemon.FindNetwork(networkName)
802 802
 	if err != nil {
803 803
 		return err
804 804
 	}
... ...
@@ -950,7 +950,7 @@ func (daemon *Daemon) releaseNetwork(container *container.Container) {
950 950
 
951 951
 	var networks []libnetwork.Network
952 952
 	for n, epSettings := range settings {
953
-		if nw, err := daemon.FindUniqueNetwork(getNetworkID(n, epSettings.EndpointSettings)); err == nil {
953
+		if nw, err := daemon.FindNetwork(getNetworkID(n, epSettings.EndpointSettings)); err == nil {
954 954
 			networks = append(networks, nw)
955 955
 		}
956 956
 
... ...
@@ -994,7 +994,7 @@ func (daemon *Daemon) ConnectToNetwork(container *container.Container, idOrName
994 994
 			return errRemovalContainer(container.ID)
995 995
 		}
996 996
 
997
-		n, err := daemon.FindUniqueNetwork(idOrName)
997
+		n, err := daemon.FindNetwork(idOrName)
998 998
 		if err == nil && n != nil {
999 999
 			if err := daemon.updateNetworkConfig(container, n, endpointConfig, true); err != nil {
1000 1000
 				return err
... ...
@@ -1017,7 +1017,7 @@ func (daemon *Daemon) ConnectToNetwork(container *container.Container, idOrName
1017 1017
 
1018 1018
 // DisconnectFromNetwork disconnects container from network n.
1019 1019
 func (daemon *Daemon) DisconnectFromNetwork(container *container.Container, networkName string, force bool) error {
1020
-	n, err := daemon.FindUniqueNetwork(networkName)
1020
+	n, err := daemon.FindNetwork(networkName)
1021 1021
 	container.Lock()
1022 1022
 	defer container.Unlock()
1023 1023
 
... ...
@@ -170,7 +170,7 @@ func (daemon *Daemon) initializeNetworkingPaths(container *container.Container,
170 170
 
171 171
 	if nc.NetworkSettings != nil {
172 172
 		for n := range nc.NetworkSettings.Networks {
173
-			sn, err := daemon.FindUniqueNetwork(n)
173
+			sn, err := daemon.FindNetwork(n)
174 174
 			if err != nil {
175 175
 				continue
176 176
 			}
... ...
@@ -317,7 +317,7 @@ func TestValidateContainerIsolation(t *testing.T) {
317 317
 
318 318
 func TestFindNetworkErrorType(t *testing.T) {
319 319
 	d := Daemon{}
320
-	_, err := d.FindUniqueNetwork("fakeNet")
320
+	_, err := d.FindNetwork("fakeNet")
321 321
 	_, ok := errors.Cause(err).(libnetwork.ErrNoSuchNetwork)
322 322
 	if !errdefs.IsNotFound(err) || !ok {
323 323
 		assert.Fail(t, "The FindNetwork method MUST always return an error that implements the NotFound interface and is ErrNoSuchNetwork")
... ...
@@ -30,12 +30,12 @@ func (daemon *Daemon) NetworkControllerEnabled() bool {
30 30
 	return daemon.netController != nil
31 31
 }
32 32
 
33
-// FindUniqueNetwork returns a network based on:
33
+// FindNetwork returns a network based on:
34 34
 // 1. Full ID
35 35
 // 2. Full Name
36 36
 // 3. Partial ID
37 37
 // as long as there is no ambiguity
38
-func (daemon *Daemon) FindUniqueNetwork(term string) (libnetwork.Network, error) {
38
+func (daemon *Daemon) FindNetwork(term string) (libnetwork.Network, error) {
39 39
 	listByFullName := []libnetwork.Network{}
40 40
 	listByPartialID := []libnetwork.Network{}
41 41
 	for _, nw := range daemon.GetNetworks() {
... ...
@@ -159,7 +159,7 @@ func (daemon *Daemon) createSpec(c *container.Container) (*specs.Spec, error) {
159 159
 	gwHNSID := ""
160 160
 	if c.NetworkSettings != nil {
161 161
 		for n := range c.NetworkSettings.Networks {
162
-			sn, err := daemon.FindUniqueNetwork(n)
162
+			sn, err := daemon.FindNetwork(n)
163 163
 			if err != nil {
164 164
 				continue
165 165
 			}