Browse code
Skip TestPullAllTagsFromCentralRegistry
The image that this test pulls contains an error in the linux/amd64
manifest description, the reported size is 424 but the actual size is
524, making this test fail with containerd.
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Djordje Lukic authored on 2023/10/12 22:47:48Showing 1 changed files
| ... | ... |
@@ -10,6 +10,7 @@ import ( |
| 10 | 10 |
"github.com/opencontainers/go-digest" |
| 11 | 11 |
"gotest.tools/v3/assert" |
| 12 | 12 |
is "gotest.tools/v3/assert/cmp" |
| 13 |
+ "gotest.tools/v3/skip" |
|
| 13 | 14 |
) |
| 14 | 15 |
|
| 15 | 16 |
type DockerCLIPullSuite struct {
|
| ... | ... |
@@ -133,6 +134,8 @@ func (s *DockerHubPullSuite) TestPullScratchNotAllowed(c *testing.T) {
|
| 133 | 133 |
// TestPullAllTagsFromCentralRegistry pulls using `all-tags` for a given image and verifies that it |
| 134 | 134 |
// results in more images than a naked pull. |
| 135 | 135 |
func (s *DockerHubPullSuite) TestPullAllTagsFromCentralRegistry(c *testing.T) {
|
| 136 |
+ // See https://github.com/moby/moby/issues/46632 |
|
| 137 |
+ skip.If(c, testEnv.UsingSnapshotter, "The image dockercore/engine-pull-all-test-fixture is a hand-made image that contains an error in the manifest, the size is reported as 424 but its real size is 524, containerd fails to pull it because it checks that the sizes reported are right") |
|
| 136 | 138 |
testRequires(c, DaemonIsLinux) |
| 137 | 139 |
s.Cmd(c, "pull", "dockercore/engine-pull-all-test-fixture") |
| 138 | 140 |
outImageCmd := s.Cmd(c, "images", "dockercore/engine-pull-all-test-fixture") |