Browse code

Improve error message when refusing to remove image due to multiple repo tags

Danny Yates authored on 2013/12/17 21:31:35
Showing 2 changed files
... ...
@@ -952,7 +952,7 @@ image is removed.
952 952
     test2                     latest              fd484f19954f        23 seconds ago      7 B (virtual 4.964 MB)
953 953
 
954 954
     $ sudo docker rmi fd484f19954f
955
-    Error: Conflict, fd484f19954f wasn't deleted
955
+    Error: Conflict, cannot delete image fd484f19954f because it is tagged in multiple repositories
956 956
     2013/12/11 05:47:16 Error: failed to remove one or more images
957 957
 
958 958
     $ sudo docker rmi test1
... ...
@@ -1567,7 +1567,7 @@ func (srv *Server) deleteImage(img *Image, repoName, tag string) ([]APIRmi, erro
1567 1567
 			} else if repoName != parsedRepo {
1568 1568
 				// the id belongs to multiple repos, like base:latest and user:test,
1569 1569
 				// in that case return conflict
1570
-				return imgs, nil
1570
+				return nil, fmt.Errorf("Conflict, cannot delete image %s because it is tagged in multiple repositories", utils.TruncateID(img.ID))
1571 1571
 			}
1572 1572
 		}
1573 1573
 	} else {