GitList

Browse code

integration-cli: check that docker port command output is not empty

Or else we can violate array range boundaries in:
out = strings.Split(out, ":")[1]
and get runtime error.

We got this runtime error when run TestRunPortFromDockerRangeInUse
Somehow docker goes silently if it cannot publish port because
of no bridge.

Signed-off-by: Pavel Tikhomirov <ptikhomirov@parallels.com>

Pavel Tikhomirov authored on 2015/02/17 19:15:51
Showing 1 changed files

integration-cli/docker_cli_run_test.go index 491acad..6e759ee 100644

integration-cli/docker_cli_run_test.go

History View file @ cad770f

@@ -2921,6 +2921,10 @@ func TestRunPortFromDockerRangeInUse(t *testing.T) {
                      		t.Fatal(out, err)
+                     	}
                      	out = strings.TrimSpace(out)
+                    +
                     +	if out == "" {
                     +		t.Fatal("docker port command output is empty")
                     +	}
                      	out = strings.Split(out, ":")[1]
                      	lastPort, err := strconv.Atoi(out)
                      	if err != nil {