1. docker
  2. Commit cae3ccd34b4e834c6f958bfc7503e74065ee61c6
Browse code

client/config_create: use gotest.tools-style asserts

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>

Paweł Gronowski authored on 2025/05/17 02:14:29
Showing 5 changed files
client/config_create_test.go
History View file @ cae3ccd
... ... 
@@ -60,10 +60,6 @@ func TestConfigCreate(t *testing.T) {
60 60 
 	}
61 61
62 62 
 	r, err := client.ConfigCreate(context.Background(), swarm.ConfigSpec{})
63 
-	if err != nil {
64 
-		t.Fatal(err)
65 
-	}
66 
-	if r.ID != "test_config" {
67 
-		t.Fatalf("expected `test_config`, got %s", r.ID)
68 
-	}
63 
+	assert.NilError(t, err)
64 
+	assert.Check(t, is.Equal(r.ID, "test_config"))
69 65 
 }
client/config_inspect_test.go
History View file @ cae3ccd
... ... 
@@ -92,10 +92,6 @@ func TestConfigInspect(t *testing.T) {
92 92 
 	}
93 93
94 94 
 	configInspect, _, err := client.ConfigInspectWithRaw(context.Background(), "config_id")
95 
-	if err != nil {
96 
-		t.Fatal(err)
97 
-	}
98 
-	if configInspect.ID != "config_id" {
99 
-		t.Fatalf("expected `config_id`, got %s", configInspect.ID)
100 
-	}
95 
+	assert.NilError(t, err)
96 
+	assert.Check(t, is.Equal(configInspect.ID, "config_id"))
101 97 
 }
client/config_list_test.go
History View file @ cae3ccd
... ... 
@@ -95,11 +95,7 @@ func TestConfigList(t *testing.T) {
95 95 
 		}
96 96
97 97 
 		configs, err := client.ConfigList(context.Background(), listCase.options)
98 
-		if err != nil {
99 
-			t.Fatal(err)
100 
-		}
101 
-		if len(configs) != 2 {
102 
-			t.Fatalf("expected 2 configs, got %v", configs)
103 
-		}
98 
+		assert.NilError(t, err)
99 
+		assert.Check(t, is.Len(configs, 2))
104 100 
 	}
105 101 
 }
client/config_remove_test.go
History View file @ cae3ccd
... ... 
@@ -61,7 +61,5 @@ func TestConfigRemove(t *testing.T) {
61 61 
 	}
62 62
63 63 
 	err := client.ConfigRemove(context.Background(), "config_id")
64 
-	if err != nil {
65 
-		t.Fatal(err)
66 
-	}
64 
+	assert.NilError(t, err)
67 65 
 }
client/config_update_test.go
History View file @ cae3ccd
... ... 
@@ -62,7 +62,5 @@ func TestConfigUpdate(t *testing.T) {
62 62 
 	}
63 63
64 64 
 	err := client.ConfigUpdate(context.Background(), "config_id", swarm.Version{}, swarm.ConfigSpec{})
65 
-	if err != nil {
66 
-		t.Fatal(err)
67 
-	}
65 
+	assert.NilError(t, err)
68 66 
 }