Browse code

Windows: Fix old TP5 volume unit tests

Signed-off-by: John Howard <jhoward@microsoft.com>

John Howard authored on 2017/01/05 09:17:55
Showing 1 changed files
... ...
@@ -22,7 +22,6 @@ func TestParseMountRaw(t *testing.T) {
22 22
 			`d:`,
23 23
 			`d:\path`,
24 24
 			`d:\path with space`,
25
-			// TODO Windows post TP5 - readonly support `d:\pathandmode:ro`,
26 25
 			`c:\:d:\`,
27 26
 			`c:\windows\:d:`,
28 27
 			`c:\windows:d:\s p a c e`,
... ...
@@ -33,9 +32,9 @@ func TestParseMountRaw(t *testing.T) {
33 33
 			`name:D:`,
34 34
 			`name:D::rW`,
35 35
 			`name:D::RW`,
36
-			// TODO Windows post TP5 - readonly support `name:D::RO`,
36
+			`name:D::RO`,
37 37
 			`c:/:d:/forward/slashes/are/good/too`,
38
-			// TODO Windows post TP5 - readonly support `c:/:d:/including with/spaces:ro`,
38
+			`c:/:d:/including with/spaces:ro`,
39 39
 			`c:\Windows`,             // With capital
40 40
 			`c:\Program Files (x86)`, // With capitals and brackets
41 41
 		}
... ...
@@ -59,6 +58,7 @@ func TestParseMountRaw(t *testing.T) {
59 59
 			`name?:d:`:                         `invalid volume specification`,
60 60
 			`name/:d:`:                         `invalid volume specification`,
61 61
 			`d:\pathandmode:rw`:                `invalid volume specification`,
62
+			`d:\pathandmode:ro`:                `invalid volume specification`,
62 63
 			`con:d:`:                           `cannot be a reserved word for Windows filenames`,
63 64
 			`PRN:d:`:                           `cannot be a reserved word for Windows filenames`,
64 65
 			`aUx:d:`:                           `cannot be a reserved word for Windows filenames`,
... ...
@@ -157,12 +157,12 @@ func TestParseMountRawSplit(t *testing.T) {
157 157
 		cases = []testParseMountRaw{
158 158
 			{`c:\:d:`, "local", `d:`, `c:\`, ``, "", true, false},
159 159
 			{`c:\:d:\`, "local", `d:\`, `c:\`, ``, "", true, false},
160
-			// TODO Windows post TP5 - Add readonly support {`c:\:d:\:ro`, "local", `d:\`, `c:\`, ``, "", false, false},
160
+			{`c:\:d:\:ro`, "local", `d:\`, `c:\`, ``, "", false, false},
161 161
 			{`c:\:d:\:rw`, "local", `d:\`, `c:\`, ``, "", true, false},
162 162
 			{`c:\:d:\:foo`, "local", `d:\`, `c:\`, ``, "", false, true},
163 163
 			{`name:d::rw`, "local", `d:`, ``, `name`, "local", true, false},
164 164
 			{`name:d:`, "local", `d:`, ``, `name`, "local", true, false},
165
-			// TODO Windows post TP5 - Add readonly support {`name:d::ro`, "local", `d:`, ``, `name`, "local", false, false},
165
+			{`name:d::ro`, "local", `d:`, ``, `name`, "local", false, false},
166 166
 			{`name:c:`, "", ``, ``, ``, "", true, true},
167 167
 			{`driver/name:c:`, "", ``, ``, ``, "", true, true},
168 168
 		}