Signed-off-by: Tibor Vass <tibor@docker.com>
Tibor Vass authored on 2016/06/07 07:57:51... | ... |
@@ -88,7 +88,7 @@ func NewPusher(ref reference.Named, endpoint registry.APIEndpoint, repoInfo *reg |
88 | 88 |
return nil, fmt.Errorf("unknown version %d for registry %s", endpoint.Version, endpoint.URL) |
89 | 89 |
} |
90 | 90 |
|
91 |
-// Push initiates a push operation on the repository named localName. |
|
91 |
+// Push initiates a push operation on ref. |
|
92 | 92 |
// ref is the specific variant of the image to be pushed. |
93 | 93 |
// If no tag is provided, all tags will be pushed. |
94 | 94 |
func Push(ctx context.Context, ref reference.Named, imagePushConfig *ImagePushConfig) error { |
... | ... |
@@ -5,14 +5,6 @@ import ( |
5 | 5 |
"testing" |
6 | 6 |
) |
7 | 7 |
|
8 |
-// Make sure the generated names are awesome |
|
9 |
-func TestGenerateAwesomeNames(t *testing.T) { |
|
10 |
- name := GetRandomName(0) |
|
11 |
- if !isAwesome(name) { |
|
12 |
- t.Fatalf("Generated name '%s' is not awesome.", name) |
|
13 |
- } |
|
14 |
-} |
|
15 |
- |
|
16 | 8 |
func TestNameFormat(t *testing.T) { |
17 | 9 |
name := GetRandomName(0) |
18 | 10 |
if !strings.Contains(name, "_") { |
... | ... |
@@ -33,13 +25,3 @@ func TestNameRetries(t *testing.T) { |
33 | 33 |
} |
34 | 34 |
|
35 | 35 |
} |
36 |
- |
|
37 |
-// To be awesome, a container name must involve cool inventors, be easy to remember, |
|
38 |
-// be at least mildly funny, and always be politically correct for enterprise adoption. |
|
39 |
-func isAwesome(name string) bool { |
|
40 |
- coolInventorNames := true |
|
41 |
- easyToRemember := true |
|
42 |
- mildlyFunnyOnOccasion := true |
|
43 |
- politicallyCorrect := true |
|
44 |
- return coolInventorNames && easyToRemember && mildlyFunnyOnOccasion && politicallyCorrect |
|
45 |
-} |