Browse code

rm-gocheck: True

sed -E -i 's#\bassert\.Assert\(c, (.*), checker\.True#assert.Assert(c, \1#g' \
-- "integration-cli/docker_api_containers_test.go" "integration-cli/docker_cli_build_test.go" "integration-cli/docker_cli_by_digest_test.go" "integration-cli/docker_cli_cp_from_container_test.go" "integration-cli/docker_cli_cp_to_container_test.go" "integration-cli/docker_cli_create_test.go" "integration-cli/docker_cli_daemon_test.go" "integration-cli/docker_cli_external_volume_driver_unix_test.go" "integration-cli/docker_cli_network_unix_test.go" "integration-cli/docker_cli_plugins_test.go" "integration-cli/docker_cli_service_create_test.go"

Signed-off-by: Tibor Vass <tibor@docker.com>

Tibor Vass authored on 2019/09/10 06:05:57
Showing 11 changed files
... ...
@@ -121,7 +121,7 @@ func (s *DockerSuite) TestContainerAPIGetExport(c *testing.T) {
121 121
 			break
122 122
 		}
123 123
 	}
124
-	assert.Assert(c, found, checker.True, check.Commentf("The created test file has not been found in the exported image"))
124
+	assert.Assert(c, found, check.Commentf("The created test file has not been found in the exported image"))
125 125
 }
126 126
 
127 127
 func (s *DockerSuite) TestContainerAPIGetChanges(c *testing.T) {
... ...
@@ -144,7 +144,7 @@ func (s *DockerSuite) TestContainerAPIGetChanges(c *testing.T) {
144 144
 			success = true
145 145
 		}
146 146
 	}
147
-	assert.Assert(c, success, checker.True, check.Commentf("/etc/passwd has been removed but is not present in the diff"))
147
+	assert.Assert(c, success, check.Commentf("/etc/passwd has been removed but is not present in the diff"))
148 148
 }
149 149
 
150 150
 func (s *DockerSuite) TestGetContainerStats(c *testing.T) {
... ...
@@ -1044,7 +1044,7 @@ func (s *DockerSuite) TestContainerAPICopyPre124(c *testing.T) {
1044 1044
 			break
1045 1045
 		}
1046 1046
 	}
1047
-	assert.Assert(c, found, checker.True)
1047
+	assert.Assert(c, found)
1048 1048
 }
1049 1049
 
1050 1050
 func (s *DockerSuite) TestContainerAPICopyResourcePathEmptyPre124(c *testing.T) {
... ...
@@ -1219,7 +1219,7 @@ func (s *DockerSuite) TestContainerAPIDeleteRemoveVolume(c *testing.T) {
1219 1219
 	assert.NilError(c, err)
1220 1220
 
1221 1221
 	_, err = os.Stat(source)
1222
-	assert.Assert(c, os.IsNotExist(err), checker.True, check.Commentf("expected to get ErrNotExist error, got %v", err))
1222
+	assert.Assert(c, os.IsNotExist(err), check.Commentf("expected to get ErrNotExist error, got %v", err))
1223 1223
 }
1224 1224
 
1225 1225
 // Regression test for https://github.com/docker/docker/issues/6231
... ...
@@ -4741,7 +4741,7 @@ func (s *DockerSuite) TestBuildTagEvent(c *testing.T) {
4741 4741
 		}
4742 4742
 	}
4743 4743
 
4744
-	assert.Assert(c, foundTag, checker.True, check.Commentf("No tag event found:\n%s", out))
4744
+	assert.Assert(c, foundTag, check.Commentf("No tag event found:\n%s", out))
4745 4745
 }
4746 4746
 
4747 4747
 // #15780
... ...
@@ -253,7 +253,7 @@ func (s *DockerRegistrySuite) TestListImagesWithDigests(c *testing.T) {
253 253
 
254 254
 	// make sure repo shown, tag=<none>, digest = $digest1
255 255
 	re1 := regexp.MustCompile(`\s*` + repoName + `\s*<none>\s*` + digest1.String() + `\s`)
256
-	assert.Assert(c, re1.MatchString(out), checker.True, check.Commentf("expected %q: %s", re1.String(), out))
256
+	assert.Assert(c, re1.MatchString(out), check.Commentf("expected %q: %s", re1.String(), out))
257 257
 	// setup image2
258 258
 	digest2, err := setupImageWithTag(c, "tag2")
259 259
 	//error setting up image
... ...
@@ -271,11 +271,11 @@ func (s *DockerRegistrySuite) TestListImagesWithDigests(c *testing.T) {
271 271
 	out, _ = dockerCmd(c, "images", "--digests")
272 272
 
273 273
 	// make sure repo shown, tag=<none>, digest = $digest1
274
-	assert.Assert(c, re1.MatchString(out), checker.True, check.Commentf("expected %q: %s", re1.String(), out))
274
+	assert.Assert(c, re1.MatchString(out), check.Commentf("expected %q: %s", re1.String(), out))
275 275
 
276 276
 	// make sure repo shown, tag=<none>, digest = $digest2
277 277
 	re2 := regexp.MustCompile(`\s*` + repoName + `\s*<none>\s*` + digest2.String() + `\s`)
278
-	assert.Assert(c, re2.MatchString(out), checker.True, check.Commentf("expected %q: %s", re2.String(), out))
278
+	assert.Assert(c, re2.MatchString(out), check.Commentf("expected %q: %s", re2.String(), out))
279 279
 
280 280
 	// pull tag1
281 281
 	dockerCmd(c, "pull", repoName+":tag1")
... ...
@@ -285,9 +285,9 @@ func (s *DockerRegistrySuite) TestListImagesWithDigests(c *testing.T) {
285 285
 
286 286
 	// make sure image 1 has repo, tag, <none> AND repo, <none>, digest
287 287
 	reWithDigest1 := regexp.MustCompile(`\s*` + repoName + `\s*tag1\s*` + digest1.String() + `\s`)
288
-	assert.Assert(c, reWithDigest1.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithDigest1.String(), out))
288
+	assert.Assert(c, reWithDigest1.MatchString(out), check.Commentf("expected %q: %s", reWithDigest1.String(), out))
289 289
 	// make sure image 2 has repo, <none>, digest
290
-	assert.Assert(c, re2.MatchString(out), checker.True, check.Commentf("expected %q: %s", re2.String(), out))
290
+	assert.Assert(c, re2.MatchString(out), check.Commentf("expected %q: %s", re2.String(), out))
291 291
 
292 292
 	// pull tag 2
293 293
 	dockerCmd(c, "pull", repoName+":tag2")
... ...
@@ -296,22 +296,22 @@ func (s *DockerRegistrySuite) TestListImagesWithDigests(c *testing.T) {
296 296
 	out, _ = dockerCmd(c, "images", "--digests")
297 297
 
298 298
 	// make sure image 1 has repo, tag, digest
299
-	assert.Assert(c, reWithDigest1.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithDigest1.String(), out))
299
+	assert.Assert(c, reWithDigest1.MatchString(out), check.Commentf("expected %q: %s", reWithDigest1.String(), out))
300 300
 
301 301
 	// make sure image 2 has repo, tag, digest
302 302
 	reWithDigest2 := regexp.MustCompile(`\s*` + repoName + `\s*tag2\s*` + digest2.String() + `\s`)
303
-	assert.Assert(c, reWithDigest2.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithDigest2.String(), out))
303
+	assert.Assert(c, reWithDigest2.MatchString(out), check.Commentf("expected %q: %s", reWithDigest2.String(), out))
304 304
 
305 305
 	// list images
306 306
 	out, _ = dockerCmd(c, "images", "--digests")
307 307
 
308 308
 	// make sure image 1 has repo, tag, digest
309
-	assert.Assert(c, reWithDigest1.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithDigest1.String(), out))
309
+	assert.Assert(c, reWithDigest1.MatchString(out), check.Commentf("expected %q: %s", reWithDigest1.String(), out))
310 310
 	// make sure image 2 has repo, tag, digest
311
-	assert.Assert(c, reWithDigest2.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithDigest2.String(), out))
311
+	assert.Assert(c, reWithDigest2.MatchString(out), check.Commentf("expected %q: %s", reWithDigest2.String(), out))
312 312
 	// make sure busybox has tag, but not digest
313 313
 	busyboxRe := regexp.MustCompile(`\s*busybox\s*latest\s*<none>\s`)
314
-	assert.Assert(c, busyboxRe.MatchString(out), checker.True, check.Commentf("expected %q: %s", busyboxRe.String(), out))
314
+	assert.Assert(c, busyboxRe.MatchString(out), check.Commentf("expected %q: %s", busyboxRe.String(), out))
315 315
 }
316 316
 
317 317
 func (s *DockerRegistrySuite) TestListDanglingImagesWithDigests(c *testing.T) {
... ...
@@ -329,7 +329,7 @@ func (s *DockerRegistrySuite) TestListDanglingImagesWithDigests(c *testing.T) {
329 329
 
330 330
 	// make sure repo shown, tag=<none>, digest = $digest1
331 331
 	re1 := regexp.MustCompile(`\s*` + repoName + `\s*<none>\s*` + digest1.String() + `\s`)
332
-	assert.Assert(c, re1.MatchString(out), checker.True, check.Commentf("expected %q: %s", re1.String(), out))
332
+	assert.Assert(c, re1.MatchString(out), check.Commentf("expected %q: %s", re1.String(), out))
333 333
 	// setup image2
334 334
 	digest2, err := setupImageWithTag(c, "dangle2")
335 335
 	//error setting up image
... ...
@@ -347,11 +347,11 @@ func (s *DockerRegistrySuite) TestListDanglingImagesWithDigests(c *testing.T) {
347 347
 	out, _ = dockerCmd(c, "images", "--digests", "--filter=dangling=true")
348 348
 
349 349
 	// make sure repo shown, tag=<none>, digest = $digest1
350
-	assert.Assert(c, re1.MatchString(out), checker.True, check.Commentf("expected %q: %s", re1.String(), out))
350
+	assert.Assert(c, re1.MatchString(out), check.Commentf("expected %q: %s", re1.String(), out))
351 351
 
352 352
 	// make sure repo shown, tag=<none>, digest = $digest2
353 353
 	re2 := regexp.MustCompile(`\s*` + repoName + `\s*<none>\s*` + digest2.String() + `\s`)
354
-	assert.Assert(c, re2.MatchString(out), checker.True, check.Commentf("expected %q: %s", re2.String(), out))
354
+	assert.Assert(c, re2.MatchString(out), check.Commentf("expected %q: %s", re2.String(), out))
355 355
 
356 356
 	// pull dangle1 tag
357 357
 	dockerCmd(c, "pull", repoName+":dangle1")
... ...
@@ -363,7 +363,7 @@ func (s *DockerRegistrySuite) TestListDanglingImagesWithDigests(c *testing.T) {
363 363
 	reWithDigest1 := regexp.MustCompile(`\s*` + repoName + `\s*dangle1\s*` + digest1.String() + `\s`)
364 364
 	assert.Assert(c, !reWithDigest1.MatchString(out), check.Commentf("unexpected %q: %s", reWithDigest1.String(), out))
365 365
 	// make sure image 2 has repo, <none>, digest
366
-	assert.Assert(c, re2.MatchString(out), checker.True, check.Commentf("expected %q: %s", re2.String(), out))
366
+	assert.Assert(c, re2.MatchString(out), check.Commentf("expected %q: %s", re2.String(), out))
367 367
 
368 368
 	// pull dangle2 tag
369 369
 	dockerCmd(c, "pull", repoName+":dangle2")
... ...
@@ -372,11 +372,11 @@ func (s *DockerRegistrySuite) TestListDanglingImagesWithDigests(c *testing.T) {
372 372
 	out, _ = dockerCmd(c, "images", "--digests")
373 373
 
374 374
 	// make sure image 1 has repo, tag, digest
375
-	assert.Assert(c, reWithDigest1.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithDigest1.String(), out))
375
+	assert.Assert(c, reWithDigest1.MatchString(out), check.Commentf("expected %q: %s", reWithDigest1.String(), out))
376 376
 
377 377
 	// make sure image 2 has repo, tag, digest
378 378
 	reWithDigest2 := regexp.MustCompile(`\s*` + repoName + `\s*dangle2\s*` + digest2.String() + `\s`)
379
-	assert.Assert(c, reWithDigest2.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithDigest2.String(), out))
379
+	assert.Assert(c, reWithDigest2.MatchString(out), check.Commentf("expected %q: %s", reWithDigest2.String(), out))
380 380
 
381 381
 	// list images, no longer dangling, should not match
382 382
 	out, _ = dockerCmd(c, "images", "--digests", "--filter=dangling=true")
... ...
@@ -150,7 +150,7 @@ func (s *DockerSuite) TestCpFromCaseB(c *testing.T) {
150 150
 	err := runDockerCp(c, srcPath, dstDir, nil)
151 151
 	assert.ErrorContains(c, err, "")
152 152
 
153
-	assert.Assert(c, isCpDirNotExist(err), checker.True, check.Commentf("expected DirNotExists error, but got %T: %s", err, err))
153
+	assert.Assert(c, isCpDirNotExist(err), check.Commentf("expected DirNotExists error, but got %T: %s", err, err))
154 154
 }
155 155
 
156 156
 // C. SRC specifies a file and DST exists as a file. This should overwrite
... ...
@@ -195,7 +195,7 @@ func (s *DockerSuite) TestCpFromCaseD(c *testing.T) {
195 195
 
196 196
 	// Ensure that dstPath doesn't exist.
197 197
 	_, err := os.Stat(dstPath)
198
-	assert.Assert(c, os.IsNotExist(err), checker.True, check.Commentf("did not expect dstPath %q to exist", dstPath))
198
+	assert.Assert(c, os.IsNotExist(err), check.Commentf("did not expect dstPath %q to exist", dstPath))
199 199
 
200 200
 	assert.Assert(c, runDockerCp(c, srcPath, dstDir, nil) == nil)
201 201
 
... ...
@@ -266,7 +266,7 @@ func (s *DockerSuite) TestCpFromCaseF(c *testing.T) {
266 266
 	err := runDockerCp(c, srcDir, dstFile, nil)
267 267
 	assert.ErrorContains(c, err, "")
268 268
 
269
-	assert.Assert(c, isCpCannotCopyDir(err), checker.True, check.Commentf("expected ErrCannotCopyDir error, but got %T: %s", err, err))
269
+	assert.Assert(c, isCpCannotCopyDir(err), check.Commentf("expected ErrCannotCopyDir error, but got %T: %s", err, err))
270 270
 }
271 271
 
272 272
 // G. SRC specifies a directory and DST exists as a directory. This should copy
... ...
@@ -358,7 +358,7 @@ func (s *DockerSuite) TestCpFromCaseI(c *testing.T) {
358 358
 	err := runDockerCp(c, srcDir, dstFile, nil)
359 359
 	assert.ErrorContains(c, err, "")
360 360
 
361
-	assert.Assert(c, isCpCannotCopyDir(err), checker.True, check.Commentf("expected ErrCannotCopyDir error, but got %T: %s", err, err))
361
+	assert.Assert(c, isCpCannotCopyDir(err), check.Commentf("expected ErrCannotCopyDir error, but got %T: %s", err, err))
362 362
 }
363 363
 
364 364
 // J. SRC specifies a directory's contents only and DST exists as a directory.
... ...
@@ -158,7 +158,7 @@ func (s *DockerSuite) TestCpToCaseB(c *testing.T) {
158 158
 	err := runDockerCp(c, srcPath, dstDir, nil)
159 159
 	assert.ErrorContains(c, err, "")
160 160
 
161
-	assert.Assert(c, isCpDirNotExist(err), checker.True, check.Commentf("expected DirNotExists error, but got %T: %s", err, err))
161
+	assert.Assert(c, isCpDirNotExist(err), check.Commentf("expected DirNotExists error, but got %T: %s", err, err))
162 162
 }
163 163
 
164 164
 // C. SRC specifies a file and DST exists as a file. This should overwrite
... ...
@@ -288,7 +288,7 @@ func (s *DockerSuite) TestCpToCaseF(c *testing.T) {
288 288
 	err := runDockerCp(c, srcDir, dstFile, nil)
289 289
 	assert.ErrorContains(c, err, "")
290 290
 
291
-	assert.Assert(c, isCpCannotCopyDir(err), checker.True, check.Commentf("expected ErrCannotCopyDir error, but got %T: %s", err, err))
291
+	assert.Assert(c, isCpCannotCopyDir(err), check.Commentf("expected ErrCannotCopyDir error, but got %T: %s", err, err))
292 292
 }
293 293
 
294 294
 // G. SRC specifies a directory and DST exists as a directory. This should copy
... ...
@@ -393,7 +393,7 @@ func (s *DockerSuite) TestCpToCaseI(c *testing.T) {
393 393
 	err := runDockerCp(c, srcDir, dstFile, nil)
394 394
 	assert.ErrorContains(c, err, "")
395 395
 
396
-	assert.Assert(c, isCpCannotCopyDir(err), checker.True, check.Commentf("expected ErrCannotCopyDir error, but got %T: %s", err, err))
396
+	assert.Assert(c, isCpCannotCopyDir(err), check.Commentf("expected ErrCannotCopyDir error, but got %T: %s", err, err))
397 397
 }
398 398
 
399 399
 // J. SRC specifies a directory's contents only and DST exists as a directory.
... ...
@@ -462,7 +462,7 @@ func (s *DockerSuite) TestCpToErrReadOnlyRootfs(c *testing.T) {
462 462
 	err := runDockerCp(c, srcPath, dstPath, nil)
463 463
 	assert.ErrorContains(c, err, "")
464 464
 
465
-	assert.Assert(c, isCpCannotCopyReadOnly(err), checker.True, check.Commentf("expected ErrContainerRootfsReadonly error, but got %T: %s", err, err))
465
+	assert.Assert(c, isCpCannotCopyReadOnly(err), check.Commentf("expected ErrContainerRootfsReadonly error, but got %T: %s", err, err))
466 466
 
467 467
 	// Ensure that dstPath doesn't exist.
468 468
 	assert.Assert(c, containerStartOutputEquals(c, containerID, "") == nil)
... ...
@@ -489,7 +489,7 @@ func (s *DockerSuite) TestCpToErrReadOnlyVolume(c *testing.T) {
489 489
 	err := runDockerCp(c, srcPath, dstPath, nil)
490 490
 	assert.ErrorContains(c, err, "")
491 491
 
492
-	assert.Assert(c, isCpCannotCopyReadOnly(err), checker.True, check.Commentf("expected ErrVolumeReadonly error, but got %T: %s", err, err))
492
+	assert.Assert(c, isCpCannotCopyReadOnly(err), check.Commentf("expected ErrVolumeReadonly error, but got %T: %s", err, err))
493 493
 
494 494
 	// Ensure that dstPath doesn't exist.
495 495
 	assert.Assert(c, containerStartOutputEquals(c, containerID, "") == nil)
... ...
@@ -101,7 +101,7 @@ func (s *DockerSuite) TestCreateHostConfig(c *testing.T) {
101 101
 
102 102
 	cont := containers[0]
103 103
 	assert.Assert(c, cont.HostConfig != nil, check.Commentf("Expected HostConfig, got none"))
104
-	assert.Assert(c, cont.HostConfig.PublishAllPorts, checker.True, check.Commentf("Expected PublishAllPorts, got false"))
104
+	assert.Assert(c, cont.HostConfig.PublishAllPorts, check.Commentf("Expected PublishAllPorts, got false"))
105 105
 }
106 106
 
107 107
 func (s *DockerSuite) TestCreateWithPortRange(c *testing.T) {
... ...
@@ -1866,7 +1866,7 @@ func (s *DockerDaemonSuite) TestDaemonCgroupParent(c *testing.T) {
1866 1866
 			break
1867 1867
 		}
1868 1868
 	}
1869
-	assert.Assert(c, found, checker.True, check.Commentf("Cgroup path for container (%s) doesn't found in cgroups file: %s", expectedCgroup, cgroupPaths))
1869
+	assert.Assert(c, found, check.Commentf("Cgroup path for container (%s) doesn't found in cgroups file: %s", expectedCgroup, cgroupPaths))
1870 1870
 }
1871 1871
 
1872 1872
 func (s *DockerDaemonSuite) TestDaemonRestartWithLinks(c *testing.T) {
... ...
@@ -2845,7 +2845,7 @@ func (s *DockerDaemonSuite) TestShmSize(c *testing.T) {
2845 2845
 	name := "shm1"
2846 2846
 	out, err := s.d.Cmd("run", "--name", name, "busybox", "mount")
2847 2847
 	assert.NilError(c, err, "Output: %s", out)
2848
-	assert.Assert(c, pattern.MatchString(out), checker.True)
2848
+	assert.Assert(c, pattern.MatchString(out))
2849 2849
 	out, err = s.d.Cmd("inspect", "--format", "{{.HostConfig.ShmSize}}", name)
2850 2850
 	assert.NilError(c, err, "Output: %s", out)
2851 2851
 	assert.Equal(c, strings.TrimSpace(out), fmt.Sprintf("%v", size))
... ...
@@ -2869,7 +2869,7 @@ func (s *DockerDaemonSuite) TestShmSizeReload(c *testing.T) {
2869 2869
 	name := "shm1"
2870 2870
 	out, err := s.d.Cmd("run", "--name", name, "busybox", "mount")
2871 2871
 	assert.NilError(c, err, "Output: %s", out)
2872
-	assert.Assert(c, pattern.MatchString(out), checker.True)
2872
+	assert.Assert(c, pattern.MatchString(out))
2873 2873
 	out, err = s.d.Cmd("inspect", "--format", "{{.HostConfig.ShmSize}}", name)
2874 2874
 	assert.NilError(c, err, "Output: %s", out)
2875 2875
 	assert.Equal(c, strings.TrimSpace(out), fmt.Sprintf("%v", size))
... ...
@@ -2885,7 +2885,7 @@ func (s *DockerDaemonSuite) TestShmSizeReload(c *testing.T) {
2885 2885
 	name = "shm2"
2886 2886
 	out, err = s.d.Cmd("run", "--name", name, "busybox", "mount")
2887 2887
 	assert.NilError(c, err, "Output: %s", out)
2888
-	assert.Assert(c, pattern.MatchString(out), checker.True)
2888
+	assert.Assert(c, pattern.MatchString(out))
2889 2889
 	out, err = s.d.Cmd("inspect", "--format", "{{.HostConfig.ShmSize}}", name)
2890 2890
 	assert.NilError(c, err, "Output: %s", out)
2891 2891
 	assert.Equal(c, strings.TrimSpace(out), fmt.Sprintf("%v", size))
... ...
@@ -308,7 +308,7 @@ func (s *DockerExternalVolumeSuite) TestExternalVolumeDriverNamed(c *testing.T)
308 308
 	p := hostVolumePath("external-volume-test")
309 309
 	_, err = os.Lstat(p)
310 310
 	assert.ErrorContains(c, err, "")
311
-	assert.Assert(c, os.IsNotExist(err), checker.True, check.Commentf("Expected volume path in host to not exist: %s, %v\n", p, err))
311
+	assert.Assert(c, os.IsNotExist(err), check.Commentf("Expected volume path in host to not exist: %s, %v\n", p, err))
312 312
 
313 313
 	assert.Equal(c, s.ec.activations, 1)
314 314
 	assert.Equal(c, s.ec.creations, 1)
... ...
@@ -1619,7 +1619,7 @@ func (s *DockerSuite) TestDockerNetworkInternalMode(c *testing.T) {
1619 1619
 	dockerCmd(c, "network", "create", "--driver=bridge", "--internal", "internal")
1620 1620
 	assertNwIsAvailable(c, "internal")
1621 1621
 	nr := getNetworkResource(c, "internal")
1622
-	assert.Assert(c, nr.Internal, checker.True)
1622
+	assert.Assert(c, nr.Internal)
1623 1623
 
1624 1624
 	dockerCmd(c, "run", "-d", "--net=internal", "--name=first", "busybox:glibc", "top")
1625 1625
 	assert.Assert(c, waitRun("first") == nil)
... ...
@@ -458,7 +458,7 @@ func (s *DockerSuite) TestPluginUpgrade(c *testing.T) {
458 458
 
459 459
 	// make sure "v2" does not exists
460 460
 	_, err = os.Stat(filepath.Join(testEnv.DaemonInfo.DockerRootDir, "plugins", id, "rootfs", "v2"))
461
-	assert.Assert(c, os.IsNotExist(err), checker.True, check.Commentf("%s", out))
461
+	assert.Assert(c, os.IsNotExist(err), check.Commentf("%s", out))
462 462
 
463 463
 	dockerCmd(c, "plugin", "disable", "-f", plugin)
464 464
 	dockerCmd(c, "plugin", "upgrade", "--grant-all-permissions", "--skip-remote-check", plugin, pluginV2)
... ...
@@ -48,7 +48,7 @@ func (s *DockerSwarmSuite) TestServiceCreateMountVolume(c *testing.T) {
48 48
 	assert.Equal(c, mountConfig[0].Target, "/foo")
49 49
 	assert.Equal(c, mountConfig[0].Type, mount.TypeVolume)
50 50
 	assert.Assert(c, mountConfig[0].VolumeOptions != nil)
51
-	assert.Assert(c, mountConfig[0].VolumeOptions.NoCopy, checker.True)
51
+	assert.Assert(c, mountConfig[0].VolumeOptions.NoCopy)
52 52
 
53 53
 	// check container mounts actual
54 54
 	out, err = s.nodeCmd(c, task.NodeID, "inspect", "--format", "{{json .Mounts}}", task.Status.ContainerStatus.ContainerID)