Signed-off-by: Daehyeok Mun <daehyeok@gmail.com>
| ... | ... |
@@ -118,7 +118,7 @@ type v1DependencyImage struct {
|
| 118 | 118 |
v1ImageCommon |
| 119 | 119 |
} |
| 120 | 120 |
|
| 121 |
-func newV1DependencyImage(l layer.Layer, parent *v1DependencyImage) (*v1DependencyImage, error) {
|
|
| 121 |
+func newV1DependencyImage(l layer.Layer, parent *v1DependencyImage) *v1DependencyImage {
|
|
| 122 | 122 |
v1ID := digest.Digest(l.ChainID()).Hex() |
| 123 | 123 |
|
| 124 | 124 |
config := "" |
| ... | ... |
@@ -133,7 +133,7 @@ func newV1DependencyImage(l layer.Layer, parent *v1DependencyImage) (*v1Dependen |
| 133 | 133 |
config: []byte(config), |
| 134 | 134 |
layer: l, |
| 135 | 135 |
}, |
| 136 |
- }, nil |
|
| 136 |
+ } |
|
| 137 | 137 |
} |
| 138 | 138 |
|
| 139 | 139 |
// Retrieve the all the images to be uploaded in the correct order |
| ... | ... |
@@ -221,10 +221,7 @@ func (p *v1Pusher) imageListForTag(imgID image.ID, dependenciesSeen map[layer.Ch |
| 221 | 221 |
} |
| 222 | 222 |
} |
| 223 | 223 |
|
| 224 |
- dependencyImages, parent, err := generateDependencyImages(l.Parent(), dependenciesSeen) |
|
| 225 |
- if err != nil {
|
|
| 226 |
- return nil, err |
|
| 227 |
- } |
|
| 224 |
+ dependencyImages, parent := generateDependencyImages(l.Parent(), dependenciesSeen) |
|
| 228 | 225 |
|
| 229 | 226 |
topImage, err := newV1TopImage(imgID, img, l, parent) |
| 230 | 227 |
if err != nil {
|
| ... | ... |
@@ -236,32 +233,29 @@ func (p *v1Pusher) imageListForTag(imgID image.ID, dependenciesSeen map[layer.Ch |
| 236 | 236 |
return |
| 237 | 237 |
} |
| 238 | 238 |
|
| 239 |
-func generateDependencyImages(l layer.Layer, dependenciesSeen map[layer.ChainID]*v1DependencyImage) (imageListForThisTag []v1Image, parent *v1DependencyImage, err error) {
|
|
| 239 |
+func generateDependencyImages(l layer.Layer, dependenciesSeen map[layer.ChainID]*v1DependencyImage) (imageListForThisTag []v1Image, parent *v1DependencyImage) {
|
|
| 240 | 240 |
if l == nil {
|
| 241 |
- return nil, nil, nil |
|
| 241 |
+ return nil, nil |
|
| 242 | 242 |
} |
| 243 | 243 |
|
| 244 |
- imageListForThisTag, parent, err = generateDependencyImages(l.Parent(), dependenciesSeen) |
|
| 244 |
+ imageListForThisTag, parent = generateDependencyImages(l.Parent(), dependenciesSeen) |
|
| 245 | 245 |
|
| 246 | 246 |
if dependenciesSeen != nil {
|
| 247 | 247 |
if dependencyImage, present := dependenciesSeen[l.ChainID()]; present {
|
| 248 | 248 |
// This layer is already on the list, we can ignore it |
| 249 | 249 |
// and all its parents. |
| 250 |
- return imageListForThisTag, dependencyImage, nil |
|
| 250 |
+ return imageListForThisTag, dependencyImage |
|
| 251 | 251 |
} |
| 252 | 252 |
} |
| 253 | 253 |
|
| 254 |
- dependencyImage, err := newV1DependencyImage(l, parent) |
|
| 255 |
- if err != nil {
|
|
| 256 |
- return nil, nil, err |
|
| 257 |
- } |
|
| 254 |
+ dependencyImage := newV1DependencyImage(l, parent) |
|
| 258 | 255 |
imageListForThisTag = append(imageListForThisTag, dependencyImage) |
| 259 | 256 |
|
| 260 | 257 |
if dependenciesSeen != nil {
|
| 261 | 258 |
dependenciesSeen[l.ChainID()] = dependencyImage |
| 262 | 259 |
} |
| 263 | 260 |
|
| 264 |
- return imageListForThisTag, dependencyImage, nil |
|
| 261 |
+ return imageListForThisTag, dependencyImage |
|
| 265 | 262 |
} |
| 266 | 263 |
|
| 267 | 264 |
// createImageIndex returns an index of an image's layer IDs and tags. |