Browse code
*: remove interfacer linter from CI
It has been declared deprecated by the author, and has a knack for
false-positives (as well as giving bad advice when it comes to APIs --
which is quite clear when looking at "nolint: interfacer" comments).
Signed-off-by: Aleksa Sarai <asarai@suse.de>
Aleksa Sarai authored on 2019/03/13 08:37:35Showing 6 changed files
- daemon/container_operations.go
- daemon/metrics.go
- distribution/pull_v1.go
- distribution/push_v2.go
- hack/validate/gometalinter.json
- registry/auth.go
| ... | ... |
@@ -801,7 +801,7 @@ func (daemon *Daemon) connectToNetwork(container *container.Container, idOrName |
| 801 | 801 |
return nil |
| 802 | 802 |
} |
| 803 | 803 |
|
| 804 |
-func updateJoinInfo(networkSettings *network.Settings, n libnetwork.Network, ep libnetwork.Endpoint) error { // nolint: interfacer
|
|
| 804 |
+func updateJoinInfo(networkSettings *network.Settings, n libnetwork.Network, ep libnetwork.Endpoint) error {
|
|
| 805 | 805 |
if ep == nil {
|
| 806 | 806 |
return errors.New("invalid enppoint whhile building portmap info")
|
| 807 | 807 |
} |
| ... | ... |
@@ -143,7 +143,7 @@ type metricsPlugin interface {
|
| 143 | 143 |
StopMetrics() error |
| 144 | 144 |
} |
| 145 | 145 |
|
| 146 |
-func makePluginAdapter(p plugingetter.CompatPlugin) (metricsPlugin, error) { // nolint: interfacer
|
|
| 146 |
+func makePluginAdapter(p plugingetter.CompatPlugin) (metricsPlugin, error) {
|
|
| 147 | 147 |
if pc, ok := p.(plugingetter.PluginWithV1Client); ok {
|
| 148 | 148 |
return &metricsPluginAdapter{pc.Client(), p.Name()}, nil
|
| 149 | 149 |
} |
| ... | ... |
@@ -13,7 +13,6 @@ import ( |
| 13 | 13 |
"time" |
| 14 | 14 |
|
| 15 | 15 |
"github.com/docker/distribution/reference" |
| 16 |
- "github.com/docker/distribution/registry/client/auth" |
|
| 17 | 16 |
"github.com/docker/distribution/registry/client/transport" |
| 18 | 17 |
"github.com/docker/docker/distribution/metadata" |
| 19 | 18 |
"github.com/docker/docker/distribution/xfer" |
| ... | ... |
@@ -70,9 +69,7 @@ func (p *v1Puller) Pull(ctx context.Context, ref reference.Named, _ *specs.Platf |
| 70 | 70 |
return nil |
| 71 | 71 |
} |
| 72 | 72 |
|
| 73 |
-// Note use auth.Scope rather than reference.Named due to this warning causing Jenkins CI to fail: |
|
| 74 |
-// warning: ref can be github.com/docker/docker/vendor/github.com/docker/distribution/registry/client/auth.Scope (interfacer) |
|
| 75 |
-func (p *v1Puller) pullRepository(ctx context.Context, ref auth.Scope) error {
|
|
| 73 |
+func (p *v1Puller) pullRepository(ctx context.Context, ref reference.Named) error {
|
|
| 76 | 74 |
progress.Message(p.config.ProgressOutput, "", "Pulling repository "+p.repoInfo.Name.Name()) |
| 77 | 75 |
|
| 78 | 76 |
tagged, isTagged := ref.(reference.NamedTagged) |
| ... | ... |
@@ -649,7 +649,6 @@ func (bla byLikeness) Swap(i, j int) {
|
| 649 | 649 |
} |
| 650 | 650 |
func (bla byLikeness) Len() int { return len(bla.arr) }
|
| 651 | 651 |
|
| 652 |
-// nolint: interfacer |
|
| 653 | 652 |
func sortV2MetadataByLikenessAndAge(repoInfo reference.Named, hmacKey []byte, marr []metadata.V2Metadata) {
|
| 654 | 653 |
// reverse the metadata array to shift the newest entries to the beginning |
| 655 | 654 |
for i := 0; i < len(marr)/2; i++ {
|
| ... | ... |
@@ -248,7 +248,6 @@ func (err PingResponseError) Error() string {
|
| 248 | 248 |
// challenge manager for the supported authentication types and |
| 249 | 249 |
// whether v2 was confirmed by the response. If a response is received but |
| 250 | 250 |
// cannot be interpreted a PingResponseError will be returned. |
| 251 |
-// nolint: interfacer |
|
| 252 | 251 |
func PingV2Registry(endpoint *url.URL, transport http.RoundTripper) (challenge.Manager, bool, error) {
|
| 253 | 252 |
var ( |
| 254 | 253 |
foundV2 = false |