GitList

Browse code

Fix TestErrorCases to run all tests

Signed-off-by: John Howard <jhoward@microsoft.com>
Signed-off-by: Vincent Demeester <vincent@sbr.pm>

John Howard authored on 2017/10/04 07:35:27
Showing 1 changed files

builder/dockerfile/instructions/parse_test.go index f15eaca..6ac3dfd 100644

builder/dockerfile/instructions/parse_test.go

@@ -194,11 +194,7 @@ func TestErrorCases(t *testing.T) {
 		}
 		n := ast.AST.Children[0]
 		_, err = ParseInstruction(n)
-		if err != nil {
-			testutil.ErrorContains(t, err, c.expectedError)
-			return
-		}
-		t.Fatalf("No error when executing test %s", c.name)
+		testutil.ErrorContains(t, err, c.expectedError)
 	}
 
 }

...	...	@@ -194,11 +194,7 @@ func TestErrorCases(t *testing.T) {
194	194	}
195	195	n := ast.AST.Children[0]
196	196	_, err = ParseInstruction(n)
197		- if err != nil {
198		- testutil.ErrorContains(t, err, c.expectedError)
199		- return
200		- }
201		- t.Fatalf("No error when executing test %s", c.name)
	197	+ testutil.ErrorContains(t, err, c.expectedError)
202	198	}
203	199
204	200	}