Browse code

use of checkers on docker_cli_exec_unix_test.go

Signed-off-by: weiyan <weiyan3@huawei.com>

weiyan authored on 2015/10/19 16:14:59
Showing 1 changed files
... ...
@@ -9,6 +9,7 @@ import (
9 9
 	"strings"
10 10
 	"time"
11 11
 
12
+	"github.com/docker/docker/pkg/integration/checker"
12 13
 	"github.com/go-check/check"
13 14
 	"github.com/kr/pty"
14 15
 )
... ...
@@ -21,9 +22,7 @@ func (s *DockerSuite) TestExecInteractiveStdinClose(c *check.C) {
21 21
 
22 22
 	cmd := exec.Command(dockerBinary, "exec", "-i", contID, "echo", "-n", "hello")
23 23
 	p, err := pty.Start(cmd)
24
-	if err != nil {
25
-		c.Fatal(err)
26
-	}
24
+	c.Assert(err, checker.IsNil)
27 25
 
28 26
 	b := bytes.NewBuffer(nil)
29 27
 	go io.Copy(b, p)
... ...
@@ -33,12 +32,9 @@ func (s *DockerSuite) TestExecInteractiveStdinClose(c *check.C) {
33 33
 
34 34
 	select {
35 35
 	case err := <-ch:
36
-		if err != nil {
37
-			c.Errorf("cmd finished with error %v", err)
38
-		}
39
-		if output := b.String(); strings.TrimSpace(output) != "hello" {
40
-			c.Fatalf("Unexpected output %s", output)
41
-		}
36
+		c.Assert(err, checker.IsNil)
37
+		output := b.String()
38
+		c.Assert(strings.TrimSpace(output), checker.Equals, "hello")
42 39
 	case <-time.After(1 * time.Second):
43 40
 		c.Fatal("timed out running docker exec")
44 41
 	}
... ...
@@ -50,11 +46,11 @@ func (s *DockerSuite) TestExecTTY(c *check.C) {
50 50
 
51 51
 	cmd := exec.Command(dockerBinary, "exec", "-it", "test", "sh")
52 52
 	p, err := pty.Start(cmd)
53
-	c.Assert(err, check.IsNil)
53
+	c.Assert(err, checker.IsNil)
54 54
 	defer p.Close()
55 55
 
56 56
 	_, err = p.Write([]byte("cat /foo && exit\n"))
57
-	c.Assert(err, check.IsNil)
57
+	c.Assert(err, checker.IsNil)
58 58
 
59 59
 	chErr := make(chan error)
60 60
 	go func() {
... ...
@@ -62,13 +58,13 @@ func (s *DockerSuite) TestExecTTY(c *check.C) {
62 62
 	}()
63 63
 	select {
64 64
 	case err := <-chErr:
65
-		c.Assert(err, check.IsNil)
65
+		c.Assert(err, checker.IsNil)
66 66
 	case <-time.After(3 * time.Second):
67 67
 		c.Fatal("timeout waiting for exec to exit")
68 68
 	}
69 69
 
70 70
 	buf := make([]byte, 256)
71 71
 	read, err := p.Read(buf)
72
-	c.Assert(err, check.IsNil)
73
-	c.Assert(bytes.Contains(buf, []byte("hello")), check.Equals, true, check.Commentf(string(buf[:read])))
72
+	c.Assert(err, checker.IsNil)
73
+	c.Assert(bytes.Contains(buf, []byte("hello")), checker.Equals, true, check.Commentf(string(buf[:read])))
74 74
 }