integration-cli/docker_cli_pull_test.go:55:69: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_exec_test.go:46:64: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_service_health_test.go:86:65: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_images_test.go:128:66: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_swarm_node_test.go:79:69: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_health_test.go:51:57: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_health_test.go:159:73: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_swarm_unix_test.go:60:67: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_inspect_test.go:30:33: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_build_test.go:429:71: empty-lines: extra empty line at the start of a block (revive)
integration-cli/docker_cli_attach_unix_test.go:19:78: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_build_test.go:470:70: empty-lines: extra empty line at the start of a block (revive)
integration-cli/docker_cli_history_test.go:29:64: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_links_test.go:93:86: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_create_test.go:33:61: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_links_test.go:145:78: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_create_test.go:114:70: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_attach_test.go:226:153: empty-lines: extra empty line at the start of a block (revive)
integration-cli/docker_cli_by_digest_test.go:239:71: empty-lines: extra empty line at the start of a block (revive)
integration-cli/docker_cli_create_test.go:135:49: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_create_test.go:143:75: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_create_test.go:181:71: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_inspect_test.go:72:65: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_swarm_service_test.go:98:77: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_swarm_service_test.go:144:69: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_rmi_test.go:63:2: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_swarm_service_test.go:199:79: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_rmi_test.go:69:2: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_swarm_service_test.go:300:75: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_prune_unix_test.go:35:25: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_events_unix_test.go:393:60: empty-lines: extra empty line at the start of a block (revive)
integration-cli/docker_cli_events_unix_test.go:441:71: empty-lines: extra empty line at the start of a block (revive)
integration-cli/docker_cli_ps_test.go:33:67: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_ps_test.go:559:67: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_events_test.go:117:75: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_containers_test.go:547:74: empty-lines: extra empty line at the start of a block (revive)
integration-cli/docker_api_containers_test.go:1054:84: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_containers_test.go:1076:87: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_containers_test.go:1232:72: empty-lines: extra empty line at the start of a block (revive)
integration-cli/docker_api_containers_test.go:1801:21: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_network_unix_test.go:58:95: empty-lines: extra empty line at the start of a block (revive)
integration-cli/docker_cli_network_unix_test.go:750:75: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_network_unix_test.go:765:76: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_swarm_test.go:617:100: empty-lines: extra empty line at the start of a block (revive)
integration-cli/docker_cli_swarm_test.go:892:72: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_daemon_test.go:119:74: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_daemon_test.go:981:68: empty-lines: extra empty line at the start of a block (revive)
integration-cli/docker_cli_daemon_test.go:1951:87: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_run_test.go:83:66: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_run_test.go:357:72: empty-lines: extra empty line at the start of a block (revive)
integration-cli/docker_cli_build_test.go:89:83: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:114:83: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:183:80: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:290:71: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:314:65: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:331:67: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:366:76: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:403:67: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:648:67: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:708:72: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:938:66: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:1018:72: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:1097:2: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:1182:62: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:1244:66: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:1524:69: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:1546:80: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:1716:70: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:1730:65: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:2162:74: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:2270:71: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:2288:70: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:3206:65: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:3392:66: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:3433:72: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:3678:76: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:3732:67: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:3759:69: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:3802:61: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:3898:66: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:4107:9: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:4791:74: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:4821:73: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:4854:70: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:5341:74: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_cli_build_test.go:5593:81: empty-lines: extra empty line at the end of a block (revive)
integration-cli/docker_api_containers_test.go:2145:11: empty-lines: extra empty line at the start of a block (revive)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
| ... | ... |
@@ -224,7 +224,6 @@ func (s *DockerAPISuite) TestPostContainersAttach(c *testing.T) {
|
| 224 | 224 |
// , contenttype, …), if receive a successful "101 Switching Protocols" response return |
| 225 | 225 |
// a `io.WriteCloser` and `bufio.Reader` |
| 226 | 226 |
func requestHijack(method, endpoint string, data io.Reader, ct, daemon string, modifiers ...func(*http.Request)) (io.WriteCloser, *bufio.Reader, error) {
|
| 227 |
- |
|
| 228 | 227 |
hostURL, err := client.ParseHostURL(daemon) |
| 229 | 228 |
if err != nil {
|
| 230 | 229 |
return nil, nil, errors.Wrap(err, "parse daemon host error") |
| ... | ... |
@@ -427,7 +427,6 @@ func (s *DockerAPISuite) TestBuildChownOnCopy(c *testing.T) {
|
| 427 | 427 |
} |
| 428 | 428 |
|
| 429 | 429 |
func (s *DockerAPISuite) TestBuildCopyCacheOnFileChange(c *testing.T) {
|
| 430 |
- |
|
| 431 | 430 |
dockerfile := `FROM busybox |
| 432 | 431 |
COPY file /file` |
| 433 | 432 |
|
| ... | ... |
@@ -468,7 +467,6 @@ COPY file /file` |
| 468 | 468 |
} |
| 469 | 469 |
|
| 470 | 470 |
func (s *DockerAPISuite) TestBuildAddCacheOnFileChange(c *testing.T) {
|
| 471 |
- |
|
| 472 | 471 |
dockerfile := `FROM busybox |
| 473 | 472 |
ADD file /file` |
| 474 | 473 |
|
| ... | ... |
@@ -545,7 +545,6 @@ func (s *DockerAPISuite) TestContainerAPICreate(c *testing.T) {
|
| 545 | 545 |
} |
| 546 | 546 |
|
| 547 | 547 |
func (s *DockerAPISuite) TestContainerAPICreateEmptyConfig(c *testing.T) {
|
| 548 |
- |
|
| 549 | 548 |
cli, err := client.NewClientWithOpts(client.FromEnv) |
| 550 | 549 |
assert.NilError(c, err) |
| 551 | 550 |
defer cli.Close() |
| ... | ... |
@@ -1070,7 +1069,6 @@ func (s *DockerAPISuite) TestContainerAPICopyResourcePathEmptyPre124(c *testing. |
| 1070 | 1070 |
b, err := request.ReadBody(body) |
| 1071 | 1071 |
assert.NilError(c, err) |
| 1072 | 1072 |
assert.Assert(c, is.Regexp("^Path cannot be empty\n$", string(b)))
|
| 1073 |
- |
|
| 1074 | 1073 |
} |
| 1075 | 1074 |
|
| 1076 | 1075 |
func (s *DockerAPISuite) TestContainerAPICopyResourcePathNotFoundPre124(c *testing.T) {
|
| ... | ... |
@@ -1092,7 +1090,6 @@ func (s *DockerAPISuite) TestContainerAPICopyResourcePathNotFoundPre124(c *testi |
| 1092 | 1092 |
b, err := request.ReadBody(body) |
| 1093 | 1093 |
assert.NilError(c, err) |
| 1094 | 1094 |
assert.Assert(c, is.Regexp("^Could not find the file /notexist in container "+name+"\n$", string(b)))
|
| 1095 |
- |
|
| 1096 | 1095 |
} |
| 1097 | 1096 |
|
| 1098 | 1097 |
func (s *DockerAPISuite) TestContainerAPICopyContainerNotFoundPr124(c *testing.T) {
|
| ... | ... |
@@ -1230,7 +1227,6 @@ func (s *DockerAPISuite) TestContainerAPIDeleteRemoveVolume(c *testing.T) {
|
| 1230 | 1230 |
|
| 1231 | 1231 |
// Regression test for https://github.com/docker/docker/issues/6231 |
| 1232 | 1232 |
func (s *DockerAPISuite) TestContainerAPIChunkedEncoding(c *testing.T) {
|
| 1233 |
- |
|
| 1234 | 1233 |
config := map[string]interface{}{
|
| 1235 | 1234 |
"Image": "busybox", |
| 1236 | 1235 |
"Cmd": append([]string{"/bin/sh", "-c"}, sleepCommandForDaemonPlatform()...),
|
| ... | ... |
@@ -1920,7 +1916,6 @@ func (s *DockerAPISuite) TestContainersAPICreateMountsValidation(c *testing.T) {
|
| 1920 | 1920 |
msg: "Source must not be specified", |
| 1921 | 1921 |
}, |
| 1922 | 1922 |
}...) |
| 1923 |
- |
|
| 1924 | 1923 |
} |
| 1925 | 1924 |
apiClient, err := client.NewClientWithOpts(client.FromEnv) |
| 1926 | 1925 |
assert.NilError(c, err) |
| ... | ... |
@@ -2148,7 +2143,6 @@ func (s *DockerAPISuite) TestContainersAPICreateMountsCreate(c *testing.T) {
|
| 2148 | 2148 |
assert.NilError(c, err) |
| 2149 | 2149 |
|
| 2150 | 2150 |
switch {
|
| 2151 |
- |
|
| 2152 | 2151 |
// Named volumes still exist after the container is removed |
| 2153 | 2152 |
case x.spec.Type == "volume" && len(x.spec.Source) > 0: |
| 2154 | 2153 |
_, err := apiclient.VolumeInspect(ctx, mountPoint.Name) |
| ... | ... |
@@ -31,7 +31,6 @@ func (s *DockerAPISuite) TestInspectAPIContainerResponse(c *testing.T) {
|
| 31 | 31 |
cases = []acase{
|
| 32 | 32 |
{"v1.25", append(keysBase, "Mounts")},
|
| 33 | 33 |
} |
| 34 |
- |
|
| 35 | 34 |
} else {
|
| 36 | 35 |
cases = []acase{
|
| 37 | 36 |
{"v1.20", append(keysBase, "Mounts")},
|
| ... | ... |
@@ -51,7 +50,7 @@ func (s *DockerAPISuite) TestInspectAPIContainerResponse(c *testing.T) {
|
| 51 | 51 |
assert.Check(c, ok, "%s does not exist in response for version %s", key, cs.version) |
| 52 | 52 |
} |
| 53 | 53 |
|
| 54 |
- //Issue #6830: type not properly converted to JSON/back |
|
| 54 |
+ // Issue #6830: type not properly converted to JSON/back |
|
| 55 | 55 |
_, ok := inspectJSON["Path"].(bool) |
| 56 | 56 |
assert.Assert(c, !ok, "Path of `true` should not be converted to boolean `true` via JSON marshalling") |
| 57 | 57 |
} |
| ... | ... |
@@ -125,5 +125,4 @@ func (s *DockerSwarmSuite) TestAPISwarmNodeDrainPause(c *testing.T) {
|
| 125 | 125 |
d1.UpdateService(c, d1.GetService(c, id), setInstances(instances)) |
| 126 | 126 |
poll.WaitOn(c, pollCheck(c, d1.CheckActiveContainerCount, checker.Equals(instances-d2ContainerCount)), poll.WithTimeout(defaultReconciliationTimeout)) |
| 127 | 127 |
poll.WaitOn(c, pollCheck(c, d2.CheckActiveContainerCount, checker.Equals(d2ContainerCount)), poll.WithTimeout(defaultReconciliationTimeout)) |
| 128 |
- |
|
| 129 | 128 |
} |
| ... | ... |
@@ -120,7 +120,6 @@ func (s *DockerSwarmSuite) TestAPISwarmServicesMultipleAgents(c *testing.T) {
|
| 120 | 120 |
instances = 5 |
| 121 | 121 |
d1.UpdateService(c, d1.GetService(c, id), setInstances(instances)) |
| 122 | 122 |
poll.WaitOn(c, pollCheck(c, reducedCheck(sumAsIntegers, d1.CheckActiveContainerCount, d3.CheckActiveContainerCount), checker.Equals(instances)), poll.WithTimeout(defaultReconciliationTimeout)) |
| 123 |
- |
|
| 124 | 123 |
} |
| 125 | 124 |
|
| 126 | 125 |
func (s *DockerSwarmSuite) TestAPISwarmServicesCreateGlobal(c *testing.T) {
|
| ... | ... |
@@ -193,7 +192,6 @@ func (s *DockerSwarmSuite) TestAPISwarmServicesUpdate(c *testing.T) {
|
| 193 | 193 |
|
| 194 | 194 |
// 2nd batch |
| 195 | 195 |
poll.WaitOn(c, pollCheck(c, daemons[0].CheckRunningTaskImages, checker.DeepEquals(map[string]int{image1: instances})), poll.WithTimeout(defaultReconciliationTimeout))
|
| 196 |
- |
|
| 197 | 196 |
} |
| 198 | 197 |
|
| 199 | 198 |
func (s *DockerSwarmSuite) TestAPISwarmServicesUpdateStartFirst(c *testing.T) {
|
| ... | ... |
@@ -294,7 +292,6 @@ func (s *DockerSwarmSuite) TestAPISwarmServicesUpdateStartFirst(c *testing.T) {
|
| 294 | 294 |
|
| 295 | 295 |
// 2nd batch |
| 296 | 296 |
poll.WaitOn(c, pollCheck(c, d.CheckRunningTaskImages, checker.DeepEquals(map[string]int{image1: instances})), poll.WithTimeout(defaultReconciliationTimeout))
|
| 297 |
- |
|
| 298 | 297 |
} |
| 299 | 298 |
|
| 300 | 299 |
func (s *DockerSwarmSuite) TestAPISwarmServicesFailedUpdate(c *testing.T) {
|
| ... | ... |
@@ -333,7 +330,6 @@ func (s *DockerSwarmSuite) TestAPISwarmServicesFailedUpdate(c *testing.T) {
|
| 333 | 333 |
assert.NilError(c, err, out) |
| 334 | 334 |
|
| 335 | 335 |
poll.WaitOn(c, pollCheck(c, daemons[0].CheckRunningTaskImages, checker.DeepEquals(map[string]int{image1: instances})), poll.WithTimeout(defaultReconciliationTimeout))
|
| 336 |
- |
|
| 337 | 336 |
} |
| 338 | 337 |
|
| 339 | 338 |
func (s *DockerSwarmSuite) TestAPISwarmServiceConstraintRole(c *testing.T) {
|
| ... | ... |
@@ -108,7 +108,6 @@ func (s *DockerCLIBuildSuite) TestBuildEnvironmentReplacementVolume(c *testing.T |
| 108 | 108 |
if _, ok := volumes[volumePath]; !ok {
|
| 109 | 109 |
c.Fatal("Volume " + volumePath + " from environment not in Config.Volumes on image")
|
| 110 | 110 |
} |
| 111 |
- |
|
| 112 | 111 |
} |
| 113 | 112 |
|
| 114 | 113 |
func (s *DockerCLIBuildSuite) TestBuildEnvironmentReplacementExpose(c *testing.T) {
|
| ... | ... |
@@ -133,7 +132,6 @@ func (s *DockerCLIBuildSuite) TestBuildEnvironmentReplacementExpose(c *testing.T |
| 133 | 133 |
c.Fatalf("Exposed port %d from environment not in Config.ExposedPorts on image", p)
|
| 134 | 134 |
} |
| 135 | 135 |
} |
| 136 |
- |
|
| 137 | 136 |
} |
| 138 | 137 |
|
| 139 | 138 |
func (s *DockerCLIBuildSuite) TestBuildEnvironmentReplacementWorkdir(c *testing.T) {
|
| ... | ... |
@@ -240,7 +238,6 @@ func (s *DockerCLIBuildSuite) TestBuildEnvironmentReplacementEnv(c *testing.T) {
|
| 240 | 240 |
if envCount != 4 {
|
| 241 | 241 |
c.Fatalf("Didn't find all env vars - only saw %d\n%s", envCount, envResult)
|
| 242 | 242 |
} |
| 243 |
- |
|
| 244 | 243 |
} |
| 245 | 244 |
|
| 246 | 245 |
func (s *DockerCLIBuildSuite) TestBuildHandleEscapesInVolume(c *testing.T) {
|
| ... | ... |
@@ -308,7 +305,6 @@ func (s *DockerCLIBuildSuite) TestBuildOnBuildLowercase(c *testing.T) {
|
| 308 | 308 |
if strings.Contains(result.Combined(), "ONBUILD ONBUILD") {
|
| 309 | 309 |
c.Fatalf("Got an ONBUILD ONBUILD error with no error: got %s", result.Combined())
|
| 310 | 310 |
} |
| 311 |
- |
|
| 312 | 311 |
} |
| 313 | 312 |
|
| 314 | 313 |
func (s *DockerCLIBuildSuite) TestBuildEnvEscapes(c *testing.T) {
|
| ... | ... |
@@ -325,7 +321,6 @@ func (s *DockerCLIBuildSuite) TestBuildEnvEscapes(c *testing.T) {
|
| 325 | 325 |
if strings.TrimSpace(out) != "$" {
|
| 326 | 326 |
c.Fatalf("Env TEST was not overwritten with bar when foo was supplied to dockerfile: was %q", strings.TrimSpace(out))
|
| 327 | 327 |
} |
| 328 |
- |
|
| 329 | 328 |
} |
| 330 | 329 |
|
| 331 | 330 |
func (s *DockerCLIBuildSuite) TestBuildEnvOverwrite(c *testing.T) {
|
| ... | ... |
@@ -342,7 +337,6 @@ func (s *DockerCLIBuildSuite) TestBuildEnvOverwrite(c *testing.T) {
|
| 342 | 342 |
if strings.TrimSpace(out) != "bar" {
|
| 343 | 343 |
c.Fatalf("Env TEST was not overwritten with bar when foo was supplied to dockerfile: was %q", strings.TrimSpace(out))
|
| 344 | 344 |
} |
| 345 |
- |
|
| 346 | 345 |
} |
| 347 | 346 |
|
| 348 | 347 |
// FIXME(vdemeester) why we disabled cache here ? |
| ... | ... |
@@ -377,7 +371,6 @@ ONBUILD ENTRYPOINT ["echo"]`)) |
| 377 | 377 |
if !regexp.MustCompile(`(?m)^hello world`).MatchString(out) {
|
| 378 | 378 |
c.Fatal("got malformed output from onbuild", out)
|
| 379 | 379 |
} |
| 380 |
- |
|
| 381 | 380 |
} |
| 382 | 381 |
|
| 383 | 382 |
func (s *DockerCLIBuildSuite) TestBuildCacheAdd(c *testing.T) {
|
| ... | ... |
@@ -447,7 +440,6 @@ ADD %s/file /` |
| 447 | 447 |
if out == out2 {
|
| 448 | 448 |
c.Fatalf("MTime didn't change:\nOrigin:%s\nNew:%s", out, out2)
|
| 449 | 449 |
} |
| 450 |
- |
|
| 451 | 450 |
} |
| 452 | 451 |
|
| 453 | 452 |
// Regression for https://github.com/docker/docker/pull/27805 |
| ... | ... |
@@ -682,7 +674,6 @@ func (s *DockerCLIBuildSuite) TestBuildCopyWildcard(c *testing.T) {
|
| 682 | 682 |
if id1 != id2 {
|
| 683 | 683 |
c.Fatal("didn't use the cache")
|
| 684 | 684 |
} |
| 685 |
- |
|
| 686 | 685 |
} |
| 687 | 686 |
|
| 688 | 687 |
func (s *DockerCLIBuildSuite) TestBuildCopyWildcardInName(c *testing.T) {
|
| ... | ... |
@@ -728,7 +719,6 @@ func (s *DockerCLIBuildSuite) TestBuildCopyWildcardCache(c *testing.T) {
|
| 728 | 728 |
if id1 != id2 {
|
| 729 | 729 |
c.Fatal("didn't use the cache")
|
| 730 | 730 |
} |
| 731 |
- |
|
| 732 | 731 |
} |
| 733 | 732 |
|
| 734 | 733 |
func (s *DockerCLIBuildSuite) TestBuildAddSingleFileToNonExistingDir(c *testing.T) {
|
| ... | ... |
@@ -1012,7 +1002,6 @@ func (s *DockerCLIBuildSuite) TestBuildAddBadLinks(c *testing.T) {
|
| 1012 | 1012 |
if _, err := os.Stat(nonExistingFile); err == nil || !os.IsNotExist(err) {
|
| 1013 | 1013 |
c.Fatalf("%s shouldn't have been written and it shouldn't exist", nonExistingFile)
|
| 1014 | 1014 |
} |
| 1015 |
- |
|
| 1016 | 1015 |
} |
| 1017 | 1016 |
|
| 1018 | 1017 |
func (s *DockerCLIBuildSuite) TestBuildAddBadLinksVolume(c *testing.T) {
|
| ... | ... |
@@ -1053,7 +1042,6 @@ func (s *DockerCLIBuildSuite) TestBuildAddBadLinksVolume(c *testing.T) {
|
| 1053 | 1053 |
if _, err := os.Stat(nonExistingFile); err == nil || !os.IsNotExist(err) {
|
| 1054 | 1054 |
c.Fatalf("%s shouldn't have been written and it shouldn't exist", nonExistingFile)
|
| 1055 | 1055 |
} |
| 1056 |
- |
|
| 1057 | 1056 |
} |
| 1058 | 1057 |
|
| 1059 | 1058 |
// Issue #5270 - ensure we throw a better error than "unexpected EOF" |
| ... | ... |
@@ -1131,7 +1119,6 @@ func (s *DockerCLIBuildSuite) TestBuildWithInaccessibleFilesInContext(c *testing |
| 1131 | 1131 |
if !strings.Contains(result.Combined(), "error checking context") {
|
| 1132 | 1132 |
c.Fatalf("output should've contained the string: error checking context\ngot:%s", result.Combined())
|
| 1133 | 1133 |
} |
| 1134 |
- |
|
| 1135 | 1134 |
} |
| 1136 | 1135 |
{
|
| 1137 | 1136 |
name := "testlinksok" |
| ... | ... |
@@ -1195,7 +1182,6 @@ func (s *DockerCLIBuildSuite) TestBuildForceRm(c *testing.T) {
|
| 1195 | 1195 |
if containerCountBefore != containerCountAfter {
|
| 1196 | 1196 |
c.Fatalf("--force-rm shouldn't have left containers behind")
|
| 1197 | 1197 |
} |
| 1198 |
- |
|
| 1199 | 1198 |
} |
| 1200 | 1199 |
|
| 1201 | 1200 |
func (s *DockerCLIBuildSuite) TestBuildRm(c *testing.T) {
|
| ... | ... |
@@ -1273,7 +1259,6 @@ func (s *DockerCLIBuildSuite) TestBuildWithVolumes(c *testing.T) {
|
| 1273 | 1273 |
if !equal {
|
| 1274 | 1274 |
c.Fatalf("Volumes %s, expected %s", result, expected)
|
| 1275 | 1275 |
} |
| 1276 |
- |
|
| 1277 | 1276 |
} |
| 1278 | 1277 |
|
| 1279 | 1278 |
func (s *DockerCLIBuildSuite) TestBuildMaintainer(c *testing.T) {
|
| ... | ... |
@@ -1540,7 +1525,6 @@ func (s *DockerCLIBuildSuite) TestBuildContextCleanup(c *testing.T) {
|
| 1540 | 1540 |
if err = compareDirectoryEntries(entries, entriesFinal); err != nil {
|
| 1541 | 1541 |
c.Fatalf("context should have been deleted, but wasn't")
|
| 1542 | 1542 |
} |
| 1543 |
- |
|
| 1544 | 1543 |
} |
| 1545 | 1544 |
|
| 1546 | 1545 |
func (s *DockerCLIBuildSuite) TestBuildContextCleanupFailedBuild(c *testing.T) {
|
| ... | ... |
@@ -1564,7 +1548,6 @@ func (s *DockerCLIBuildSuite) TestBuildContextCleanupFailedBuild(c *testing.T) {
|
| 1564 | 1564 |
if err = compareDirectoryEntries(entries, entriesFinal); err != nil {
|
| 1565 | 1565 |
c.Fatalf("context should have been deleted, but wasn't")
|
| 1566 | 1566 |
} |
| 1567 |
- |
|
| 1568 | 1567 |
} |
| 1569 | 1568 |
|
| 1570 | 1569 |
// compareDirectoryEntries compares two sets of DirEntry (usually taken from a directory) |
| ... | ... |
@@ -1724,7 +1707,6 @@ func (s *DockerCLIBuildSuite) TestBuildEmptyEntrypoint(c *testing.T) {
|
| 1724 | 1724 |
if res != expected {
|
| 1725 | 1725 |
c.Fatalf("Entrypoint %s, expected %s", res, expected)
|
| 1726 | 1726 |
} |
| 1727 |
- |
|
| 1728 | 1727 |
} |
| 1729 | 1728 |
|
| 1730 | 1729 |
func (s *DockerCLIBuildSuite) TestBuildEntrypoint(c *testing.T) {
|
| ... | ... |
@@ -1738,7 +1720,6 @@ func (s *DockerCLIBuildSuite) TestBuildEntrypoint(c *testing.T) {
|
| 1738 | 1738 |
if res != expected {
|
| 1739 | 1739 |
c.Fatalf("Entrypoint %s, expected %s", res, expected)
|
| 1740 | 1740 |
} |
| 1741 |
- |
|
| 1742 | 1741 |
} |
| 1743 | 1742 |
|
| 1744 | 1743 |
// #6445 ensure ONBUILD triggers aren't committed to grandchildren |
| ... | ... |
@@ -2174,7 +2155,6 @@ func (s *DockerCLIBuildSuite) TestBuildWithVolumeOwnership(c *testing.T) {
|
| 2174 | 2174 |
if expected := "daemon daemon"; !strings.Contains(out, expected) {
|
| 2175 | 2175 |
c.Fatalf("expected %s received %s", expected, out)
|
| 2176 | 2176 |
} |
| 2177 |
- |
|
| 2178 | 2177 |
} |
| 2179 | 2178 |
|
| 2180 | 2179 |
// testing #1405 - config.Cmd does not get cleaned up if |
| ... | ... |
@@ -2282,7 +2262,6 @@ docker.com>" |
| 2282 | 2282 |
if res != "\"Docker IO <io@docker.com>\"" {
|
| 2283 | 2283 |
c.Fatalf("Parsed string did not match the escaped string. Got: %q", res)
|
| 2284 | 2284 |
} |
| 2285 |
- |
|
| 2286 | 2285 |
} |
| 2287 | 2286 |
|
| 2288 | 2287 |
func (s *DockerCLIBuildSuite) TestBuildVerifyIntString(c *testing.T) {
|
| ... | ... |
@@ -2297,7 +2276,6 @@ func (s *DockerCLIBuildSuite) TestBuildVerifyIntString(c *testing.T) {
|
| 2297 | 2297 |
if !strings.Contains(out, "\"123\"") {
|
| 2298 | 2298 |
c.Fatalf("Output does not contain the int as a string:\n%s", out)
|
| 2299 | 2299 |
} |
| 2300 |
- |
|
| 2301 | 2300 |
} |
| 2302 | 2301 |
|
| 2303 | 2302 |
func (s *DockerCLIBuildSuite) TestBuildDockerignore(c *testing.T) {
|
| ... | ... |
@@ -3215,7 +3193,6 @@ func (s *DockerCLIBuildSuite) TestBuildCmdShDashC(c *testing.T) {
|
| 3215 | 3215 |
if res != expected {
|
| 3216 | 3216 |
c.Fatalf("Expected value %s not in Config.Cmd: %s", expected, res)
|
| 3217 | 3217 |
} |
| 3218 |
- |
|
| 3219 | 3218 |
} |
| 3220 | 3219 |
|
| 3221 | 3220 |
func (s *DockerCLIBuildSuite) TestBuildCmdSpaces(c *testing.T) {
|
| ... | ... |
@@ -3426,7 +3403,6 @@ func (s *DockerCLIBuildSuite) TestBuildLabelsCache(c *testing.T) {
|
| 3426 | 3426 |
if id1 == id2 {
|
| 3427 | 3427 |
c.Fatalf("Build 6 should have worked & NOT used the cache(%s,%s)", id1, id2)
|
| 3428 | 3428 |
} |
| 3429 |
- |
|
| 3430 | 3429 |
} |
| 3431 | 3430 |
|
| 3432 | 3431 |
// FIXME(vdemeester) port to docker/cli e2e tests (api tests should test suppressOutput option though) |
| ... | ... |
@@ -3477,7 +3453,6 @@ func (s *DockerCLIBuildSuite) TestBuildNotVerboseSuccess(c *testing.T) {
|
| 3477 | 3477 |
c.Fatalf("Test %s expected stderr to be empty, but it is [%#v]", te.Name, result.Stderr())
|
| 3478 | 3478 |
} |
| 3479 | 3479 |
} |
| 3480 |
- |
|
| 3481 | 3480 |
} |
| 3482 | 3481 |
|
| 3483 | 3482 |
// FIXME(vdemeester) migrate to docker/cli tests |
| ... | ... |
@@ -3702,7 +3677,6 @@ CMD cat /foo/file`), |
| 3702 | 3702 |
if out != expected {
|
| 3703 | 3703 |
c.Fatalf("expected file contents for /foo/file to be %q but received %q", expected, out)
|
| 3704 | 3704 |
} |
| 3705 |
- |
|
| 3706 | 3705 |
} |
| 3707 | 3706 |
|
| 3708 | 3707 |
func (s *DockerCLIBuildSuite) TestBuildFromMixedcaseDockerfile(c *testing.T) {
|
| ... | ... |
@@ -3752,7 +3726,6 @@ RUN find /tmp/`})) |
| 3752 | 3752 |
!strings.Contains(result.Combined(), "/tmp/Dockerfile") {
|
| 3753 | 3753 |
c.Fatalf("Missing proper output: %s", result.Combined())
|
| 3754 | 3754 |
} |
| 3755 |
- |
|
| 3756 | 3755 |
} |
| 3757 | 3756 |
|
| 3758 | 3757 |
// FIXME(vdemeester) should migrate to docker/cli tests |
| ... | ... |
@@ -3778,7 +3751,6 @@ RUN sh -c "find /tmp/" # sh -c is needed on Windows to use the correct find`) |
| 3778 | 3778 |
!strings.Contains(result.Combined(), "/tmp/Dockerfile") {
|
| 3779 | 3779 |
c.Fatalf("Missing proper output: %s", result.Combined())
|
| 3780 | 3780 |
} |
| 3781 |
- |
|
| 3782 | 3781 |
} |
| 3783 | 3782 |
|
| 3784 | 3783 |
func (s *DockerCLIBuildSuite) TestBuildFromOfficialNames(c *testing.T) {
|
| ... | ... |
@@ -3859,7 +3831,6 @@ func (s *DockerCLIBuildSuite) TestBuildSpaces(c *testing.T) {
|
| 3859 | 3859 |
if strings.ReplaceAll(e1, " ", "") != strings.ReplaceAll(e2, " ", "") {
|
| 3860 | 3860 |
c.Fatalf("Build 4's error wasn't the same as build 1's\n1:%s\n4:%s", result1.Error, result2.Error)
|
| 3861 | 3861 |
} |
| 3862 |
- |
|
| 3863 | 3862 |
} |
| 3864 | 3863 |
|
| 3865 | 3864 |
func (s *DockerCLIBuildSuite) TestBuildSpacesWithQuotes(c *testing.T) {
|
| ... | ... |
@@ -3937,7 +3908,6 @@ func (s *DockerCLIBuildSuite) TestBuildMissingArgs(c *testing.T) {
|
| 3937 | 3937 |
Err: cmd + " requires", |
| 3938 | 3938 |
}) |
| 3939 | 3939 |
} |
| 3940 |
- |
|
| 3941 | 3940 |
} |
| 3942 | 3941 |
|
| 3943 | 3942 |
func (s *DockerCLIBuildSuite) TestBuildEmptyScratch(c *testing.T) {
|
| ... | ... |
@@ -4109,7 +4079,6 @@ func (s *DockerCLIBuildSuite) TestBuildBuildTimeArg(c *testing.T) {
|
| 4109 | 4109 |
ARG %s |
| 4110 | 4110 |
RUN echo $%s |
| 4111 | 4111 |
CMD echo $%s`, envKey, envKey, envKey) |
| 4112 |
- |
|
| 4113 | 4112 |
} |
| 4114 | 4113 |
buildImage(imgName, |
| 4115 | 4114 |
cli.WithFlags("--build-arg", fmt.Sprintf("%s=%s", envKey, envVal)),
|
| ... | ... |
@@ -4846,7 +4815,6 @@ func (s *DockerCLIBuildSuite) TestBuildFollowSymlinkToDir(c *testing.T) {
|
| 4846 | 4846 |
assert.Assert(c, !strings.Contains(result.Combined(), "Using cache")) |
| 4847 | 4847 |
out = cli.DockerCmd(c, "run", "--rm", name, "cat", "abc", "def").Combined() |
| 4848 | 4848 |
assert.Assert(c, cmp.Regexp("^barbax$", out))
|
| 4849 |
- |
|
| 4850 | 4849 |
} |
| 4851 | 4850 |
|
| 4852 | 4851 |
// TestBuildSymlinkBasename tests that target file gets basename from symlink, |
| ... | ... |
@@ -4869,7 +4837,6 @@ func (s *DockerCLIBuildSuite) TestBuildSymlinkBasename(c *testing.T) {
|
| 4869 | 4869 |
|
| 4870 | 4870 |
out := cli.DockerCmd(c, "run", "--rm", name, "cat", "asymlink").Combined() |
| 4871 | 4871 |
assert.Assert(c, cmp.Regexp("^bar$", out))
|
| 4872 |
- |
|
| 4873 | 4872 |
} |
| 4874 | 4873 |
|
| 4875 | 4874 |
// #17827 |
| ... | ... |
@@ -5374,7 +5341,6 @@ func (s *DockerCLIBuildSuite) TestBuildCmdShellArgsEscaped(c *testing.T) {
|
| 5374 | 5374 |
if res != `["ipconfig"]` {
|
| 5375 | 5375 |
c.Fatalf("CMD incorrect in Config.Cmd: got %v", res)
|
| 5376 | 5376 |
} |
| 5377 |
- |
|
| 5378 | 5377 |
} |
| 5379 | 5378 |
|
| 5380 | 5379 |
// Test case for #24912. |
| ... | ... |
@@ -5614,7 +5580,6 @@ func (s *DockerCLIBuildSuite) TestBuildWithExtraHostInvalidFormat(c *testing.T) |
| 5614 | 5614 |
ExitCode: 125, |
| 5615 | 5615 |
}) |
| 5616 | 5616 |
} |
| 5617 |
- |
|
| 5618 | 5617 |
} |
| 5619 | 5618 |
|
| 5620 | 5619 |
func (s *DockerCLIBuildSuite) TestBuildMultiStageCopyFromSyntax(c *testing.T) {
|
| ... | ... |
@@ -237,7 +237,6 @@ func (s *DockerRegistrySuite) TestListImagesWithoutDigests(c *testing.T) {
|
| 237 | 237 |
} |
| 238 | 238 |
|
| 239 | 239 |
func (s *DockerRegistrySuite) TestListImagesWithDigests(c *testing.T) {
|
| 240 |
- |
|
| 241 | 240 |
// setup image1 |
| 242 | 241 |
digest1, err := setupImageWithTag(c, "tag1") |
| 243 | 242 |
assert.NilError(c, err, "error setting up image") |
| ... | ... |
@@ -330,7 +329,7 @@ func (s *DockerRegistrySuite) TestListDanglingImagesWithDigests(c *testing.T) {
|
| 330 | 330 |
assert.Assert(c, re1.MatchString(out), "expected %q: %s", re1.String(), out) |
| 331 | 331 |
// setup image2 |
| 332 | 332 |
digest2, err := setupImageWithTag(c, "dangle2") |
| 333 |
- //error setting up image |
|
| 333 |
+ // error setting up image |
|
| 334 | 334 |
assert.NilError(c, err) |
| 335 | 335 |
imageReference2 := fmt.Sprintf("%s@%s", repoName, digest2)
|
| 336 | 336 |
c.Logf("imageReference2 = %s", imageReference2)
|
| ... | ... |
@@ -61,7 +61,6 @@ func (s *DockerCLICreateSuite) TestCreateArgs(c *testing.T) {
|
| 61 | 61 |
if len(cont.Args) != len(expected) || b {
|
| 62 | 62 |
c.Fatalf("Unexpected args. Expected %v, received: %v", expected, cont.Args)
|
| 63 | 63 |
} |
| 64 |
- |
|
| 65 | 64 |
} |
| 66 | 65 |
|
| 67 | 66 |
// Make sure we can grow the container's rootfs at creation time. |
| ... | ... |
@@ -135,9 +134,7 @@ func (s *DockerCLICreateSuite) TestCreateWithPortRange(c *testing.T) {
|
| 135 | 135 |
for k, v := range cont.HostConfig.PortBindings {
|
| 136 | 136 |
assert.Equal(c, len(v), 1, fmt.Sprintf("Expected 1 ports binding, for the port %s but found %s", k, v))
|
| 137 | 137 |
assert.Equal(c, k.Port(), v[0].HostPort, fmt.Sprintf("Expected host port %s to match published port %s", k.Port(), v[0].HostPort))
|
| 138 |
- |
|
| 139 | 138 |
} |
| 140 |
- |
|
| 141 | 139 |
} |
| 142 | 140 |
|
| 143 | 141 |
func (s *DockerCLICreateSuite) TestCreateWithLargePortRange(c *testing.T) {
|
| ... | ... |
@@ -165,7 +162,6 @@ func (s *DockerCLICreateSuite) TestCreateWithLargePortRange(c *testing.T) {
|
| 165 | 165 |
assert.Equal(c, len(v), 1) |
| 166 | 166 |
assert.Equal(c, k.Port(), v[0].HostPort, fmt.Sprintf("Expected host port %s to match published port %s", k.Port(), v[0].HostPort))
|
| 167 | 167 |
} |
| 168 |
- |
|
| 169 | 168 |
} |
| 170 | 169 |
|
| 171 | 170 |
// "test123" should be printed by docker create + start |
| ... | ... |
@@ -194,7 +190,6 @@ func (s *DockerCLICreateSuite) TestCreateVolumesCreated(c *testing.T) {
|
| 194 | 194 |
if err != nil {
|
| 195 | 195 |
c.Fatalf("Error statting volume host path: %q", err)
|
| 196 | 196 |
} |
| 197 |
- |
|
| 198 | 197 |
} |
| 199 | 198 |
|
| 200 | 199 |
func (s *DockerCLICreateSuite) TestCreateLabels(c *testing.T) {
|
| ... | ... |
@@ -172,7 +172,6 @@ func (s *DockerDaemonSuite) TestDaemonRestartUnlessStopped(c *testing.T) {
|
| 172 | 172 |
|
| 173 | 173 |
// both running |
| 174 | 174 |
testRun(map[string]bool{"top1": true, "top2": true, "exit": true}, "After second daemon restart: ")
|
| 175 |
- |
|
| 176 | 175 |
} |
| 177 | 176 |
|
| 178 | 177 |
func (s *DockerDaemonSuite) TestDaemonRestartOnFailure(c *testing.T) {
|
| ... | ... |
@@ -979,7 +978,6 @@ func (s *DockerDaemonSuite) TestDaemonLinksIpTablesRulesWhenLinkAndUnlink(c *tes |
| 979 | 979 |
} |
| 980 | 980 |
|
| 981 | 981 |
func (s *DockerDaemonSuite) TestDaemonUlimitDefaults(c *testing.T) {
|
| 982 |
- |
|
| 983 | 982 |
s.d.StartWithBusybox(c, "--default-ulimit", "nofile=42:42", "--default-ulimit", "nproc=1024:1024") |
| 984 | 983 |
|
| 985 | 984 |
out, err := s.d.Cmd("run", "--ulimit", "nproc=2048", "--name=test", "busybox", "/bin/sh", "-c", "echo $(ulimit -n); echo $(ulimit -u)")
|
| ... | ... |
@@ -1992,7 +1990,6 @@ func (s *DockerDaemonSuite) TestDaemonRestartWithKilledRunningContainer(t *testi |
| 1992 | 1992 |
if out != "143" {
|
| 1993 | 1993 |
t.Fatalf("Expected exit code '%s' got '%s' for container '%s'\n", "143", out, cid)
|
| 1994 | 1994 |
} |
| 1995 |
- |
|
| 1996 | 1995 |
} |
| 1997 | 1996 |
|
| 1998 | 1997 |
// os.Kill should kill daemon ungracefully, leaving behind live containers. |
| ... | ... |
@@ -117,7 +117,6 @@ func (s *DockerCLIEventSuite) TestEventsContainerEventsAttrSort(c *testing.T) {
|
| 117 | 117 |
if matches["eventType"] == "container" && matches["action"] == "create" {
|
| 118 | 118 |
matchedEvents++ |
| 119 | 119 |
assert.Check(c, strings.Contains(out, "(image=busybox, name=container-events-test)"), "Event attributes not sorted") |
| 120 |
- |
|
| 121 | 120 |
} else if matches["eventType"] == "container" && matches["action"] == "start" {
|
| 122 | 121 |
matchedEvents++ |
| 123 | 122 |
assert.Check(c, strings.Contains(out, "(image=busybox, name=container-events-test)"), "Event attributes not sorted") |
| ... | ... |
@@ -391,7 +391,6 @@ func (s *DockerCLIEventSuite) TestEventsFilterNetworkID(c *testing.T) {
|
| 391 | 391 |
} |
| 392 | 392 |
|
| 393 | 393 |
func (s *DockerDaemonSuite) TestDaemonEvents(c *testing.T) {
|
| 394 |
- |
|
| 395 | 394 |
// daemon config file |
| 396 | 395 |
configFilePath := "test.json" |
| 397 | 396 |
defer os.Remove(configFilePath) |
| ... | ... |
@@ -439,7 +438,6 @@ func (s *DockerDaemonSuite) TestDaemonEvents(c *testing.T) {
|
| 439 | 439 |
} |
| 440 | 440 |
|
| 441 | 441 |
func (s *DockerDaemonSuite) TestDaemonEventsWithFilters(c *testing.T) {
|
| 442 |
- |
|
| 443 | 442 |
// daemon config file |
| 444 | 443 |
configFilePath := "test.json" |
| 445 | 444 |
defer os.Remove(configFilePath) |
| ... | ... |
@@ -152,7 +152,6 @@ func (s *DockerCLIHealthSuite) TestHealth(c *testing.T) {
|
| 152 | 152 |
out, _ = dockerCmd(c, "inspect", |
| 153 | 153 |
"--format={{.Config.Healthcheck.Test}}", imageName)
|
| 154 | 154 |
assert.Equal(c, out, "[CMD cat /my status]\n") |
| 155 |
- |
|
| 156 | 155 |
} |
| 157 | 156 |
|
| 158 | 157 |
// GitHub #33021 |
| ... | ... |
@@ -175,5 +174,4 @@ ENTRYPOINT /bin/sh -c "sleep 600"`)) |
| 175 | 175 |
// Start |
| 176 | 176 |
dockerCmd(c, "start", name) |
| 177 | 177 |
waitForHealthStatus(c, name, "starting", "healthy") |
| 178 |
- |
|
| 179 | 178 |
} |
| ... | ... |
@@ -91,7 +91,6 @@ func (s *DockerCLIInspectSuite) TestInspectStatus(c *testing.T) {
|
| 91 | 91 |
dockerCmd(c, "stop", out) |
| 92 | 92 |
inspectOut = inspectField(c, out, "State.Status") |
| 93 | 93 |
assert.Equal(c, inspectOut, "exited") |
| 94 |
- |
|
| 95 | 94 |
} |
| 96 | 95 |
|
| 97 | 96 |
func (s *DockerCLIInspectSuite) TestInspectTypeFlagContainer(c *testing.T) {
|
| ... | ... |
@@ -148,7 +147,7 @@ func (s *DockerCLIInspectSuite) TestInspectImageFilterInt(c *testing.T) {
|
| 148 | 148 |
size, err := strconv.Atoi(out) |
| 149 | 149 |
assert.Assert(c, err == nil, "failed to inspect size of the image: %s, %v", out, err) |
| 150 | 150 |
|
| 151 |
- //now see if the size turns out to be the same |
|
| 151 |
+ // now see if the size turns out to be the same |
|
| 152 | 152 |
formatStr := fmt.Sprintf("--format={{eq .Size %d}}", size)
|
| 153 | 153 |
out, _ = dockerCmd(c, "inspect", formatStr, imageTest) |
| 154 | 154 |
result, err := strconv.ParseBool(strings.TrimSuffix(out, "\n")) |
| ... | ... |
@@ -170,7 +169,7 @@ func (s *DockerCLIInspectSuite) TestInspectContainerFilterInt(c *testing.T) {
|
| 170 | 170 |
exitCode, err := strconv.Atoi(out) |
| 171 | 171 |
assert.Assert(c, err == nil, "failed to inspect exitcode of the container: %s, %v", out, err) |
| 172 | 172 |
|
| 173 |
- //now get the exit code to verify |
|
| 173 |
+ // now get the exit code to verify |
|
| 174 | 174 |
formatStr := fmt.Sprintf("--format={{eq .State.ExitCode %d}}", exitCode)
|
| 175 | 175 |
out, _ = dockerCmd(c, "inspect", formatStr, id) |
| 176 | 176 |
inspectResult, err := strconv.ParseBool(strings.TrimSuffix(out, "\n")) |
| ... | ... |
@@ -100,7 +100,6 @@ func (s *DockerCLILinksSuite) TestLinksPingLinkedContainersAfterRename(c *testin |
| 100 | 100 |
dockerCmd(c, "run", "--rm", "--link", "container_new:alias1", "--link", "container2:alias2", "busybox", "sh", "-c", "ping -c 1 alias1 -W 1 && ping -c 1 alias2 -W 1") |
| 101 | 101 |
dockerCmd(c, "kill", idA) |
| 102 | 102 |
dockerCmd(c, "kill", idB) |
| 103 |
- |
|
| 104 | 103 |
} |
| 105 | 104 |
|
| 106 | 105 |
func (s *DockerCLILinksSuite) TestLinksInspectLinksStarted(c *testing.T) {
|
| ... | ... |
@@ -147,7 +146,6 @@ func (s *DockerCLILinksSuite) TestLinksNotStartedParentNotFail(c *testing.T) {
|
| 147 | 147 |
dockerCmd(c, "create", "--name=first", "busybox", "top") |
| 148 | 148 |
dockerCmd(c, "create", "--name=second", "--link=first:first", "busybox", "top") |
| 149 | 149 |
dockerCmd(c, "start", "first") |
| 150 |
- |
|
| 151 | 150 |
} |
| 152 | 151 |
|
| 153 | 152 |
func (s *DockerCLILinksSuite) TestLinksHostsFilesInject(c *testing.T) {
|
| ... | ... |
@@ -56,7 +56,6 @@ func (s *DockerNetworkSuite) SetUpSuite(c *testing.T) {
|
| 56 | 56 |
} |
| 57 | 57 |
|
| 58 | 58 |
func setupRemoteNetworkDrivers(c *testing.T, mux *http.ServeMux, url, netDrv, ipamDrv string) {
|
| 59 |
- |
|
| 60 | 59 |
mux.HandleFunc("/Plugin.Activate", func(w http.ResponseWriter, r *http.Request) {
|
| 61 | 60 |
w.Header().Set("Content-Type", "application/vnd.docker.plugins.v1+json")
|
| 62 | 61 |
fmt.Fprintf(w, `{"Implements": ["%s", "%s"]}`, driverapi.NetworkPluginEndpointType, ipamapi.PluginEndpointType)
|
| ... | ... |
@@ -759,7 +758,6 @@ func (s *DockerNetworkSuite) TestDockerNetworkDriverOptions(c *testing.T) {
|
| 759 | 759 |
assert.Equal(c, opts["opt2"], "drv2") |
| 760 | 760 |
dockerCmd(c, "network", "rm", "testopt") |
| 761 | 761 |
assertNwNotAvailable(c, "testopt") |
| 762 |
- |
|
| 763 | 762 |
} |
| 764 | 763 |
|
| 765 | 764 |
func (s *DockerNetworkSuite) TestDockerPluginV2NetworkDriver(c *testing.T) {
|
| ... | ... |
@@ -782,7 +780,6 @@ func (s *DockerNetworkSuite) TestDockerPluginV2NetworkDriver(c *testing.T) {
|
| 782 | 782 |
assertNwIsAvailable(c, "v2net") |
| 783 | 783 |
dockerCmd(c, "network", "rm", "v2net") |
| 784 | 784 |
assertNwNotAvailable(c, "v2net") |
| 785 |
- |
|
| 786 | 785 |
} |
| 787 | 786 |
|
| 788 | 787 |
func (s *DockerDaemonSuite) TestDockerNetworkNoDiscoveryDefaultBridgeNetwork(c *testing.T) {
|
| ... | ... |
@@ -130,7 +130,6 @@ func (s *DockerCLIPsSuite) TestPsListContainersBase(c *testing.T) {
|
| 130 | 130 |
|
| 131 | 131 |
out, _ = dockerCmd(c, "ps", "-f", "since="+firstID, "-f", "before="+fourthID, "-n=1") |
| 132 | 132 |
assert.Equal(c, assertContainerList(RemoveOutputForExistingElements(out, existingContainers), expected), true, fmt.Sprintf("SINCE filter, BEFORE filter, LIMIT: Container list is not in the correct order: \n%s", out))
|
| 133 |
- |
|
| 134 | 133 |
} |
| 135 | 134 |
|
| 136 | 135 |
func assertContainerList(out string, expected []string) bool {
|
| ... | ... |
@@ -602,7 +601,6 @@ func (s *DockerCLIPsSuite) TestPsImageIDAfterUpdate(c *testing.T) {
|
| 602 | 602 |
f := strings.Fields(line) |
| 603 | 603 |
assert.Equal(c, f[1], originalImageID) |
| 604 | 604 |
} |
| 605 |
- |
|
| 606 | 605 |
} |
| 607 | 606 |
|
| 608 | 607 |
func (s *DockerCLIPsSuite) TestPsNotShowPortsOfStoppedContainer(c *testing.T) {
|
| ... | ... |
@@ -120,7 +120,6 @@ func (s *DockerHubPullSuite) TestPullNonExistingImage(c *testing.T) {
|
| 120 | 120 |
assert.Assert(c, !strings.Contains(record.out, "unauthorized"), `message should not contain "unauthorized"`) |
| 121 | 121 |
} |
| 122 | 122 |
} |
| 123 |
- |
|
| 124 | 123 |
} |
| 125 | 124 |
|
| 126 | 125 |
// TestPullFromCentralRegistryImplicitRefParts pulls an image from the central registry and verifies |
| ... | ... |
@@ -63,13 +63,11 @@ func (s *DockerCLIRmiSuite) TestRmiTag(c *testing.T) {
|
| 63 | 63 |
{
|
| 64 | 64 |
imagesAfter, _ := dockerCmd(c, "images", "-a") |
| 65 | 65 |
assert.Equal(c, strings.Count(imagesAfter, "\n"), strings.Count(imagesBefore, "\n")+1, fmt.Sprintf("before: %q\n\nafter: %q\n", imagesBefore, imagesAfter))
|
| 66 |
- |
|
| 67 | 66 |
} |
| 68 | 67 |
dockerCmd(c, "rmi", "utest:tag1") |
| 69 | 68 |
{
|
| 70 | 69 |
imagesAfter, _ := dockerCmd(c, "images", "-a") |
| 71 | 70 |
assert.Equal(c, strings.Count(imagesAfter, "\n"), strings.Count(imagesBefore, "\n"), fmt.Sprintf("before: %q\n\nafter: %q\n", imagesBefore, imagesAfter))
|
| 72 |
- |
|
| 73 | 71 |
} |
| 74 | 72 |
} |
| 75 | 73 |
|
| ... | ... |
@@ -89,7 +89,6 @@ func (s *DockerCLIRunSuite) TestRunLookupGoogleDNS(c *testing.T) {
|
| 89 | 89 |
} else {
|
| 90 | 90 |
dockerCmd(c, "run", "busybox", "nslookup", "google.com") |
| 91 | 91 |
} |
| 92 |
- |
|
| 93 | 92 |
} |
| 94 | 93 |
|
| 95 | 94 |
// the exit code should be 0 |
| ... | ... |
@@ -355,7 +354,6 @@ func (s *DockerCLIRunSuite) TestRunWithDaemonFlags(c *testing.T) {
|
| 355 | 355 |
|
| 356 | 356 |
// Regression test for #4979 |
| 357 | 357 |
func (s *DockerCLIRunSuite) TestRunWithVolumesFromExited(c *testing.T) {
|
| 358 |
- |
|
| 359 | 358 |
var ( |
| 360 | 359 |
out string |
| 361 | 360 |
exitCode int |
| ... | ... |
@@ -615,7 +615,6 @@ const globalNetworkPlugin = "global-network-plugin" |
| 615 | 615 |
const globalIPAMPlugin = "global-ipam-plugin" |
| 616 | 616 |
|
| 617 | 617 |
func setupRemoteGlobalNetworkPlugin(c *testing.T, mux *http.ServeMux, url, netDrv, ipamDrv string) {
|
| 618 |
- |
|
| 619 | 618 |
mux.HandleFunc("/Plugin.Activate", func(w http.ResponseWriter, r *http.Request) {
|
| 620 | 619 |
w.Header().Set("Content-Type", "application/vnd.docker.plugins.v1+json")
|
| 621 | 620 |
fmt.Fprintf(w, `{"Implements": ["%s", "%s"]}`, driverapi.NetworkPluginEndpointType, ipamapi.PluginEndpointType)
|
| ... | ... |
@@ -923,7 +922,6 @@ func (s *DockerSwarmSuite) TestSwarmServiceNetworkUpdate(c *testing.T) {
|
| 923 | 923 |
result.Assert(c, icmd.Success) |
| 924 | 924 |
|
| 925 | 925 |
poll.WaitOn(c, pollCheck(c, d.CheckRunningTaskNetworks, checker.DeepEquals(map[string]int{barNetwork: 1, bazNetwork: 1})), poll.WithTimeout(defaultReconciliationTimeout))
|
| 926 |
- |
|
| 927 | 926 |
} |
| 928 | 927 |
|
| 929 | 928 |
func (s *DockerSwarmSuite) TestDNSConfig(c *testing.T) {
|
| ... | ... |
@@ -104,5 +104,4 @@ func (s *DockerSwarmSuite) TestSwarmNetworkPluginV2(c *testing.T) {
|
| 104 | 104 |
assert.NilError(c, err) |
| 105 | 105 |
|
| 106 | 106 |
poll.WaitOn(c, pollCheck(c, d1.CheckRunningTaskImages, checker.DeepEquals(map[string]int{image: 1})), poll.WithTimeout(defaultReconciliationTimeout))
|
| 107 |
- |
|
| 108 | 107 |
} |