Browse code

Simplify integration test for link + hostname.

Docker-DCO-1.1-Signed-off-by: Solomon Hykes <solomon@docker.com> (github: shykes)

Solomon Hykes authored on 2014/05/06 11:51:03
Showing 1 changed files
... ...
@@ -18,28 +18,13 @@ func TestPingUnlinkedContainers(t *testing.T) {
18 18
 }
19 19
 
20 20
 func TestPingLinkedContainers(t *testing.T) {
21
-	cmd := exec.Command(dockerBinary, "run", "-d", "--name", "container1", "busybox", "sleep", "10")
22
-	out, _, err := runCommandWithOutput(cmd)
23
-	errorOut(err, t, fmt.Sprintf("run container1 failed with errors: %v", err))
21
+	var out string
22
+	out, _, _ = cmd(t, "run", "-d", "--name", "container1", "busybox", "sleep", "10")
24 23
 	idA := stripTrailingCharacters(out)
25
-
26
-	cmd = exec.Command(dockerBinary, "run", "-d", "--name", "container2", "busybox", "sleep", "10")
27
-	out, _, err = runCommandWithOutput(cmd)
28
-	errorOut(err, t, fmt.Sprintf("run container2 failed with errors: %v", err))
24
+	out, _, _ = cmd("run", "-d", "--name", "container2", "busybox", "sleep", "10")
29 25
 	idB := stripTrailingCharacters(out)
30
-
31
-	cmd = exec.Command(dockerBinary, "run", "--rm", "--link", "container1:alias1", "--link", "container2:alias2", "busybox", "sh", "-c", "ping -c 1 alias1 -W 1 && ping -c 1 alias2 -W 1")
32
-	out, _, err = runCommandWithOutput(cmd)
33
-	fmt.Printf("OUT: %s", out)
34
-	errorOut(err, t, fmt.Sprintf("run ping failed with errors: %v", err))
35
-
36
-	cmd = exec.Command(dockerBinary, "kill", idA)
37
-	_, err = runCommand(cmd)
38
-	errorOut(err, t, fmt.Sprintf("failed to kill container1: %v", err))
39
-
40
-	cmd = exec.Command(dockerBinary, "kill", idB)
41
-	_, err = runCommand(cmd)
42
-	errorOut(err, t, fmt.Sprintf("failed to kill container2: %v", err))
43
-
26
+	cmd("run", "--rm", "--link", "container1:alias1", "--link", "container2:alias2", "busybox", "sh", "-c", "ping -c 1 alias1 -W 1 && ping -c 1 alias2 -W 1")
27
+	cmd("kill", idA)
28
+	cmd("kill", idB)
44 29
 	deleteAllContainers()
45 30
 }