GitList

Browse code

integration: copy loop variable into parallel test closures

Discovered a few instances, where loop variable is incorrectly used
within a test closure, which is marked as parallel.
Few of these were actually loops over singleton slices, therefore the issue
might not have surfaced there (yet), but it is good to fix there as
well, as this is an incorrect pattern used across different tests.

Signed-off-by: Roman Volosatovs <roman.volosatovs@docker.com>

Roman Volosatovs authored on 2021/07/23 05:41:01
Showing 4 changed files

integration/container/container_test.go index 86e02d9..60c0e12 100644
integration/network/network_test.go index a4057d2..66fdcfe 100644
integration/plugin/common/plugin_test.go index a5568cc..83e060f 100644
integration/volume/volume_test.go index 65f457d..f465e47 100644

integration/container/container_test.go

History View file @ dd01abf

@@ -19,6 +19,7 @@ func TestContainerInvalidJSON(t *testing.T) {
+                     	}
                      	for _, ep := range endpoints {
                     +		ep := ep
                      		t.Run(ep, func(t *testing.T) {
                      			t.Parallel()

integration/network/network_test.go

History View file @ dd01abf

@@ -72,6 +72,7 @@ func TestNetworkInvalidJSON(t *testing.T) {
+                     	}
                      	for _, ep := range endpoints {
                     +		ep := ep
                      		t.Run(ep, func(t *testing.T) {
                      			t.Parallel()
@@ -105,6 +106,7 @@ func TestNetworkList(t *testing.T) {
+                     	}
                      	for _, ep := range endpoints {
                     +		ep := ep
                      		t.Run(ep, func(t *testing.T) {
                      			t.Parallel()

integration/plugin/common/plugin_test.go

History View file @ dd01abf

@@ -36,6 +36,7 @@ func TestPluginInvalidJSON(t *testing.T) {
                      	endpoints := []string{"/plugins/foobar/set"}
                      	for _, ep := range endpoints {
                     +		ep := ep
                      		t.Run(ep, func(t *testing.T) {
                      			t.Parallel()

integration/volume/volume_test.go

History View file @ dd01abf

@@ -110,6 +110,7 @@ func TestVolumesInvalidJSON(t *testing.T) {
                      	endpoints := []string{"/volumes/create"}
                      	for _, ep := range endpoints {
                     +		ep := ep
                      		t.Run(ep, func(t *testing.T) {
                      			t.Parallel()