Browse code
if-return: redundant if ...; err != nil check (revive)
builder/builder-next/adapters/snapshot/snapshot.go:386:3: if-return: redundant if ...; err != nil check, just return error instead. (revive)
if err := b.Put(keyIsCommitted, []byte{}); err != nil {
return err
}
plugin/fetch_linux.go:112:2: if-return: redundant if ...; err != nil check, just return error instead. (revive)
if err := images.Dispatch(ctx, images.Handlers(handlers...), nil, desc); err != nil {
return err
}
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sebastiaan van Stijn authored on 2021/05/31 18:32:33Showing 2 changed files
| ... | ... |
@@ -383,10 +383,7 @@ func (s *snapshotter) Commit(ctx context.Context, name, key string, opts ...snap |
| 383 | 383 |
if err != nil {
|
| 384 | 384 |
return err |
| 385 | 385 |
} |
| 386 |
- if err := b.Put(keyIsCommitted, []byte{}); err != nil {
|
|
| 387 |
- return err |
|
| 388 |
- } |
|
| 389 |
- return nil |
|
| 386 |
+ return b.Put(keyIsCommitted, []byte{})
|
|
| 390 | 387 |
}) |
| 391 | 388 |
} |
| 392 | 389 |
|
| ... | ... |
@@ -109,10 +109,7 @@ func (pm *Manager) fetch(ctx context.Context, ref reference.Named, auth *types.A |
| 109 | 109 |
|
| 110 | 110 |
fp := withFetchProgress(pm.blobStore, out, ref) |
| 111 | 111 |
handlers = append([]images.Handler{fp, remotes.FetchHandler(pm.blobStore, fetcher)}, handlers...)
|
| 112 |
- if err := images.Dispatch(ctx, images.Handlers(handlers...), nil, desc); err != nil {
|
|
| 113 |
- return err |
|
| 114 |
- } |
|
| 115 |
- return nil |
|
| 112 |
+ return images.Dispatch(ctx, images.Handlers(handlers...), nil, desc) |
|
| 116 | 113 |
} |
| 117 | 114 |
|
| 118 | 115 |
// applyLayer makes an images.HandlerFunc which applies a fetched image rootfs layer to a directory. |