Browse code

hack/make.sh remove "latest" symlink

This symlink was added in d42753485b71f5f26b682a187d1963ef138cd0ab,
to allow finding the path to the latest built binary, because at the time,
those paths were prefixed with the version or commit (e.g. `bundles/1.5.0-dev`).

Commit bac2447964c8cdfcf35f928841d60310db997c76 removed the version-prefix in
paths, but kept the old symlink for backward compatiblity. However, many
things were moved since then (e.g. paths were renamed to `binary-daemon`,
and various other changes). With the symlink pointing to the symlink's parent
directory, following the symlink may result into an infinite recursion,
which can happen if scripts using wildcards / globbing to find files.

With this symlink no longer serving a real purpose, we can probably safely
remove this symlink now.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Sebastiaan van Stijn authored on 2019/08/25 22:57:22
Showing 1 changed files
... ...
@@ -171,13 +171,6 @@ main() {
171 171
 	fi
172 172
 	mkdir -p bundles
173 173
 
174
-	# Windows and symlinks don't get along well
175
-	if [ "$(go env GOHOSTOS)" != 'windows' ]; then
176
-		rm -f bundles/latest
177
-		# preserve latest symlink for backward compatibility
178
-		ln -sf . bundles/latest
179
-	fi
180
-
181 174
 	if [ $# -lt 1 ]; then
182 175
 		bundles=(${DEFAULT_BUNDLES[@]})
183 176
 	else