Browse code

Windows: skip flaky TestLogBlocking

This test frequently fails on Windows RS1 (mainly), so skipping it
for now on Windows;

```
ok github.com/docker/docker/daemon/logger 0.525s coverage: 43.0% of statements
time="2019-09-09T20:37:35Z" level=info msg="Trying to get region from EC2 Metadata"
time="2019-09-09T20:37:36Z" level=info msg="Log stream already exists" errorCode=ResourceAlreadyExistsException logGroupName= logStreamName= message= origError="<nil>"
--- FAIL: TestLogBlocking (0.02s)
cloudwatchlogs_test.go:313: Expected to be able to read from stream.messages but was unable to
time="2019-09-09T20:37:36Z" level=error msg=Error
time="2019-09-09T20:37:36Z" level=error msg="Failed to put log events" errorCode=InvalidSequenceTokenException logGroupName=groupName logStreamName=streamName message="use token token" origError="<nil>"
time="2019-09-09T20:37:36Z" level=error msg="Failed to put log events" errorCode=DataAlreadyAcceptedException logGroupName=groupName logStreamName=streamName message="use token token" origError="<nil>"
time="2019-09-09T20:37:36Z" level=info msg="Data already accepted, ignoring error" errorCode=DataAlreadyAcceptedException logGroupName=groupName logStreamName=streamName message="use token token"
FAIL
coverage: 78.2% of statements
FAIL github.com/docker/docker/daemon/logger/awslogs 0.630s
```

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 6c75c862403c98138ab0f7811f6ba9113f9e5d61)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Sebastiaan van Stijn authored on 2019/09/10 06:50:04
Showing 1 changed files
... ...
@@ -24,6 +24,7 @@ import (
24 24
 	"github.com/docker/docker/dockerversion"
25 25
 	"gotest.tools/assert"
26 26
 	is "gotest.tools/assert/cmp"
27
+	"gotest.tools/skip"
27 28
 )
28 29
 
29 30
 const (
... ...
@@ -286,6 +287,7 @@ func TestLogClosed(t *testing.T) {
286 286
 }
287 287
 
288 288
 func TestLogBlocking(t *testing.T) {
289
+	skip.If(t, runtime.GOOS == "windows", "FIXME: test is flaky on Windows. See #39857")
289 290
 	mockClient := newMockClient()
290 291
 	stream := &logStream{
291 292
 		client:   mockClient,