Signed-off-by: Vincent Demeester <vincent@sbr.pm>
Vincent Demeester authored on 2017/10/25 21:39:51... | ... |
@@ -50,7 +50,7 @@ func (p *v1Puller) Pull(ctx context.Context, ref reference.Named, platform strin |
50 | 50 |
tr := transport.NewTransport( |
51 | 51 |
// TODO(tiborvass): was ReceiveTimeout |
52 | 52 |
registry.NewTransport(tlsConfig), |
53 |
- registry.DockerHeaders(dockerversion.DockerUserAgent(ctx), p.config.MetaHeaders)..., |
|
53 |
+ registry.Headers(dockerversion.DockerUserAgent(ctx), p.config.MetaHeaders)..., |
|
54 | 54 |
) |
55 | 55 |
client := registry.HTTPClient(tr) |
56 | 56 |
v1Endpoint := p.endpoint.ToV1Endpoint(dockerversion.DockerUserAgent(ctx), p.config.MetaHeaders) |
... | ... |
@@ -38,7 +38,7 @@ func (p *v1Pusher) Push(ctx context.Context) error { |
38 | 38 |
tr := transport.NewTransport( |
39 | 39 |
// TODO(tiborvass): was NoTimeout |
40 | 40 |
registry.NewTransport(tlsConfig), |
41 |
- registry.DockerHeaders(dockerversion.DockerUserAgent(ctx), p.config.MetaHeaders)..., |
|
41 |
+ registry.Headers(dockerversion.DockerUserAgent(ctx), p.config.MetaHeaders)..., |
|
42 | 42 |
) |
43 | 43 |
client := registry.HTTPClient(tr) |
44 | 44 |
v1Endpoint := p.endpoint.ToV1Endpoint(dockerversion.DockerUserAgent(ctx), p.config.MetaHeaders) |
... | ... |
@@ -82,7 +82,7 @@ func NewV2Repository(ctx context.Context, repoInfo *registry.RepositoryInfo, end |
82 | 82 |
base.Dial = proxyDialer.Dial |
83 | 83 |
} |
84 | 84 |
|
85 |
- modifiers := registry.DockerHeaders(dockerversion.DockerUserAgent(ctx), metaHeaders) |
|
85 |
+ modifiers := registry.Headers(dockerversion.DockerUserAgent(ctx), metaHeaders) |
|
86 | 86 |
authTransport := transport.NewTransport(base, modifiers...) |
87 | 87 |
|
88 | 88 |
challengeManager, foundVersion, err := registry.PingV2Registry(endpoint.URL, authTransport) |
... | ... |
@@ -29,9 +29,9 @@ var ( |
29 | 29 |
// ValidateHost validates that the specified string is a valid host and returns it. |
30 | 30 |
func ValidateHost(val string) (string, error) { |
31 | 31 |
host := strings.TrimSpace(val) |
32 |
- // The empty string means default and is not handled by parseDockerDaemonHost |
|
32 |
+ // The empty string means default and is not handled by parseDaemonHost |
|
33 | 33 |
if host != "" { |
34 |
- _, err := parseDockerDaemonHost(host) |
|
34 |
+ _, err := parseDaemonHost(host) |
|
35 | 35 |
if err != nil { |
36 | 36 |
return val, err |
37 | 37 |
} |
... | ... |
@@ -52,7 +52,7 @@ func ParseHost(defaultToTLS bool, val string) (string, error) { |
52 | 52 |
} |
53 | 53 |
} else { |
54 | 54 |
var err error |
55 |
- host, err = parseDockerDaemonHost(host) |
|
55 |
+ host, err = parseDaemonHost(host) |
|
56 | 56 |
if err != nil { |
57 | 57 |
return val, err |
58 | 58 |
} |
... | ... |
@@ -60,9 +60,9 @@ func ParseHost(defaultToTLS bool, val string) (string, error) { |
60 | 60 |
return host, nil |
61 | 61 |
} |
62 | 62 |
|
63 |
-// parseDockerDaemonHost parses the specified address and returns an address that will be used as the host. |
|
63 |
+// parseDaemonHost parses the specified address and returns an address that will be used as the host. |
|
64 | 64 |
// Depending of the address specified, this may return one of the global Default* strings defined in hosts.go. |
65 |
-func parseDockerDaemonHost(addr string) (string, error) { |
|
65 |
+func parseDaemonHost(addr string) (string, error) { |
|
66 | 66 |
addrParts := strings.SplitN(addr, "://", 2) |
67 | 67 |
if len(addrParts) == 1 && addrParts[0] != "" { |
68 | 68 |
addrParts = []string{"tcp", addrParts[0]} |
... | ... |
@@ -83,12 +83,12 @@ func TestParseDockerDaemonHost(t *testing.T) { |
83 | 83 |
"localhost:5555/path": "tcp://localhost:5555/path", |
84 | 84 |
} |
85 | 85 |
for invalidAddr, expectedError := range invalids { |
86 |
- if addr, err := parseDockerDaemonHost(invalidAddr); err == nil || err.Error() != expectedError { |
|
86 |
+ if addr, err := parseDaemonHost(invalidAddr); err == nil || err.Error() != expectedError { |
|
87 | 87 |
t.Errorf("tcp %v address expected error %q return, got %q and addr %v", invalidAddr, expectedError, err, addr) |
88 | 88 |
} |
89 | 89 |
} |
90 | 90 |
for validAddr, expectedAddr := range valids { |
91 |
- if addr, err := parseDockerDaemonHost(validAddr); err != nil || addr != expectedAddr { |
|
91 |
+ if addr, err := parseDaemonHost(validAddr); err != nil || addr != expectedAddr { |
|
92 | 92 |
t.Errorf("%v -> expected %v, got (%v) addr (%v)", validAddr, expectedAddr, err, addr) |
93 | 93 |
} |
94 | 94 |
} |
... | ... |
@@ -125,7 +125,7 @@ func (err fallbackError) Error() string { |
125 | 125 |
func loginV2(authConfig *types.AuthConfig, endpoint APIEndpoint, userAgent string) (string, string, error) { |
126 | 126 |
logrus.Debugf("attempting v2 login to registry endpoint %s", strings.TrimRight(endpoint.URL.String(), "/")+"/v2/") |
127 | 127 |
|
128 |
- modifiers := DockerHeaders(userAgent, nil) |
|
128 |
+ modifiers := Headers(userAgent, nil) |
|
129 | 129 |
authTransport := transport.NewTransport(NewTransport(endpoint.TLSConfig), modifiers...) |
130 | 130 |
|
131 | 131 |
credentialAuthConfig := *authConfig |
... | ... |
@@ -77,7 +77,7 @@ func newV1Endpoint(address url.URL, tlsConfig *tls.Config, userAgent string, met |
77 | 77 |
|
78 | 78 |
// TODO(tiborvass): make sure a ConnectTimeout transport is used |
79 | 79 |
tr := NewTransport(tlsConfig) |
80 |
- endpoint.client = HTTPClient(transport.NewTransport(tr, DockerHeaders(userAgent, metaHeaders)...)) |
|
80 |
+ endpoint.client = HTTPClient(transport.NewTransport(tr, Headers(userAgent, metaHeaders)...)) |
|
81 | 81 |
return endpoint |
82 | 82 |
} |
83 | 83 |
|
... | ... |
@@ -102,8 +102,8 @@ func ReadCertsDirectory(tlsConfig *tls.Config, directory string) error { |
102 | 102 |
return nil |
103 | 103 |
} |
104 | 104 |
|
105 |
-// DockerHeaders returns request modifiers with a User-Agent and metaHeaders |
|
106 |
-func DockerHeaders(userAgent string, metaHeaders http.Header) []transport.RequestModifier { |
|
105 |
+// Headers returns request modifiers with a User-Agent and metaHeaders |
|
106 |
+func Headers(userAgent string, metaHeaders http.Header) []transport.RequestModifier { |
|
107 | 107 |
modifiers := []transport.RequestModifier{} |
108 | 108 |
if userAgent != "" { |
109 | 109 |
modifiers = append(modifiers, transport.NewHeaderRequestModifier(http.Header{ |
... | ... |
@@ -34,7 +34,7 @@ func spawnTestRegistrySession(t *testing.T) *Session { |
34 | 34 |
} |
35 | 35 |
userAgent := "docker test client" |
36 | 36 |
var tr http.RoundTripper = debugTransport{NewTransport(nil), t.Log} |
37 |
- tr = transport.NewTransport(AuthTransport(tr, authConfig, false), DockerHeaders(userAgent, nil)...) |
|
37 |
+ tr = transport.NewTransport(AuthTransport(tr, authConfig, false), Headers(userAgent, nil)...) |
|
38 | 38 |
client := HTTPClient(tr) |
39 | 39 |
r, err := NewSession(client, authConfig, endpoint) |
40 | 40 |
if err != nil { |
... | ... |
@@ -199,7 +199,7 @@ func (s *DefaultService) Search(ctx context.Context, term string, limit int, aut |
199 | 199 |
}, |
200 | 200 |
} |
201 | 201 |
|
202 |
- modifiers := DockerHeaders(userAgent, nil) |
|
202 |
+ modifiers := Headers(userAgent, nil) |
|
203 | 203 |
v2Client, foundV2, err := v2AuthHTTPClient(endpoint.URL, endpoint.client.Transport, modifiers, creds, scopes) |
204 | 204 |
if err != nil { |
205 | 205 |
if fErr, ok := err.(fallbackError); ok { |