Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sebastiaan van Stijn authored on 2018/01/15 23:31:02... | ... |
@@ -47,7 +47,7 @@ func (s *DockerSuite) TestContainersAPICreateMountsBindNamedPipe(c *check.C) { |
47 | 47 |
|
48 | 48 |
name := "test-bind-npipe" |
49 | 49 |
data := map[string]interface{}{ |
50 |
- "Image": testEnv.MinimalBaseImage(), |
|
50 |
+ "Image": testEnv.PlatformDefaults.BaseImage, |
|
51 | 51 |
"Cmd": []string{"cmd", "/c", cmd}, |
52 | 52 |
"HostConfig": map[string]interface{}{"Mounts": []map[string]interface{}{{"Type": "npipe", "Source": hostPipeName, "Target": containerPipeName}}}, |
53 | 53 |
} |
... | ... |
@@ -603,7 +603,7 @@ RUN [ $(cat "/test dir/test_file6") = 'test6' ]`, command, command, command, com |
603 | 603 |
|
604 | 604 |
func (s *DockerSuite) TestBuildCopyFileWithWhitespaceOnWindows(c *check.C) { |
605 | 605 |
testRequires(c, DaemonIsWindows) |
606 |
- dockerfile := `FROM ` + testEnv.MinimalBaseImage() + ` |
|
606 |
+ dockerfile := `FROM ` + testEnv.PlatformDefaults.BaseImage + ` |
|
607 | 607 |
RUN mkdir "C:/test dir" |
608 | 608 |
RUN mkdir "C:/test_dir" |
609 | 609 |
COPY [ "test file1", "/test_file1" ] |
... | ... |
@@ -5148,7 +5148,7 @@ func (s *DockerSuite) TestBuildWorkdirWindowsPath(c *check.C) { |
5148 | 5148 |
testRequires(c, DaemonIsWindows) |
5149 | 5149 |
name := "testbuildworkdirwindowspath" |
5150 | 5150 |
buildImageSuccessfully(c, name, build.WithDockerfile(` |
5151 |
- FROM `+testEnv.MinimalBaseImage()+` |
|
5151 |
+ FROM `+testEnv.PlatformDefaults.BaseImage+` |
|
5152 | 5152 |
RUN mkdir C:\\work |
5153 | 5153 |
WORKDIR C:\\work |
5154 | 5154 |
RUN if "%CD%" NEQ "C:\work" exit -1 |
... | ... |
@@ -6143,7 +6143,7 @@ func (s *DockerTrustSuite) TestBuildMultiStageTrusted(c *check.C) { |
6143 | 6143 |
func (s *DockerSuite) TestBuildMultiStageMultipleBuildsWindows(c *check.C) { |
6144 | 6144 |
testRequires(c, DaemonIsWindows) |
6145 | 6145 |
dockerfile := ` |
6146 |
- FROM ` + testEnv.MinimalBaseImage() + ` |
|
6146 |
+ FROM ` + testEnv.PlatformDefaults.BaseImage + ` |
|
6147 | 6147 |
COPY foo c:\\bar` |
6148 | 6148 |
ctx := fakecontext.New(c, "", |
6149 | 6149 |
fakecontext.WithDockerfile(dockerfile), |
... | ... |
@@ -6156,7 +6156,7 @@ func (s *DockerSuite) TestBuildMultiStageMultipleBuildsWindows(c *check.C) { |
6156 | 6156 |
|
6157 | 6157 |
dockerfile = ` |
6158 | 6158 |
FROM build1:latest |
6159 |
- FROM ` + testEnv.MinimalBaseImage() + ` |
|
6159 |
+ FROM ` + testEnv.PlatformDefaults.BaseImage + ` |
|
6160 | 6160 |
COPY --from=0 c:\\bar / |
6161 | 6161 |
COPY foo /` |
6162 | 6162 |
ctx = fakecontext.New(c, "", |
... | ... |
@@ -6177,8 +6177,8 @@ func (s *DockerSuite) TestBuildMultiStageMultipleBuildsWindows(c *check.C) { |
6177 | 6177 |
func (s *DockerSuite) TestBuildCopyFromForbidWindowsSystemPaths(c *check.C) { |
6178 | 6178 |
testRequires(c, DaemonIsWindows) |
6179 | 6179 |
dockerfile := ` |
6180 |
- FROM ` + testEnv.MinimalBaseImage() + ` |
|
6181 |
- FROM ` + testEnv.MinimalBaseImage() + ` |
|
6180 |
+ FROM ` + testEnv.PlatformDefaults.BaseImage + ` |
|
6181 |
+ FROM ` + testEnv.PlatformDefaults.BaseImage + ` |
|
6182 | 6182 |
COPY --from=0 %s c:\\oscopy |
6183 | 6183 |
` |
6184 | 6184 |
exp := icmd.Expected{ |
... | ... |
@@ -6194,8 +6194,8 @@ func (s *DockerSuite) TestBuildCopyFromForbidWindowsSystemPaths(c *check.C) { |
6194 | 6194 |
func (s *DockerSuite) TestBuildCopyFromForbidWindowsRelativePaths(c *check.C) { |
6195 | 6195 |
testRequires(c, DaemonIsWindows) |
6196 | 6196 |
dockerfile := ` |
6197 |
- FROM ` + testEnv.MinimalBaseImage() + ` |
|
6198 |
- FROM ` + testEnv.MinimalBaseImage() + ` |
|
6197 |
+ FROM ` + testEnv.PlatformDefaults.BaseImage + ` |
|
6198 |
+ FROM ` + testEnv.PlatformDefaults.BaseImage + ` |
|
6199 | 6199 |
COPY --from=0 %s c:\\oscopy |
6200 | 6200 |
` |
6201 | 6201 |
exp := icmd.Expected{ |
... | ... |
@@ -6212,9 +6212,9 @@ func (s *DockerSuite) TestBuildCopyFromForbidWindowsRelativePaths(c *check.C) { |
6212 | 6212 |
func (s *DockerSuite) TestBuildCopyFromWindowsIsCaseInsensitive(c *check.C) { |
6213 | 6213 |
testRequires(c, DaemonIsWindows) |
6214 | 6214 |
dockerfile := ` |
6215 |
- FROM ` + testEnv.MinimalBaseImage() + ` |
|
6215 |
+ FROM ` + testEnv.PlatformDefaults.BaseImage + ` |
|
6216 | 6216 |
COPY foo / |
6217 |
- FROM ` + testEnv.MinimalBaseImage() + ` |
|
6217 |
+ FROM ` + testEnv.PlatformDefaults.BaseImage + ` |
|
6218 | 6218 |
COPY --from=0 c:\\fOo c:\\copied |
6219 | 6219 |
RUN type c:\\copied |
6220 | 6220 |
` |
... | ... |
@@ -6294,7 +6294,7 @@ func (s *DockerSuite) TestBuildOpaqueDirectory(c *check.C) { |
6294 | 6294 |
func (s *DockerSuite) TestBuildWindowsUser(c *check.C) { |
6295 | 6295 |
testRequires(c, DaemonIsWindows) |
6296 | 6296 |
name := "testbuildwindowsuser" |
6297 |
- buildImage(name, build.WithDockerfile(`FROM `+testEnv.MinimalBaseImage()+` |
|
6297 |
+ buildImage(name, build.WithDockerfile(`FROM `+testEnv.PlatformDefaults.BaseImage+` |
|
6298 | 6298 |
RUN net user user /add |
6299 | 6299 |
USER user |
6300 | 6300 |
RUN set username |
... | ... |
@@ -6325,7 +6325,7 @@ func (s *DockerSuite) TestBuildWindowsEnvCaseInsensitive(c *check.C) { |
6325 | 6325 |
testRequires(c, DaemonIsWindows) |
6326 | 6326 |
name := "testbuildwindowsenvcaseinsensitive" |
6327 | 6327 |
buildImageSuccessfully(c, name, build.WithDockerfile(` |
6328 |
- FROM `+testEnv.MinimalBaseImage()+` |
|
6328 |
+ FROM `+testEnv.PlatformDefaults.BaseImage+` |
|
6329 | 6329 |
ENV FOO=bar foo=baz |
6330 | 6330 |
`)) |
6331 | 6331 |
res := inspectFieldJSON(c, name, "Config.Env") |
... | ... |
@@ -225,7 +225,7 @@ func (s *DockerSuite) TestCreateHostnameWithNumber(c *check.C) { |
225 | 225 |
image := "busybox" |
226 | 226 |
// Busybox on Windows does not implement hostname command |
227 | 227 |
if testEnv.DaemonPlatform() == "windows" { |
228 |
- image = testEnv.MinimalBaseImage() |
|
228 |
+ image = testEnv.PlatformDefaults.BaseImage |
|
229 | 229 |
} |
230 | 230 |
out, _ := dockerCmd(c, "run", "-h", "web.0", image, "hostname") |
231 | 231 |
c.Assert(strings.TrimSpace(out), checker.Equals, "web.0", check.Commentf("hostname not set, expected `web.0`, got: %s", out)) |
... | ... |
@@ -75,7 +75,7 @@ func (s *DockerSuite) TestRunLookupGoogleDNS(c *check.C) { |
75 | 75 |
if testEnv.DaemonPlatform() == "windows" { |
76 | 76 |
// nslookup isn't present in Windows busybox. Is built-in. Further, |
77 | 77 |
// nslookup isn't present in nanoserver. Hence just use PowerShell... |
78 |
- dockerCmd(c, "run", testEnv.MinimalBaseImage(), "powershell", "Resolve-DNSName", "google.com") |
|
78 |
+ dockerCmd(c, "run", testEnv.PlatformDefaults.BaseImage, "powershell", "Resolve-DNSName", "google.com") |
|
79 | 79 |
} else { |
80 | 80 |
dockerCmd(c, "run", "busybox", "nslookup", "google.com") |
81 | 81 |
} |
... | ... |
@@ -162,7 +162,7 @@ func (s *DockerSuite) TestRunWithoutNetworking(c *check.C) { |
162 | 162 |
image := "busybox" |
163 | 163 |
if testEnv.DaemonPlatform() == "windows" { |
164 | 164 |
count = "-n" |
165 |
- image = testEnv.MinimalBaseImage() |
|
165 |
+ image = testEnv.PlatformDefaults.BaseImage |
|
166 | 166 |
} |
167 | 167 |
|
168 | 168 |
// First using the long form --net |
... | ... |
@@ -355,7 +355,7 @@ func (s *DockerSuite) TestRunWithVolumesFromExited(c *check.C) { |
355 | 355 |
|
356 | 356 |
// Create a file in a volume |
357 | 357 |
if testEnv.DaemonPlatform() == "windows" { |
358 |
- out, exitCode = dockerCmd(c, "run", "--name", "test-data", "--volume", `c:\some\dir`, testEnv.MinimalBaseImage(), "cmd", "/c", `echo hello > c:\some\dir\file`) |
|
358 |
+ out, exitCode = dockerCmd(c, "run", "--name", "test-data", "--volume", `c:\some\dir`, testEnv.PlatformDefaults.BaseImage, "cmd", "/c", `echo hello > c:\some\dir\file`) |
|
359 | 359 |
} else { |
360 | 360 |
out, exitCode = dockerCmd(c, "run", "--name", "test-data", "--volume", "/some/dir", "busybox", "touch", "/some/dir/file") |
361 | 361 |
} |
... | ... |
@@ -365,7 +365,7 @@ func (s *DockerSuite) TestRunWithVolumesFromExited(c *check.C) { |
365 | 365 |
|
366 | 366 |
// Read the file from another container using --volumes-from to access the volume in the second container |
367 | 367 |
if testEnv.DaemonPlatform() == "windows" { |
368 |
- out, exitCode = dockerCmd(c, "run", "--volumes-from", "test-data", testEnv.MinimalBaseImage(), "cmd", "/c", `type c:\some\dir\file`) |
|
368 |
+ out, exitCode = dockerCmd(c, "run", "--volumes-from", "test-data", testEnv.PlatformDefaults.BaseImage, "cmd", "/c", `type c:\some\dir\file`) |
|
369 | 369 |
} else { |
370 | 370 |
out, exitCode = dockerCmd(c, "run", "--volumes-from", "test-data", "busybox", "cat", "/some/dir/file") |
371 | 371 |
} |
... | ... |
@@ -407,7 +407,7 @@ func (s *DockerSuite) TestRunCreateVolumesInSymlinkDir(c *check.C) { |
407 | 407 |
f.Close() |
408 | 408 |
|
409 | 409 |
if testEnv.DaemonPlatform() == "windows" { |
410 |
- dockerFile = fmt.Sprintf("FROM %s\nRUN mkdir %s\nRUN mklink /D c:\\test %s", testEnv.MinimalBaseImage(), dir, dir) |
|
410 |
+ dockerFile = fmt.Sprintf("FROM %s\nRUN mkdir %s\nRUN mklink /D c:\\test %s", testEnv.PlatformDefaults.BaseImage, dir, dir) |
|
411 | 411 |
containerPath = `c:\test\test` |
412 | 412 |
cmd = "tasklist" |
413 | 413 |
} else { |
... | ... |
@@ -432,7 +432,7 @@ func (s *DockerSuite) TestRunCreateVolumesInSymlinkDir2(c *check.C) { |
432 | 432 |
name := "test-volume-symlink2" |
433 | 433 |
|
434 | 434 |
if testEnv.DaemonPlatform() == "windows" { |
435 |
- dockerFile = fmt.Sprintf("FROM %s\nRUN mkdir c:\\%s\nRUN mklink /D c:\\test c:\\%s", testEnv.MinimalBaseImage(), name, name) |
|
435 |
+ dockerFile = fmt.Sprintf("FROM %s\nRUN mkdir c:\\%s\nRUN mklink /D c:\\test c:\\%s", testEnv.PlatformDefaults.BaseImage, name, name) |
|
436 | 436 |
containerPath = `c:\test\test` |
437 | 437 |
cmd = "tasklist" |
438 | 438 |
} else { |
... | ... |
@@ -670,7 +670,7 @@ func (s *DockerSuite) TestRunVolumesFromSymlinkPath(c *check.C) { |
670 | 670 |
|
671 | 671 |
if testEnv.DaemonPlatform() == "windows" { |
672 | 672 |
prefix = `c:` |
673 |
- dfContents = `FROM ` + testEnv.MinimalBaseImage() + ` |
|
673 |
+ dfContents = `FROM ` + testEnv.PlatformDefaults.BaseImage + ` |
|
674 | 674 |
RUN mkdir c:\home |
675 | 675 |
RUN mklink /D c:\foo c:\home |
676 | 676 |
VOLUME ["c:/foo/bar"] |
... | ... |
@@ -922,7 +922,7 @@ func (s *DockerSuite) TestRunEnvironmentOverride(c *check.C) { |
922 | 922 |
func (s *DockerSuite) TestRunContainerNetwork(c *check.C) { |
923 | 923 |
if testEnv.DaemonPlatform() == "windows" { |
924 | 924 |
// Windows busybox does not have ping. Use built in ping instead. |
925 |
- dockerCmd(c, "run", testEnv.MinimalBaseImage(), "ping", "-n", "1", "127.0.0.1") |
|
925 |
+ dockerCmd(c, "run", testEnv.PlatformDefaults.BaseImage, "ping", "-n", "1", "127.0.0.1") |
|
926 | 926 |
} else { |
927 | 927 |
dockerCmd(c, "run", "busybox", "ping", "-c", "1", "127.0.0.1") |
928 | 928 |
} |
... | ... |
@@ -1231,7 +1231,7 @@ func (s *DockerSuite) TestRunRootWorkdir(c *check.C) { |
1231 | 1231 |
func (s *DockerSuite) TestRunAllowBindMountingRoot(c *check.C) { |
1232 | 1232 |
if testEnv.DaemonPlatform() == "windows" { |
1233 | 1233 |
// Windows busybox will fail with Permission Denied on items such as pagefile.sys |
1234 |
- dockerCmd(c, "run", "-v", `c:\:c:\host`, testEnv.MinimalBaseImage(), "cmd", "-c", "dir", `c:\host`) |
|
1234 |
+ dockerCmd(c, "run", "-v", `c:\:c:\host`, testEnv.PlatformDefaults.BaseImage, "cmd", "-c", "dir", `c:\host`) |
|
1235 | 1235 |
} else { |
1236 | 1236 |
dockerCmd(c, "run", "-v", "/:/host", "busybox", "ls", "/host") |
1237 | 1237 |
} |
... | ... |
@@ -1705,14 +1705,14 @@ func (s *DockerSuite) TestRunCleanupCmdOnEntrypoint(c *check.C) { |
1705 | 1705 |
out = strings.TrimSpace(out) |
1706 | 1706 |
expected := "root" |
1707 | 1707 |
if testEnv.DaemonPlatform() == "windows" { |
1708 |
- if strings.Contains(testEnv.MinimalBaseImage(), "windowsservercore") { |
|
1708 |
+ if strings.Contains(testEnv.PlatformDefaults.BaseImage, "windowsservercore") { |
|
1709 | 1709 |
expected = `user manager\containeradministrator` |
1710 | 1710 |
} else { |
1711 | 1711 |
expected = `ContainerAdministrator` // nanoserver |
1712 | 1712 |
} |
1713 | 1713 |
} |
1714 | 1714 |
if out != expected { |
1715 |
- c.Fatalf("Expected output %s, got %q. %s", expected, out, testEnv.MinimalBaseImage()) |
|
1715 |
+ c.Fatalf("Expected output %s, got %q. %s", expected, out, testEnv.PlatformDefaults.BaseImage) |
|
1716 | 1716 |
} |
1717 | 1717 |
} |
1718 | 1718 |
|
... | ... |
@@ -1944,7 +1944,7 @@ func (s *DockerSuite) TestRunCidFileCleanupIfEmpty(c *check.C) { |
1944 | 1944 |
image := "emptyfs" |
1945 | 1945 |
if testEnv.DaemonPlatform() == "windows" { |
1946 | 1946 |
// Windows can't support an emptyfs image. Just use the regular Windows image |
1947 |
- image = testEnv.MinimalBaseImage() |
|
1947 |
+ image = testEnv.PlatformDefaults.BaseImage |
|
1948 | 1948 |
} |
1949 | 1949 |
out, _, err := dockerCmdWithError("run", "--cidfile", tmpCidFile, image) |
1950 | 1950 |
if err == nil { |
... | ... |
@@ -2561,7 +2561,7 @@ func (s *DockerSuite) TestRunNonLocalMacAddress(c *check.C) { |
2561 | 2561 |
if testEnv.DaemonPlatform() != "windows" { |
2562 | 2562 |
args = append(args, "busybox", "ifconfig") |
2563 | 2563 |
} else { |
2564 |
- args = append(args, testEnv.MinimalBaseImage(), "ipconfig", "/all") |
|
2564 |
+ args = append(args, testEnv.PlatformDefaults.BaseImage, "ipconfig", "/all") |
|
2565 | 2565 |
expected = strings.Replace(strings.ToUpper(addr), ":", "-", -1) |
2566 | 2566 |
} |
2567 | 2567 |
|
... | ... |
@@ -3483,7 +3483,7 @@ func (s *DockerSuite) TestRunLoopbackOnlyExistsWhenNetworkingDisabled(c *check.C |
3483 | 3483 |
// Issue #4681 |
3484 | 3484 |
func (s *DockerSuite) TestRunLoopbackWhenNetworkDisabled(c *check.C) { |
3485 | 3485 |
if testEnv.DaemonPlatform() == "windows" { |
3486 |
- dockerCmd(c, "run", "--net=none", testEnv.MinimalBaseImage(), "ping", "-n", "1", "127.0.0.1") |
|
3486 |
+ dockerCmd(c, "run", "--net=none", testEnv.PlatformDefaults.BaseImage, "ping", "-n", "1", "127.0.0.1") |
|
3487 | 3487 |
} else { |
3488 | 3488 |
dockerCmd(c, "run", "--net=none", "busybox", "ping", "-c", "1", "127.0.0.1") |
3489 | 3489 |
} |
... | ... |
@@ -4253,7 +4253,7 @@ func (s *DockerSuite) TestRunServicingContainer(c *check.C) { |
4253 | 4253 |
c.Skip("Disabled on post-RS3 builds") |
4254 | 4254 |
} |
4255 | 4255 |
|
4256 |
- out := cli.DockerCmd(c, "run", "-d", testEnv.MinimalBaseImage(), "cmd", "/c", "mkdir c:\\programdata\\Microsoft\\Windows\\ContainerUpdates\\000_000_d99f45d0-ffc8-4af7-bd9c-ea6a62e035c9_200 && sc control cexecsvc 255").Combined() |
|
4256 |
+ out := cli.DockerCmd(c, "run", "-d", testEnv.PlatformDefaults.BaseImage, "cmd", "/c", "mkdir c:\\programdata\\Microsoft\\Windows\\ContainerUpdates\\000_000_d99f45d0-ffc8-4af7-bd9c-ea6a62e035c9_200 && sc control cexecsvc 255").Combined() |
|
4257 | 4257 |
containerID := strings.TrimSpace(out) |
4258 | 4258 |
cli.WaitExited(c, containerID, 60*time.Second) |
4259 | 4259 |
|
... | ... |
@@ -399,7 +399,7 @@ func runSleepingContainerInImage(c *check.C, image string, extraArgs ...string) |
399 | 399 |
// minimalBaseImage returns the name of the minimal base image for the current |
400 | 400 |
// daemon platform. |
401 | 401 |
func minimalBaseImage() string { |
402 |
- return testEnv.MinimalBaseImage() |
|
402 |
+ return testEnv.PlatformDefaults.BaseImage |
|
403 | 403 |
} |
404 | 404 |
|
405 | 405 |
func getGoroutineNumber() (int, error) { |
... | ... |
@@ -57,9 +57,3 @@ func New() (*Execution, error) { |
57 | 57 |
func (e *Execution) DaemonPlatform() string { |
58 | 58 |
return e.OSType |
59 | 59 |
} |
60 |
- |
|
61 |
-// MinimalBaseImage is the image used for minimal builds (it depends on the platform) |
|
62 |
-// Deprecated: use Execution.PlatformDefaults.BaseImage |
|
63 |
-func (e *Execution) MinimalBaseImage() string { |
|
64 |
- return e.PlatformDefaults.BaseImage |
|
65 |
-} |